public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Tor: fix permissions of /var/ipfire/tor/torrc after installation
Date: Tue, 12 Nov 2019 21:32:00 +0000	[thread overview]
Message-ID: <0b93a03e-dd4f-3993-1118-d9283fd44d05@ipfire.org> (raw)
In-Reply-To: <20191112200649.5021-1-sfeddersen@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

Hello Stephan,

unfortunately, I do not understand this mail. Isn't that the Tor
permission patch of mine sent in a while ago? What is the relationship
to wio?

Besides: Your other patches miss the "Signed-off-by"-Tag. Just
thought you might want to know...

Thanks, and best regards,
Peter Müller


> From: "peter.mueller(a)ipfire.org" <peter.mueller(a)ipfire.org>
> 
> Fixes #12220
> 
> Reported-by: Michael Tremer <michael.tremer(a)ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
>  lfs/tor                 | 2 +-
>  src/paks/tor/install.sh | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lfs/tor b/lfs/tor
> index ea07f6ce2..178f84be9 100644
> --- a/lfs/tor
> +++ b/lfs/tor
> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = tor
> -PAK_VER    = 43
> +PAK_VER    = 44
>  
>  DEPS       = "libseccomp"
>  
> diff --git a/src/paks/tor/install.sh b/src/paks/tor/install.sh
> index 4d0353155..369b65f71 100644
> --- a/src/paks/tor/install.sh
> +++ b/src/paks/tor/install.sh
> @@ -36,10 +36,10 @@ extract_files
>  restore_backup ${NAME}
>  
>  # Adjust some folder permission for new UID/GID
> -chown -R tor:tor /var/lib/tor /var/ipfire/tor
> +chown -R tor:tor /var/lib/tor
> +chown -R tor:nobody /var/ipfire/tor
>  
> -# Tor settings file needs to be writeable by nobody group for WebUI
> -chown tor:nobody /var/ipfire/tor/settings
> -chmod 664 /var/ipfire/tor/settings
> +# Tor settings files needs to be writeable by nobody group for WebUI
> +chmod 664 /var/ipfire/tor/{settings,torrc}
>  
>  start_service --background ${NAME}
> 

  parent reply	other threads:[~2019-11-12 21:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 20:06 Stephan Feddersen
2019-11-12 20:06 ` [PATCH 2/2] wio-1.3.1-1: bugfixing arp client import Stephan Feddersen
2019-11-12 21:32 ` Peter Müller [this message]
2019-11-13 10:04   ` [PATCH 1/2] Tor: fix permissions of /var/ipfire/tor/torrc after installation Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b93a03e-dd4f-3993-1118-d9283fd44d05@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox