From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Tor: fix permissions of /var/ipfire/tor/torrc after
 installation
Date: Tue, 12 Nov 2019 21:32:00 +0000
Message-ID: <0b93a03e-dd4f-3993-1118-d9283fd44d05@ipfire.org>
In-Reply-To: <20191112200649.5021-1-sfeddersen@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4251998757462880218=="
List-Id: <development.lists.ipfire.org>

--===============4251998757462880218==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Stephan,

unfortunately, I do not understand this mail. Isn't that the Tor
permission patch of mine sent in a while ago? What is the relationship
to wio?

Besides: Your other patches miss the "Signed-off-by"-Tag. Just
thought you might want to know...

Thanks, and best regards,
Peter Müller


> From: "peter.mueller(a)ipfire.org" <peter.mueller(a)ipfire.org>
> 
> Fixes #12220
> 
> Reported-by: Michael Tremer <michael.tremer(a)ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
>  lfs/tor                 | 2 +-
>  src/paks/tor/install.sh | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lfs/tor b/lfs/tor
> index ea07f6ce2..178f84be9 100644
> --- a/lfs/tor
> +++ b/lfs/tor
> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = tor
> -PAK_VER    = 43
> +PAK_VER    = 44
>  
>  DEPS       = "libseccomp"
>  
> diff --git a/src/paks/tor/install.sh b/src/paks/tor/install.sh
> index 4d0353155..369b65f71 100644
> --- a/src/paks/tor/install.sh
> +++ b/src/paks/tor/install.sh
> @@ -36,10 +36,10 @@ extract_files
>  restore_backup ${NAME}
>  
>  # Adjust some folder permission for new UID/GID
> -chown -R tor:tor /var/lib/tor /var/ipfire/tor
> +chown -R tor:tor /var/lib/tor
> +chown -R tor:nobody /var/ipfire/tor
>  
> -# Tor settings file needs to be writeable by nobody group for WebUI
> -chown tor:nobody /var/ipfire/tor/settings
> -chmod 664 /var/ipfire/tor/settings
> +# Tor settings files needs to be writeable by nobody group for WebUI
> +chmod 664 /var/ipfire/tor/{settings,torrc}
>  
>  start_service --background ${NAME}
> 

--===============4251998757462880218==--