From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages
Date: Mon, 01 Jan 2024 18:07:43 +0100 [thread overview]
Message-ID: <0c3017d3-db3e-4c45-aaee-1e9203e939f7@ipfire.org> (raw)
In-Reply-To: <20240101143546.10272-2-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 01.01.2024 um 15:35 schrieb Adolf Belka:
> - A new IPFire user on the forum saw the orange and red coloured blocks in the legend
> section and believed that they were messages about problems that had been created with
> the fixed leases.
> - This change puts a small block with seperate explanatory text for both the orange and
> red coloured blocks.
> - This change will also be applied to the wiki in a much clearer way
>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/dhcp.cgi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
> index ec5d62657..c079fe1ae 100644
> --- a/html/cgi-bin/dhcp.cgi
> +++ b/html/cgi-bin/dhcp.cgi
> @@ -1164,10 +1164,10 @@ print <<END
> </tr>
> <tr>
> <td> </td>
> - <td> </td>
> - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td>
> - <td>  </td>
> - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
> + <td class='base orange'> </td>
> + <td class='base'> $Lang::tr{'ip address outside subnets'} </td>
> + <td class='base red'> </td>
> + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
> <td> </td>
> <td> </td>
> $dup
next prev parent reply other threads:[~2024-01-01 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 14:35 [PATCH 1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text Adolf Belka
2024-01-01 14:35 ` [PATCH 2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages Adolf Belka
2024-01-01 16:53 ` jon
2024-01-01 17:07 ` Bernhard Bitsch [this message]
2024-01-01 16:41 ` [PATCH 1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text Bernhard Bitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3017d3-db3e-4c45-aaee-1e9203e939f7@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox