From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/9] suricata: Set most significant bit as repeat marker
Date: Mon, 18 Oct 2021 22:42:20 +0200 [thread overview]
Message-ID: <0c968f0f-ea2f-800d-e3c3-c3942ada70f1@ipfire.org> (raw)
In-Reply-To: <20211018101022.15448-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> I have no idea why some odd value was chosen here, but one bit should be
> enough.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/suricata/suricata.yaml | 4 ++--
> src/initscripts/system/suricata | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/config/suricata/suricata.yaml b/config/suricata/suricata.yaml
> index 4e9e39967..1ce013dc7 100644
> --- a/config/suricata/suricata.yaml
> +++ b/config/suricata/suricata.yaml
> @@ -346,8 +346,8 @@ logging:
>
> nfq:
> mode: repeat
> - repeat-mark: 1879048192
> - repeat-mask: 1879048192
> + repeat-mark: 2147483648
> + repeat-mask: 2147483648
> # bypass-mark: 1
> # bypass-mask: 1
> # route-queue: 2
> diff --git a/src/initscripts/system/suricata b/src/initscripts/system/suricata
> index 33633ddf9..e327225d7 100644
> --- a/src/initscripts/system/suricata
> +++ b/src/initscripts/system/suricata
> @@ -35,8 +35,8 @@ network_zones=( red green blue orange ovpn )
> enabled_ips_zones=()
>
> # Mark and Mask options.
> -MARK="0x70000000"
> -MASK="0x70000000"
> +MARK="0x80000000"
> +MASK="0x80000000"
>
> # PID file of suricata.
> PID_FILE="/var/run/suricata.pid"
>
next prev parent reply other threads:[~2021-10-18 20:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 10:10 Michael Tremer
2021-10-18 10:10 ` [PATCH 2/9] suricata: Rename MARK/MASK to REPEAT_MARK/REPEAT_MASK Michael Tremer
2021-10-18 20:42 ` Peter Müller
2021-10-19 4:02 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 3/9] suricata: Define bypass mark Michael Tremer
2021-10-18 20:43 ` Peter Müller
2021-10-19 4:03 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 4/9] suricata: Enable bypassing unhandled streams Michael Tremer
2021-10-19 4:03 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 5/9] suricata: Always append rules instead of inserting them Michael Tremer
2021-10-19 4:03 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 6/9] suricata: Add rule to skip IPS if a packet has the bypass bit set Michael Tremer
2021-10-19 4:04 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 7/9] suricata: Store bypass flag in connmark and restore Michael Tremer
2021-10-19 4:04 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 8/9] suricata: Introduce IPSBYPASS chain Michael Tremer
2021-10-19 4:04 ` Stefan Schantl
2021-10-18 10:10 ` [PATCH 9/9] firewall: Keep REPEAT bit when saving rest to CONNMARK Michael Tremer
2021-10-19 4:05 ` Stefan Schantl
2021-10-18 20:42 ` Peter Müller [this message]
2021-10-19 4:02 ` [PATCH 1/9] suricata: Set most significant bit as repeat marker Stefan Schantl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c968f0f-ea2f-800d-e3c3-c3942ada70f1@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox