* Please rework next commit 23b810171806939a23c3d5df7758b90dda357116 !!! @ 2014-07-10 13:49 Arne Fitzenreiter 2014-07-10 15:15 ` Michael Tremer 0 siblings, 1 reply; 2+ messages in thread From: Arne Fitzenreiter @ 2014-07-10 13:49 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 327 bytes --] Hi Micha, hi Dirk, I think it is not a good idea to complete overwrite the logrotate.conf at update because there are some user configurable settings inside. It is better to use sed for adding the include line... http://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=23b810171806939a23c3d5df7758b90dda357116 Arne ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Please rework next commit 23b810171806939a23c3d5df7758b90dda357116 !!! 2014-07-10 13:49 Please rework next commit 23b810171806939a23c3d5df7758b90dda357116 !!! Arne Fitzenreiter @ 2014-07-10 15:15 ` Michael Tremer 0 siblings, 0 replies; 2+ messages in thread From: Michael Tremer @ 2014-07-10 15:15 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1297 bytes --] Hi Arne, I don't quite agree with this. I think the commit is find and modifies a system configuration file that is not modified in any manner by the web interface or any other script. Users that put their own modifications into those files will sooner or later crash their systems any way. That is why we usually include files where they can put their own modifications. I find it always incredibly unnecessary to go through this procedure for crontab just because some users cannot create their own one. The process is faulty and takes a lot of time to do. I don't insist on keeping this commit in the repository, so if you insist on inserting it on the fly I will do that instead. -Michael On Thu, 2014-07-10 at 15:49 +0200, Arne Fitzenreiter wrote: > Hi Micha, hi Dirk, > > I think it is not a good idea to complete overwrite the logrotate.conf > at update because there are some > user configurable settings inside. It is better to use sed for adding > the include line... > > http://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=23b810171806939a23c3d5df7758b90dda357116 > > Arne > > _______________________________________________ > Development mailing list > Development(a)lists.ipfire.org > http://lists.ipfire.org/mailman/listinfo/development ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-10 15:15 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-07-10 13:49 Please rework next commit 23b810171806939a23c3d5df7758b90dda357116 !!! Arne Fitzenreiter 2014-07-10 15:15 ` Michael Tremer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox