From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] optionsfw.cgi: Add default settings for newly added options.
Date: Sat, 05 Mar 2022 19:32:27 +0000
Message-ID: <0db5f211-f61e-642c-99d7-b82550f0eb18@ipfire.org>
In-Reply-To: <20220305181339.4389-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2632255554719022039=="
List-Id: <development.lists.ipfire.org>

--===============2632255554719022039==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Looks good to me.

Also, fixes: #12791

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> If no settings for those features can be obtained from the settings
> file, set them to the following defaults.
> 
> * DROPSPOOFEDMARTIAN -> on (yes)
> * DROPHOSTILE -> off (no - because only fresh installed systems should
>                      do this)
> * LOGDROPCTINVALID -> on (yes)
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  html/cgi-bin/optionsfw.cgi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/html/cgi-bin/optionsfw.cgi b/html/cgi-bin/optionsfw.cgi
> index 5611b71b7..fbff67b2f 100644
> --- a/html/cgi-bin/optionsfw.cgi
> +++ b/html/cgi-bin/optionsfw.cgi
> @@ -88,6 +88,15 @@ if (!$settings{'MASQUERADE_ORANGE'}) {
>  if (!$settings{'MASQUERADE_BLUE'}) {
>  	$settings{'MASQUERADE_BLUE'} = 'on';
>  }
> +if (!$settings{'DROPSPOOFEDMARTIAN'}) {
> +	$settings{'DROPSPOOFEDMARTIAN'} = 'on';
> +}
> +if (!$settings{'DROPHOSTILE'}) {
> +	$settings{'DROPHOSTILE'} = 'off';
> +}
> +if (!$settings{'LOGDROPCTINVALID'}) {
> +	$settings{'LOGDROPCTINVALID'} = 'on';
> +}
>  
>  $checked{'DROPNEWNOTSYN'}{'off'} = '';
>  $checked{'DROPNEWNOTSYN'}{'on'} = '';

--===============2632255554719022039==--