public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Two commits have been merged that need to be redone
Date: Wed, 18 Dec 2024 20:11:34 +0100	[thread overview]
Message-ID: <0f832fe9-5493-4fc6-a46f-a97e7e4e5717@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi Arne,

Commits

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=7b29acfbb597b89837dcbe1b91ef6ef4352f28a6

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=f32ca6cd79124c4fcfc722a2238c1accbfb1a9ff

were flagged by Michael as needing reworking by me as the approach I had used had some bad code in it.

So I think these should be reverted.

See third post in this thread

https://lists.ipfire.org/hyperkitty/list/development(a)lists.ipfire.org/thread/ROQIIEWTI3BHTN6CF2CLSE243BQ3GXRS/

It is on my list to work on a v2 version but it is not urgent that it gets into CU191.

Regards,

Adolf.


                 reply	other threads:[~2024-12-18 19:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f832fe9-5493-4fc6-a46f-a97e7e4e5717@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox