From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v4 8/8] wlanap.cgi: Access db.txt in place of using
 regdbdump on regulatory.bin
Date: Thu, 05 Aug 2021 23:18:21 +0200
Message-ID: <0fd7755b-e235-9adb-04db-7066fc9af879@ipfire.org>
In-Reply-To: <20210805210152.3467498-8-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1893096064251073468=="
List-Id: <development.lists.ipfire.org>

--===============1893096064251073468==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 05.08.2021 um 23:01 schrieb Adolf Belka:
> - wlanap.cgi was using regdbdump from crda to create a text based list of t=
he
>     wireless settings by country database.
> - With the removal of crda as part of the removal of python2 this option co=
uld not be
>     used.
> - wireless-regdb also has a text based database list in the source tarball =
and this
>     patch makes wlanap.cgi read this list into the @countrylist_cmd variable
> - This needs to be tested by someone that has an IPFire system with wifi th=
at can access
>     and evaluate wlanap.cgi to confirm that this change functions as expect=
ed.
> - This version changes the name of the stored text file from db.txt to regu=
latorydb.txt
> - The command to read the data from regulatorydb.txt into @countrylist_cmd =
has been
>     corrected
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   html/cgi-bin/wlanap.cgi | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/wlanap.cgi b/html/cgi-bin/wlanap.cgi
> index eba5fe774..5eb34d651 100644
> --- a/html/cgi-bin/wlanap.cgi
> +++ b/html/cgi-bin/wlanap.cgi
> @@ -312,8 +312,11 @@ if ( $channel =3D~ /\d+/ ){push(@temp,$channel + 0);}
>   push(@channellist, @temp);
>   }
>  =20
> -my @countrylist_cmd =3D `regdbdump /usr/lib/crda/regulatory.bin 2>/dev/nul=
l`;
>   # get available country codes
> +open(FILE, =E2=80=9C</lib/firmware/regulatorydb.txt=E2=80=9D);
> +my @countrylist_cmd =3D <FILE>;
> +close(FILE);
> +
>  =20
>   my @temp =3D "00";
>   foreach (@countrylist_cmd){
>=20

--===============1893096064251073468==--