From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4ZNmCx0Fbmz332M for ; Thu, 27 Mar 2025 14:25:49 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4ZNmCs3NJ5z30C6 for ; Thu, 27 Mar 2025 14:25:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4ZNmCr5KdjzgC; Thu, 27 Mar 2025 14:25:44 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1743085544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gtDnL51IZXyQn6+gPXwc+KmO8BQI25d1VsgSEn3pi9I=; b=2O6XbWILI8MydWurkWrSxkV0lqnnfyXOuQ+l6oLo62XL92CpQbGkIVp7Jt7WXVTOABqzFj nNTZJmw6JwXdNYDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1743085544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gtDnL51IZXyQn6+gPXwc+KmO8BQI25d1VsgSEn3pi9I=; b=J4QAnLSOWsE36xdLZ2l9RTMpWWRSxsDKVb1VDsc/L4QgeIRTvf5Zz9v3iKes4zyZXBDmZi YnHbS3ti23ExtMZTLSm2xoETmoP/8q+SoLEjpCZFFYRbj7kZ1A3us0ZkmEoUjO5yp5iuer 7Lx7hF4mdLMK9kwNQBIUiAxnY2efXDPOnQQ+zq5PGpwrusy3oceZVO9Ok5HMI7i1sC2xSr lpuypZECAZob1oZExRo21a9ym3Ny4Y4QmMOhi7rJ47p/ow/vz3KL6aNYmhW/2cRboiUJtv Kd9+g+PMFqVto5lO00V0Vzi5d8t55G0zvKQ+OZEGGhmpcCjPGuvL50o16xKY4g== Message-ID: <10193e11-b3c2-4189-9fbc-cac6f49fc881@ipfire.org> Date: Thu, 27 Mar 2025 15:25:40 +0100 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8 To: ummeegge References: <5f9a0c4912a941d9836af07f68e10e22b30a437e.camel@ipfire.org> <3850ac90-6781-4e45-ada7-4bfa2e200861@ipfire.org> <798eed47-acc7-47a1-bfc2-68fcd1fa098d@ipfire.org> <4e54134966d65b463a0968936b98419a5b833dd2.camel@ipfire.org> Content-Language: en-GB Cc: "IPFire: Development-List" From: Adolf Belka In-Reply-To: <4e54134966d65b463a0968936b98419a5b833dd2.camel@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Erik, On 26/03/2025 07:17, ummeegge wrote: > Good morning Adolf, > thanks for fixing/extending it. Have searched also for a `use JSON;` > declaration in IPFire since i was not sure if the JSON modul has been > used somewhere as a dependency. In this case the declaration would have > caused errors but i have not found anything in IPFire´s code base. It was being used by samba so the use command would be in their code. Regards, Adolf. > > Best, > > Erik > > Am Freitag, dem 21.03.2025 um 10:11 +0100 schrieb Adolf Belka: >> Hi Erik, >> >> On 17/03/2025 07:33, ummeegge wrote: >>> Hello Adolf, >>> great thanks. Have seen it also only since i do needed them for a >>> project. >> >> It is in CU193 Testing. >> >> Regards, >> Adolf. >> >>> >>> Best, >>> >>> Erik >>> >>> Am Samstag, dem 15.03.2025 um 17:41 +0100 schrieb Adolf Belka: >>>> Hi Erik, >>>> >>>> On 13/03/2025 08:25, ummeegge wrote: >>>>> Hi Adolf, >>>>> have seen that you removed the perl-JSON Addon since it is now >>>>> available in Perl´s core modules >>>>> https://patchwork.ipfire.org/project/ipfire/patch/20240914152831.7727-8-adolf.belka@ipfire.org/ >>>>> . Perl´s ROOTFILE have the pp.pm >>>>> commented >>>>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/ >>>>> common/perl;h=d4ceb7083ea32ce19c0befef168575696c244dd2;hb=refs/ >>>>> head >>>>> s/next#l315 >>>>> so JSON has now been fully removed from IPFire. >>>>> >>>>> My question is, was this intended ? >>>> >>>> No that was not intended. I obviously missed that. >>>> >>>> I will submit a patch to uncomment the lines in the perl >>>> rootfile. >>>> >>>> Regards, >>>> Adolf. >>>> >>>>> >>>>> Best, >>>>> >>>>> Erik >>>> >>> >> >> > >