Re: [PATCH] extrahd.cgi: Fix for Bug #12863

[Bernhard Bitsch <bbitsch@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Less painful syntax could be:
+	unless ( 
&General::system("/usr/loca/bin/extrahdctrl","umount",$extrahdsettings{'PATH'}")) 
{
Am 02.06.2023 um 21:01 schrieb Jon Murphy:
> -Fixes remove entries in 'extrahd' via the webinterface for extrahd.cgi file.
> 
> Suggested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
>   html/cgi-bin/extrahd.cgi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index 36c0efc2e..9dd3a0eee 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -103,7 +103,7 @@ END
>   }
>   elsif ($extrahdsettings{'ACTION'} eq $Lang::tr{'delete'})
>   {
> -	if ( &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdsettings{'PATH'}")) {
> +	if ( ! &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdsettings{'PATH'}")) {
>   		open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
>   		@tmp = <FILE>;
>   		close FILE;