From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] extrahd.cgi: Fix for Bug #12863
Date: Wed, 07 Jun 2023 21:30:26 +0200
Message-ID: <1061da62-611d-7ce3-74be-03831ae8af45@ipfire.org>
In-Reply-To: <20230602190116.1790314-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2580530041302234061=="
List-Id: <development.lists.ipfire.org>

--===============2580530041302234061==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Less painful syntax could be:
+	unless (=20
&General::system("/usr/loca/bin/extrahdctrl","umount",$extrahdsettings{'PATH'=
}"))=20
{
Am 02.06.2023 um 21:01 schrieb Jon Murphy:
> -Fixes remove entries in 'extrahd' via the webinterface for extrahd.cgi fil=
e.
>=20
> Suggested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
>   html/cgi-bin/extrahd.cgi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index 36c0efc2e..9dd3a0eee 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -103,7 +103,7 @@ END
>   }
>   elsif ($extrahdsettings{'ACTION'} eq $Lang::tr{'delete'})
>   {
> -	if ( &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdse=
ttings{'PATH'}")) {
> +	if ( ! &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahd=
settings{'PATH'}")) {
>   		open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
>   		@tmp =3D <FILE>;
>   		close FILE;

--===============2580530041302234061==--