From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: rsync 3.2.0
Date: Thu, 25 Jun 2020 16:35:26 +0100
Message-ID: <10D1F12A-DEEC-4C23-93FD-A33CF9A919D2@ipfire.org>
In-Reply-To: <56d13dd2-c24b-bfc4-ec5e-e32fdda6b4d4@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4866744045803348587=="
List-Id: <development.lists.ipfire.org>

--===============4866744045803348587==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 25 Jun 2020, at 16:28, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> On 25.06.2020 10:54, Michael Tremer wrote:
>> Hi,
>>=20
>>> On 20 Jun 2020, at 16:09, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> Hi,
>>>=20
>>> rsync 3.2.0 is out and I just had time...
>=20
> In fact, I'm at 3.2.1. See below.
>=20
>>> In order to use the new xxhash checksum support and zstd compression,
>>> the corresponding kernel modules would need to be activated. Do we want
>>> or need these?
>>=20
>> You won=E2=80=99t need kernel modules for this. You simply need the releva=
nt libraries.
>=20
> Ok. I wasn't sure. I found some 'zstd's in the rootfiles and thought we
> would need these.
>=20
>> I have packaged those for IPFire 3 and they are easy to build and have no =
further dependencies. So I would recommend to at least add zstd.
>=20
> I am at it.
>=20
>> https://git.ipfire.org/?p=3Dipfire-3.x.git;a=3Dblob;f=3Drsync/rsync.nm;h=
=3D528dcfc0a377bc770a45a8f88af00079eb26dc93;hb=3Db40cdb8c182d8b4aa05c6e23cc67=
118c4aa4853c
>> https://git.ipfire.org/?p=3Dipfire-3.x.git;a=3Dblob;f=3Dzstd/zstd.nm;h=3De=
5afd342b9ad2ae0c0f394116ef2dfddea670413;hb=3D8bcac5c8cda49b91fe68bef64c3ad975=
b80a43ca
>=20
> Thats exactly what I needed - thanks - I'll take a look.
>=20
>>=20
>>>=20
>>> For now, I disabled both with these configure options:
>>>=20
>>> ...
>>> 	--disable-xxhash \
>>> 	--disable-zstd
>>> ...
>>>=20
>>> Do we want (would someone use) the new 'rsync-ssl'-script? On a firewall!?
>>=20
>> I tried to find out what this is useful for. It doesn=E2=80=99t harm us an=
d calls openssl. So I would just leave it in there.
>=20
> Ok.
>=20
> Please note:
>=20
> 'rsync 3.2.1' just came out. I'm testing - and working on 'zstd 1.4.5'
> (weekend, I think).
>=20
> If you want, we could skip 3.2.0 =3D> no need to merge this patch.
>=20
> I could mark 3.2.0 as 'superseded' in patchwork and we'll go straight to
> 3.2.1.

Yes, absolutely do that. There is no point in merging 3.2.0 if 3.2.1 is alrea=
dy under works.

Best,
-Michael

>=20
> Opinions?
>=20
> Best,
> Matthias


--===============4866744045803348587==--