Re: [PATCH 1/3] OpenVPN: Introduce advanced encryption section

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Hello,

> On 8 Dec 2020, at 18:28, ummeegge <ummeegge(a)ipfire.org> wrote:
> 
> Hi all,
> there are meanwhile some enhancements and one fix.
> - The are translations (human) in four languages available --> 
> https://community.ipfire.org/t/please-for-help-to-translate-some-strings/3942
> Russian, Polish and Turkish are also there but machine translated.

I appreciate involving the community, but translations should be done at the end, when we are no longer going to change anything. I am not sure if we are at that point, yet.

> - There is a check for weak algorithms, also for the HMAC SHA1 with the
> warning to change this settings as soon as possible since they are
> deprecated.
> - A fix is included since tls-crypt wasn´t parsed into client.ovpn in
> 'insecure' mode.
> 
> I would send a version 2 with all changes but now may split into 4-5
> patches ?

I still think that I did not get answers to my questions in the other email thread.

I do not think that it is worth it to review any patches just yet, when we still do not know what we want the whole thing to look like so that people can use it.

Do you have all your changes in a Git repository somewhere?

-Michael

> 
> Best,
> 
> Erik
>