From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Question about use of xxxMACHINExxx Date: Mon, 08 Jul 2024 16:42:50 +0100 Message-ID: <11C22A8F-8078-4311-8824-3E98895DE980@ipfire.org> In-Reply-To: <773ae7c0-d130-401f-b15a-d89f3b9b4cc4@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4814165579669050759==" List-Id: --===============4814165579669050759== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > On 8 Jul 2024, at 15:51, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 08/07/2024 15:59, Michael Tremer wrote: >> Hello Adolf, >> Sorry for not being faster at this=E2=80=A6 Still catching up :) >=20 > No problems. >> This is basically a variable which used to be called MACHINE but was repla= ced with xxxMACHINExxx because the string =E2=80=9CMACHINE=E2=80=9D was actua= lly used in some filename. Not sure I am happy with that name=E2=80=A6 >> When the root files are generated, we don=E2=80=99t replace anything, but = if we read a rootfile from config/rootfiles, we will replace this variable wi= th the architecture we are building for. Sometimes this method allows us to h= ave just a generic root file for all architectures, sometimes this does not w= ork because there are extra files or something like that. >> So when you have such a case, you need to manually replace the architectur= e with the placeholder and check if all other architectures generate the same= file. >=20 > I am not sure that I fully understand. In the repo there are rootfiles in c= onfig/rootfiles/common/aarch64/ such as boost, dtc, gcc which have aarch64 in= the rootfile. None of these have been replaced by xxxMACGHINExxx. Yes, if the rootfile is in one of the directories for a special directory it = will be used instead of the one that is in common/ (if there is one at all). = These files are there because they have different files than other architectu= res (GCC for example does not build certain libraries for ARM and RISC-V). > In config/rootfiles/packages/aarch64/samba all the aarch64 references are s= till present. In /config/rootfiles/packages/x86_64/samba, all the references = to x86_64 are replaced by xxxMACHINExxx as that is what I have been doing. Since that file is only considered for aarch64, there is no need to change th= e placeholder. > If the samba rootfile in aarch64 should have all its aarch64 references rep= laced by xxxMACHINExxx then that has not been happening and is also not the c= ase for rootfiles in config/rootfiles/common/x86_64/ such as gcc, grub, rust = etc >=20 > If the rootfiles that are in the x86_64 and aarch64 directories should have= the architecture name replaced by xxxMACHINExxx then I need to do a v2 versi= on of the samba update I just sent out earlier today as the x86_64 and aarch6= 4 rootfiles do not have xxxMACHINExxx replacing the architecture reference. Erm, I didn=E2=80=99t check :) We shall see if the build completes :) -Michael >=20 > Regards, > Adolf. >=20 >> -Michael >>> On 5 Jul 2024, at 11:39, Adolf Belka wrote: >>>=20 >>> Hi All, >>>=20 >>> When a rootfile is in one of the specific architecture directories, e.g. = aarch64 do all the aarch64 references just get left as that or should they ge= t changed to xxxMACHINExxx. >>>=20 >>> Looking at some files in the directories it looks like they get left alon= e but when I have done the samba rootfile update for x86_64 I have , most tim= es, changed any x86_64 reference to xxxMACHINExxx. >>>=20 >>> What is the correct approach so I don't go messing things up. >>>=20 >>> Regards, >>>=20 >>> Adolf >>>=20 --===============4814165579669050759==--