From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] updatexlrator.cgi: Fix Bug 10477 - Update Accelerator disk usage statistics are very cramped in 2.15 beta1
Date: Thu, 12 Aug 2021 10:13:51 +0100 [thread overview]
Message-ID: <11CB28A3-DE63-45A0-AC59-703F4AB0FAC4@ipfire.org> (raw)
In-Reply-To: <70390018-9af8-b8ab-64b1-9497d8d3b4b7@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 5278 bytes --]
Hello,
Oh yeah, massive improvement :)
Thank you!
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 11 Aug 2021, at 12:22, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> Hi Michael,
>
> On 11/08/2021 12:49, Michael Tremer wrote:
>> Could I have a screenshot of this, please?
> I attached a screenshot into the bug but also find the original version and the fixed version screenshots attached to this email.
>
> Regards,
> Adolf.
>> -Michael
>>> On 9 Aug 2021, at 22:32, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> - This bug has been open for a long time and is still valid. The Cache statistics on
>>> the Update accelerator configuration page are jammed closely together making it
>>> not so easy to see what the numbers are.
>>> - Implemented similar approach as used on the Memory table section of the Memory
>>> information page.
>>> - Installed on vm testbed machine and confirmed to provide the desired layout.
>>>
>>> Tested-by Adolf Belka <adolf.belka(a)ipfire.org>
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> html/cgi-bin/updatexlrator.cgi | 58 +++++++++++++++++++---------------
>>> 1 file changed, 32 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi
>>> index 9cfe08f4e..deead7d79 100644
>>> --- a/html/cgi-bin/updatexlrator.cgi
>>> +++ b/html/cgi-bin/updatexlrator.cgi
>>> @@ -722,15 +722,18 @@ unless ($numfiles) { print "<i>$Lang::tr{'updxlrtr empty repository'}</i>\n<hr s
>>>
>>> print <<END
>>> <table>
>>> -<tr><td class='boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td></tr>
>>> +<tr>
>>> +<td class='boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td>
>>> +</tr>
>>> </table>
>>> -<table cellpadding='3'>
>>> +<table width='75%' cellspacing='5'>
>>> <tr>
>>> -<td align='left' class='base'><i>$Lang::tr{'updxlrtr cache dir'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'size'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'used'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'free'}</i></td>
>>> -<td align='left' class='base' colspan='2'><i>$Lang::tr{'percentage'}</i></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'updxlrtr cache dir'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'size'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'used'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'free'}</b></td>
>>> +<td></td>
>>> +<td align='left' class='boldbase' colspan='2'><b>$Lang::tr{'percentage'}</b></td>
>>> </tr>
>>> END
>>> ;
>>> @@ -745,17 +748,17 @@ my ($device,$size,$used,$free,$percent,$mount) = split(' ',$dfstr);
>>>
>>> print <<END
>>> <tr>
>>> -<td>[$repository]</td>
>>> -<td align='right'>$size</td>
>>> -<td align='right'>$used</td>
>>> -<td align='right'>$free</td>
>>> -<td>
>>> +<td align='center'>[$repository]</td>
>>> +<td align='center'>$size</td>
>>> +<td align='center'>$used</td>
>>> +<td align='center'>$free</td>
>>> +<td align='right' colspan='2'>
>>> END
>>> ;
>>> &percentbar($percent);
>>> print <<END
>>> </td>
>>> -<td align='right'>$percent</td>
>>> +<td align='center'>$percent</td>
>>> </tr>
>>> </table>
>>> END
>>> @@ -1015,15 +1018,18 @@ unless (@repositoryfiles) { print "<i>$Lang::tr{'updxlrtr empty repository'}</i>
>>>
>>> print <<END
>>> <table>
>>> -<tr><td class='boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td></tr>
>>> +<tr>
>>> +<td class='boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td>
>>> +</tr>
>>> </table>
>>> -<table cellpadding='3'>
>>> +<table width='75%' cellspacing='5'>
>>> <tr>
>>> -<td align='left' class='base'><i>$Lang::tr{'updxlrtr cache dir'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'size'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'used'}</i></td>
>>> -<td align='center' class='base'><i>$Lang::tr{'free'}</i></td>
>>> -<td align='left' class='base' colspan='2'><i>$Lang::tr{'percentage'}</i></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'updxlrtr cache dir'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'size'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'used'}</b></td>
>>> +<td align='center' class='boldbase'><b>$Lang::tr{'free'}</b></td>
>>> +<td></td>
>>> +<td align='left' class='boldbase' colspan='2'><b>$Lang::tr{'percentage'}</b></td>
>>> </tr>
>>> END
>>> ;
>>> @@ -1038,17 +1044,17 @@ my ($device,$size,$used,$free,$percent,$mount) = split(' ',$dfstr);
>>>
>>> print <<END
>>> <tr>
>>> -<td>[$repository]</td>
>>> -<td align='right'>$size</td>
>>> -<td align='right'>$used</td>
>>> -<td align='right'>$free</td>
>>> -<td>
>>> +<td align='center'>[$repository]</td>
>>> +<td align='center'>$size</td>
>>> +<td align='center'>$used</td>
>>> +<td align='center'>$free</td>
>>> +<td align='right' colspan='2'>
>>> END
>>> ;
>>> &percentbar($percent);
>>> print <<END
>>> </td>
>>> -<td align='right'>$percent</td>
>>> +<td align='center'>$percent</td>
>>> </tr>
>>> </table>
>>> END
>>> --
>>> 2.32.0
>>>
> <Unpatched cache statistics.png><patched cache statistics.png>
next parent reply other threads:[~2021-08-12 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <70390018-9af8-b8ab-64b1-9497d8d3b4b7@ipfire.org>
2021-08-12 9:13 ` Michael Tremer [this message]
2021-08-09 20:32 Adolf Belka
2021-08-09 21:09 ` Bernhard Bitsch
2021-08-11 10:49 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11CB28A3-DE63-45A0-AC59-703F4AB0FAC4@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox