From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] updatexlrator.cgi: Fix Bug 10477 - Update Accelerator disk usage statistics are very cramped in 2.15 beta1 Date: Thu, 12 Aug 2021 10:13:51 +0100 Message-ID: <11CB28A3-DE63-45A0-AC59-703F4AB0FAC4@ipfire.org> In-Reply-To: <70390018-9af8-b8ab-64b1-9497d8d3b4b7@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4726480788942951742==" List-Id: --===============4726480788942951742== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Oh yeah, massive improvement :) Thank you! Reviewed-by: Michael Tremer > On 11 Aug 2021, at 12:22, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 11/08/2021 12:49, Michael Tremer wrote: >> Could I have a screenshot of this, please? > I attached a screenshot into the bug but also find the original version and= the fixed version screenshots attached to this email. >=20 > Regards, > Adolf. >> -Michael >>> On 9 Aug 2021, at 22:32, Adolf Belka wrote: >>>=20 >>> - This bug has been open for a long time and is still valid. The Cache st= atistics on >>> the Update accelerator configuration page are jammed closely together m= aking it >>> not so easy to see what the numbers are. >>> - Implemented similar approach as used on the Memory table section of the= Memory >>> information page. >>> - Installed on vm testbed machine and confirmed to provide the desired la= yout. >>>=20 >>> Tested-by Adolf Belka >>> Signed-off-by: Adolf Belka >>> --- >>> html/cgi-bin/updatexlrator.cgi | 58 +++++++++++++++++++--------------- >>> 1 file changed, 32 insertions(+), 26 deletions(-) >>>=20 >>> diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.= cgi >>> index 9cfe08f4e..deead7d79 100644 >>> --- a/html/cgi-bin/updatexlrator.cgi >>> +++ b/html/cgi-bin/updatexlrator.cgi >>> @@ -722,15 +722,18 @@ unless ($numfiles) { print "$Lang::tr{'updxlrtr = empty repository'}\n
>>=20 >>> print <>> >>> -<= /tr> >>> + >>> + >>> + >>>
$Lang::tr{'updxlrtr disk usage'}
$Lang::tr{'updxlrtr disk usage'}
>>> - >>> +
>>> >>> - >>> - >>> - >>> - >>> - >>> + >>> + >>> + >>> + >>> + >>> + >>> >>> END >>> ; >>> @@ -745,17 +748,17 @@ my ($device,$size,$used,$free,$percent,$mount) =3D = split(' ',$dfstr); >>>=20 >>> print <>> >>> - >>> - >>> - >>> - >>> - >>> + >>> + >>> + >>> + >>> - >>> + >>> >>>
$Lang::tr{'updxlrtr cache dir'}= $Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percentage= '}$Lang::tr{'updxlrtr cache dir= '}$Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percen= tage'}
[$repository]$size$used$free >>> +[$repository]$size$used$free >>> END >>> ; >>> &percentbar($percent); >>> print <>> $percent$percent
>>> END >>> @@ -1015,15 +1018,18 @@ unless (@repositoryfiles) { print "$Lang::tr{'= updxlrtr empty repository'} >>>=20 >>> print <>> >>> -<= /tr> >>> + >>> + >>> + >>>
$Lang::tr{'updxlrtr disk usage'}
$Lang::tr{'updxlrtr disk usage'}
>>> - >>> +
>>> >>> - >>> - >>> - >>> - >>> - >>> + >>> + >>> + >>> + >>> + >>> + >>> >>> END >>> ; >>> @@ -1038,17 +1044,17 @@ my ($device,$size,$used,$free,$percent,$mount) = =3D split(' ',$dfstr); >>>=20 >>> print <>> >>> - >>> - >>> - >>> - >>> - >>> + >>> + >>> + >>> + >>> - >>> + >>> >>>
$Lang::tr{'updxlrtr cache dir'}= $Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percentage= '}$Lang::tr{'updxlrtr cache dir= '}$Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percen= tage'}
[$repository]$size$used$free >>> +[$repository]$size$used$free >>> END >>> ; >>> &percentbar($percent); >>> print <>> $percent$percent
>>> END >>> --=20 >>> 2.32.0 >>>=20 > --===============4726480788942951742==--