Re: [PATCH] dracut: lower ram usage at commpression

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

Thank you for this patch. Please go ahead and merge it straight into next.

However, I would like to put on the record that I generally disagree with optimising things for the lowest common denominator. It will not allow us to take advantage of modern features whether that is in hardware or software, so let’s aim to avoid hacks like this whenever possible in the future.

Best,
-Michael

> On 16 May 2023, at 10:06, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
> 
> this lower the compression ratio sligtly (the ramdlisk is 100kb
> larger) and use only a single thread now. (it's still faster than
> before on a dual core.)
> 
> Note to Peter: if there are no other changes on dracut ship only
> /usr/lib/dracut/dracut.conf.d/ipfire.conf
> at core update.
> 
> fixes: #13091
> 
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> config/dracut/ipfire.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/dracut/ipfire.conf b/config/dracut/ipfire.conf
> index bab5c8a2e..5a4f0aa7c 100644
> --- a/config/dracut/ipfire.conf
> +++ b/config/dracut/ipfire.conf
> @@ -2,4 +2,4 @@
> early_microcode="yes"
> 
> # Compress using Zstandard
> -compress="zstd"
> +compress="zstd -10 -q -T1"
> -- 
> 2.34.1
>