From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] dracut: lower ram usage at commpression
Date: Wed, 17 May 2023 08:49:27 +0100
Message-ID: <11D5DC2E-E922-4719-A031-870A51AA3466@ipfire.org>
In-Reply-To: <20230516090606.1170-1-arne_f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4957180220089333023=="
List-Id: <development.lists.ipfire.org>

--===============4957180220089333023==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thank you for this patch. Please go ahead and merge it straight into next.

However, I would like to put on the record that I generally disagree with opt=
imising things for the lowest common denominator. It will not allow us to tak=
e advantage of modern features whether that is in hardware or software, so le=
t=E2=80=99s aim to avoid hacks like this whenever possible in the future.

Best,
-Michael

> On 16 May 2023, at 10:06, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
>=20
> this lower the compression ratio sligtly (the ramdlisk is 100kb
> larger) and use only a single thread now. (it's still faster than
> before on a dual core.)
>=20
> Note to Peter: if there are no other changes on dracut ship only
> /usr/lib/dracut/dracut.conf.d/ipfire.conf
> at core update.
>=20
> fixes: #13091
>=20
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> config/dracut/ipfire.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/dracut/ipfire.conf b/config/dracut/ipfire.conf
> index bab5c8a2e..5a4f0aa7c 100644
> --- a/config/dracut/ipfire.conf
> +++ b/config/dracut/ipfire.conf
> @@ -2,4 +2,4 @@
> early_microcode=3D"yes"
>=20
> # Compress using Zstandard
> -compress=3D"zstd"
> +compress=3D"zstd -10 -q -T1"
> --=20
> 2.34.1
>=20


--===============4957180220089333023==--