From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/7] bash: update to 5.0
Date: Tue, 08 Oct 2019 14:46:02 +0100
Message-ID: <12F3A1E1-4217-400A-950D-3EFA90BC9FCD@ipfire.org>
In-Reply-To: <d19cd44b-cc36-dd32-2bf8-2f292c79576a@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3190290673096604322=="
List-Id: <development.lists.ipfire.org>

--===============3190290673096604322==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

This patchset looks okay, although it could have been slightly smaller. You d=
o not need to split the changes in the lfs files from the root files. That sh=
ould be one patch per package.

> On 7 Oct 2019, at 19:15, peter.mueller(a)ipfire.org wrote:
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> lfs/bash | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/lfs/bash b/lfs/bash
> index 09b4e71e6..79c21896b 100644
> --- a/lfs/bash
> +++ b/lfs/bash
> @@ -1,7 +1,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2019  IPFire Team  <info(a)ipfire.org>               =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -24,7 +24,7 @@
>=20
> include Config
>=20
> -VER        =3D 4.3
> +VER        =3D 5.0
>=20
> THISAPP    =3D bash-$(VER)
> DL_FILE    =3D $(THISAPP).tar.gz
> @@ -53,7 +53,7 @@ objects =3D $(DL_FILE)
>=20
> $(DL_FILE)             =3D $(DL_FROM)/$(DL_FILE)
>=20
> -$(DL_FILE)_MD5         =3D 81348932d5da294953e15d4814c74dd1
> +$(DL_FILE)_MD5         =3D 2b44b47b905be16f45709648f671820b
>=20
> install : $(TARGET)
>=20
> @@ -87,8 +87,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	sed -e "s/filename, RTLD_LAZY/filename, RTLD_NOW/" \
> 		-i $(DIR_APP)/builtins/enable.def
>=20
> -	for i in $$(seq 1 30); do \
> -		cd $(DIR_APP) && patch -Np0 < $(DIR_SRC)/src/patches/bash/bash43-$$(prin=
tf "%03d" "$${i}") || exit 1; \
> +	for i in $$(seq 1 11); do \
> +		cd $(DIR_APP) && patch -Np0 < $(DIR_SRC)/src/patches/bash/bash50-$$(prin=
tf "%03d" "$${i}") || exit 1; \
> 	done
>=20
> 	cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/bash-4.0-paths-1.patch
> --=20
> 2.16.4


--===============3190290673096604322==--