Re: Introduce of >updated< webui of update accelerator

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 5256 bytes --]

Hi,

I just reviewed your changes and I have got overall mixed feelings:

On Tue, 2013-03-05 at 16:40 +0100, Jörn-Ingo Weigert wrote:
> I would like to introduce and (ask to merge) the new updated webui of
> update accelerator
> (and some other minor changes which should be implemented)
> 
> First the new ui of updxlrator could be found here:
> ====================================
> 
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/new-updxlrator-wui
> 
> The new ui have in most parts a renovated code base and a layout which
> are separated in a html / css part.
> - In XHTML1.0 strict deprecated tags like <font> or style-attributes are removed
> - no hardcoded path-variables except of the variables at code begin anymore
> - The layout is now splitted into several parts: "Overview" /
> "Statistics" / "Maintenance" & new "Settings" which can be choosed by
> an button area in upper right corner
> - The section which shouldbe shown when calling update accelerator via
> sidemenu could now be set in settings view
> - When using current browser like opera or chrome the fields for max
> disk usage & max-bandwidth usage are shown as slider / number selector
> for older browser old input fields
> - the percentbar for disk usage shows now the space used by update
> accelerator & total disk usage instead of only total disk usage
> - the vendor-icons are now searched dynamically and be shown in the
> legend and rows if they are present in
> /srv/web/ipfire/html/images/updatebooster
> - all other symbols are collected together in one graphic
> - Update files are now sorted by vendor in maintenance view

I did not merge this yet, because I wanted to have a closer look at the
code (there are a lot of changes in a single commit) and the user
interface, which does not look consistent with the rest of the web user
interface. Why is that?

> Updated Themes ipfire / maniac:
> =======================
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/XHTML_1.0
> 
> The XHTML declaration inside functions.pl of both themes lacks correct
> syntax, so this caused Chrome Browser
> to interpret first the HTML-Code in ascii which slows down the render
> time inside the browser and blocks the preload
> function of IE 8 and up. This fix correct this
> 
> Which fixed also Bug 10267. https://bugzilla.ipfire.org/show_bug.cgi?id=10267

I merged this. But in general, this code will never conform to a certain
standard. It's all messy and not easily maintainable.

>  Delivery of compressed html-pages:
> ==========================
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/mod_deflate_httpd
> 
> Cause of some huge content pages delivered by f.e. update accelerator
> or large log-files it is good to use
> mod_deflate if Browser support it. That reduces bandwidth which users
> appreciate if they call the webif via external access or slow lines.
> This patch activates it for content except of images or Javascript-Files

I agree with using mod_deflate, but why do you only use it for the SSL
pages? Did not merge this, except the Cache-Control commit.

> Improved age-Function:
> =================
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/new_age-function
> 
> This advanced version now shows only the time parts, which are
> important in singular / plural / shortened form.
> examples:
> (1 seconds.) instead of (0d, 0h, 0m, 1s)
> (3 minutes, 1 sec.)
> (4 hours, 3 min., 1 sec)
> (2 days, 4 hr., 3 min., 1 sec.)

Merged, with some small changes. Please pay attention to your whitespace
errors.

> Colorized & Improved uptime
> =====================
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/new_uptime
> 
> In both themes there are used different javascript-codes to display
> in/out bandwidth rate.
> This patch correct that and use in maniac-theme as in ipfire-theme the
> same external jquery.js
> the style-attributes to colorize the output is now included inside the style.css

Merged, but I removed "span" from the CSS, because the elements you were
searching for are addressed by their IDs.

Why has the javascript not been changed in the IPFire theme?

> And at least a small optical layout issue
> =============================
> Git: http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=shortlog;h=refs/heads/Correcting_H3-Tag
> 
> there was a large margin-bottom defined for the H3-Tag which caused
> the spacer line not inline with that of the sidemenu
> This patch fixes that.
> 
> Lang-files for de and en are included, all other langs need some maintenance.
> 
> some screenshots can be found in at the end of the first post in:
> http://forum.ipfire.org/index.php?topic=7518

Looks a bit better, but is still not in line with the sidebar underline.
Anyway, I merged this.

Please review the changes and please fix the other things I mentioned.
http://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=shortlog;h=refs/heads/core68

Why don't you use your @ipfire.org email address?

-Michael