public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Content-type with charset at showhttpheaders in header.pl
Date: Thu, 28 Mar 2013 11:07:07 +0100	[thread overview]
Message-ID: <1364465227.1844.98.camel@rice-oxley.tremer.info> (raw)
In-Reply-To: <CALL-FuVGzXXJgbEfQHhLJ8irnRhMmHd0viu9vg_N8vRfUEbOMg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

Hi,

Jörn-Ingo suggested this a couple of weeks ago and this patch got
accepted in Core 68:

http://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=1d795ec5a9c11f8512c77e1b51dfc88678f1f9e0

It's basically the same change of lines in the code. :)

-Michael

On Thu, 2013-03-28 at 02:09 +0100, Kay-Michael Köhler wrote:
> I suggest to set the charset with the Content-type. That will make
> things go faster with the browsers.
> 
> 
> Regarding to: 
> https://developers.google.com/speed/docs/best-practices/rendering#SpecifyCharsetEarly
> 
> 
> Specifying a character set in the HTTP response headers of your HTML
> documents allows the browser to begin parsing HTML and executing
> scripts immediately.
> 
> 
> Regards,
> Kay-Michael
> 
> 
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index bbb0eca..7c36820 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -164,7 +164,7 @@
>   print "Pragma: no-cache\n";
>   print "Cache-control: no-cache\n";
>   print "Connection: close\n";
> - print "Content-type: text/html\n\n";
> + print "Content-type: text/html; charset=UTF-8\n\n";
>  }
>  
>  sub is_menu_visible($) {
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development


           reply	other threads:[~2013-03-28 10:07 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CALL-FuVGzXXJgbEfQHhLJ8irnRhMmHd0viu9vg_N8vRfUEbOMg@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364465227.1844.98.camel@rice-oxley.tremer.info \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox