From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Request to merge: new-updxlrtr-v3.0: Enabling GET-Params for %xlrtrsettings
Date: Thu, 25 Apr 2013 12:29:27 +0200 [thread overview]
Message-ID: <1366885767.32654.127.camel@rice-oxley.tremer.info> (raw)
In-Reply-To: <CAAiW7AdWAdBvkLqNGjcE0MLp-LqhP_T2rjRpktdSBRurjfzfWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hey,
I think the original intention to filter for POST requests is to prevent
cross-site scripting issues. However, it is not a huge problem to create
a POST request with JS.
I am still not convinced that we should remove this line. It makes XSS
attacks more easy and therefore more dangerous.
For what exactly is this modification required?
-Michael
On Wed, 2013-04-24 at 18:22 +0200, Jörn-Ingo Weigert wrote:
> This add GET-Parameters for xlrtrsettings in header.pl
>
>
> http://git.ipfire.org/?p=people/jiweigert/ipfire-2.x.git;a=commit;h=b836edd0511e2cfc807292ff84322e71aa2dd7ec
>
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development
next parent reply other threads:[~2013-04-25 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAiW7AdWAdBvkLqNGjcE0MLp-LqhP_T2rjRpktdSBRurjfzfWA@mail.gmail.com>
2013-04-25 10:29 ` Michael Tremer [this message]
[not found] <CAAiW7AcJw4j9MfnZVjoZ3pg02t1udXPCfR0xHU-p9XS6s8Xk+w@mail.gmail.com>
2013-04-26 10:35 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366885767.32654.127.camel@rice-oxley.tremer.info \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox