From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Incorrect naming convention used on the Core Update 170 download file. Date: Sat, 17 Sep 2022 13:29:12 +0200 Message-ID: <13a4caeb-8094-a9eb-3478-3140857419a7@ipfire.org> In-Reply-To: <6aa8a3df-e3e2-aa42-33dd-13a548d2441f@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0995027273972595003==" List-Id: --===============0995027273972595003== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Matthias, On 17/09/2022 13:00, Matthias Fischer wrote: > Hi, >=20 > please find my comments below... ;-) >=20 > On 17.09.2022 12:22, Adolf Belka wrote: >> Hi Matthias, >> >> On 17/09/2022 11:28, Matthias Fischer wrote: >>> Hi, >>> >>> Confirmed. Somehow the name of the ISO has changed. >>> >>> But - correct me if I'm wrong! - the naming of the ISO file takes place >>> in '/usr/local/bin/backupiso': >> That is correct but before that occurs the first step is to download the >> original iso from the IPFire download site and it looks in that download >> site for an iso named ISO=3D"ipfire-$IPFVER.$arch-full-core$COREVER.iso" >> which is fine for CU169 and earlier but CU170 has had the arch portion >> moved to a different location in the filename. >> >> Either the new filename structure for the IPFire CU170 download has been >> changed accidentally or it has been done deliberately but forgotten to >> change the template in backup.pl etc. >> >>> >>> Current is: >>> ... >>> ISO=3D"ipfire-$IPFVER.$arch-full-core$COREVER.iso" >>> ... >>> >>> IMHO it could be sufficient to change this to: >>> ... >>> ISO=3D"ipfire-$IPFVER-core$CORVER-$arch.iso" >> Changing that would fix the problem but only if the change of the >> download filename on the IPFire server was changed deliberately. >=20 > As I see it - ${URL} is OK, but the name of the *file to download* (the > ${ISO}-variable) changed - somehow...: >=20 > https://downloads.ipfire.org/releases/ipfire-2.x/2.27-core170/ipfire-2.27-c= ore170-x86_64.iso >=20 > And ${ISO} is exactly the variable 'wget' needs (e.g): >=20 > Line 81 in 'backup.iso': > ... > wget --quiet -c ${URL}${ISO} > ... >=20 > Line 84f: > ... > echo "Fetching ${URL}${ISO}.b2" > wget --quiet -O ${ISO}.b2 ${URL}${ISO}.b2 $(ISO) has not been changed in backup.pl or backup.iso. It is still=20 looking for a file named ipfire-$IPFVER.$arch-full-core$COREVER.iso=20 which for CU170 would be ipfire-2.27.x86_64-full-core170.iso but on the CU170 download site the file is actually named ipfire-2.27-core170-x86_64.iso so the word full is missing and the arch (x86_64 or aarch64) has moved=20 to just before the .iso part. So wget will not find the file because the=20 name on the download site will have changed. I am not sure I am understanding the point you are making. Maybe I am=20 confusing what you are saying. My understanding is that the name of the download file on the IPFire=20 server has changed and nothing has changed in backup.pl/backup.iso but=20 my understanding is that you think something has changed in backup.iso=20 and that is the cause of the problem. Am I misunderstanding you? Regards, Adolf. > ... >=20 > Or do I miss something? [(Brett vorm Kopf!?)] >=20 > Best, > Matthias >=20 >> Regards, >> Adolf. >>> ... >>> >>> I haven't searched for other occurences yet, but I think that could be >>> the culprit... >>> >>> jm2c >>> >>> Matthias >>> >>> On 16.09.2022 16:24, Adolf Belka wrote: >>>> Hi All, >>>> >>>> On 16/09/2022 16:02, Adolf Belka wrote: >>>>> Hi everyone, >>>>> >>>>> On the forum there have been a couple of people who tried creating an i= so backup and it only showed a 0 byte file. >>>>> >>>>> >>>>> I have confirmed with my vm testbed. The same thing works fine for CU16= 9. >>>>> >>>>> >>>>> After looking through code I have found that Core Update 169=C2=A0 and = 170 file name order is different. The arch is placed in a different location >>>>> >>>>> >>>>> https://downloads.ipfire.org/releases/ipfire-2.x/2.27-core169/ipfire-2.= 27.x86_64-full-core169.iso >>>>> >>>>> https://downloads.ipfire.org/releases/ipfire-2.x/2.27-core170/ipfire-2.= 27-core170-x86_64.iso >>>>> >>>>> This means that backup.pl is not able to find the Core Update 170 iso f= rom the downloads site. >>>>> >>>> If the change in iso file naming convention was intended then backup.pl = also needs to be modified for the iso naming convention. >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> >>>>> >>>>> Regards, >>>>> >>>>> Adolf. >>>>> >>>>> >>> >> >=20 --=20 Sent from my laptop --===============0995027273972595003==--