GitHub Pull Requests?

GitHub Pull Requests?

[Stefan Ferstl]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi

I recently had some troubles with my OpenVPN certificates on IPFire. I
could easily fix the problem with a one-liner in OpenVPN's "verify"
script.
Additionally, I filed a pull request [1] on GitHub with that solution.
Since there hasn't been any reaction at all whatsoever for more than
one month now, I want to ask if I have to submit a patch over a
different channel than via GitHub.


Cheers,
Stefan


[1] https://github.com/ipfire/ipfire-2.x/pull/25

Re: GitHub Pull Requests?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

Hi Stefan,

thanks for your submission.

Indeed GitHub Pull requests are not the best way for us to handle those.
GitHub is still not able to send us notifications when a new pull
request is created. We don't use it for anything else than just
mirroring our repositories to there.

That means you can use pull requests, but always open a bug report in
our own bugtracker and reference both to each other. In that way, we can
track GitHub pull requests just as we do it with everything else like
assinging them to people who will take care of those and you can use
your own repositories on GitHub.

If you could please do that we can start looking into the matter.

Best,
-Michael

On Sat, 2014-06-14 at 19:01 +0200, Stefan Ferstl wrote:
> Hi
> 
> I recently had some troubles with my OpenVPN certificates on IPFire. I
> could easily fix the problem with a one-liner in OpenVPN's "verify"
> script.
> Additionally, I filed a pull request [1] on GitHub with that solution.
> Since there hasn't been any reaction at all whatsoever for more than
> one month now, I want to ask if I have to submit a patch over a
> different channel than via GitHub.
> 
> 
> Cheers,
> Stefan
> 
> 
> [1] https://github.com/ipfire/ipfire-2.x/pull/25
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development

Re: GitHub Pull Requests?

[Stefan Ferstl]

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

Hi Michael

Thanks for the information. I created an issue in Bugzilla [1] and
linked it to the PR on GitHub.


Cheers,
Stefan

[1] https://bugzilla.ipfire.org/show_bug.cgi?id=10552


On Sat, Jun 14, 2014 at 7:55 PM, Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> Hi Stefan,
>
> thanks for your submission.
>
> Indeed GitHub Pull requests are not the best way for us to handle those.
> GitHub is still not able to send us notifications when a new pull
> request is created. We don't use it for anything else than just
> mirroring our repositories to there.
>
> That means you can use pull requests, but always open a bug report in
> our own bugtracker and reference both to each other. In that way, we can
> track GitHub pull requests just as we do it with everything else like
> assinging them to people who will take care of those and you can use
> your own repositories on GitHub.
>
> If you could please do that we can start looking into the matter.
>
> Best,
> -Michael
>
> On Sat, 2014-06-14 at 19:01 +0200, Stefan Ferstl wrote:
>> Hi
>>
>> I recently had some troubles with my OpenVPN certificates on IPFire. I
>> could easily fix the problem with a one-liner in OpenVPN's "verify"
>> script.
>> Additionally, I filed a pull request [1] on GitHub with that solution.
>> Since there hasn't been any reaction at all whatsoever for more than
>> one month now, I want to ask if I have to submit a patch over a
>> different channel than via GitHub.
>>
>>
>> Cheers,
>> Stefan
>>
>>
>> [1] https://github.com/ipfire/ipfire-2.x/pull/25
>> _______________________________________________
>> Development mailing list
>> Development(a)lists.ipfire.org
>> http://lists.ipfire.org/mailman/listinfo/development
>