From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: DynDNS support for ddns project.
Date: Mon, 16 Jun 2014 12:08:41 +0200
Message-ID: <1402913321.6967.23.camel@rice-oxley.tremer.info>
In-Reply-To: <539C8212.8000801@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3938503983598416240=="
List-Id: <development.lists.ipfire.org>

--===============3938503983598416240==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Stefan,

I merged this one (with a couple of cleanups) and the other new
providers in your repository as well.

Please double-check if I resolved all merge conflicts correctly and that
everything still works for you.

Best,
-Michael

On Sat, 2014-06-14 at 19:10 +0200, Stefan Schantl wrote:
> Hello Michael and list followers,
>=20
> during my work on integrating several dynamic dns providers I've=20
> rewritten the code for the dyndns.org provider.
>=20
> I've included your suggestions and was able to do some testing by using=20
> the provided test accounts from dyndns.org=20
> (http://dyn.com/support/developers/test-account/)
>=20
> I've pushed the changes to my personal git repository, they can be found=20
> here:
>=20
> http://git.ipfire.org/?p=3Dpeople/stevee/ddns.git;a=3Dblobdiff;f=3Dsrc/ddns=
/providers.py;h=3D5954b91c17ad27aa58d86ad5cd9f49e50e5aa973;hp=3D2788c9722ae86=
aa1ac89d8aab32e72129e0a0209;hb=3Db5bf290b8a613ac5becf59c71cbb1922d4ce53c5;hpb=
=3D3fcc662c83320ff8c0e64e22d0604f8955ab4011
>=20
> Please have a look on them and merge the changes to the main ddns git=20
> repository so we can support this provider.
>=20
> Best regards,
>=20
> -Stefan
>=20
> > Hey Stefan,
> >
> > thanks for your contribution so far. I have found several problems,
> > which need to be fixed:
> >
> > 1) We cannot possibly accept any code which has not been tested. Please
> > go and look for some people who can do that if you cannot do it on your
> > own.
> >
> > 2) In the URL, you created are some options, which are deprecated as it
> > is explained here http://dyn.com/support/developers/api/perform-update/.
> > You should not introduce already deprecated functionality.
> >
> > So, I suggest to drop "wildcard", "mx" and "backupmx" from the URL.
> >
> > 3) As it is listed here
> > http://dyn.com/support/developers/api/return-codes/, there are a lot of
> > return codes, which are not catched. You should consider to implement
> > some of them which might be useful for the users like "nofqdn" or
> > "nohost". I would cosider "dnserr" as mandatory.
> >
> > Michael
> >
> > On Sun, 2012-09-09 at 19:34 +0200, Stefan Schantl wrote:
> >> Hello guys,
> >>
> >> i've created a patch for the Dynamic DNS client for IPFire.
> >> (http://git.ipfire.org/?p=3Doddments/ddns.git;a=3Dsummary)
> >>
> >> My patch will add support for the very popular "dyndns.org" provider.
> >> However I wasn't able to test my changes, because
> >> I don't have any account there and I seems new members have to purchase
> >> to use use it.
> >>
> >> So, I need your help to test my changes and finally be able to support
> >> that provider in the next major version of IPFire.
> >>
> >> Best regards,
> >>
> >> Stefan
> >> _______________________________________________
> >> Development mailing list
> >> Development(a)lists.ipfire.org
> >> http://lists.ipfire.org/mailman/listinfo/development
>=20


--===============3938503983598416240==--