From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schantl To: development@lists.ipfire.org Subject: Re: Introducing DDNS Date: Wed, 09 Jul 2014 19:37:48 +0200 Message-ID: <1404927468.16368.9.camel@acer.stevee> In-Reply-To: <1404155136.5242.3.camel@hughes.tremer.info> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6589645023726546891==" List-Id: --===============6589645023726546891== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, thanks for your feedback, I've reworked my changes and divided into several commits now. > Hello, >=20 > On Mon, 2014-06-30 at 20:53 +0200, Stefan Schantl wrote: > > Hello Michael, > >=20 > > I've coded some lines to support the ddns provider "enom.com" which has=20 > > been requested on our bugtracker (#10588, #10567). > >=20 > > Basic tests with some invalid data ( because I don't have an account=20 > > there) have been performed and the errors have been triggered the=20 > > correct exceptions. >=20 > Great, but you really need to test your code. If it is a free provider > go and register an account. If not, search for someone who has already > got an account and get them testing this for you. Thanks for the hint, I will try to get a tester for this non free provider. The code for adding it can be obtained from here: http://git.ipfire.org/?p=3Dpeople/stevee/ddns.git;a=3Dcommit;h=3D352165232642= 9d80c67b8a0e7277d9e48ac5faa3 >=20 > > * While implementing the new ddns provider, I've moved the "parse_xml"=20 > > function from the Namecheap provider to the DDNSProvider main class to=20 > > allow reuse of the code and gain access to this function for additional=20 > > providers which will be included in the future. >=20 > I really don't see why we would need that in the global class. You could > probably move that to a third class you pull in which then provides only > this function. A class can inherit from multiple classes at the same > time. I've moved the affected code parts now into it's own class as you suggested. http://git.ipfire.org/?p=3Dpeople/stevee/ddns.git;a=3Dcommit;h=3D78c9780b8f7e= 6342b491db90aca4fa5cb4d45850 >=20 > > * I also found some missing lines which accidently have been dropped=20 > > while fixing merge conflicts. >=20 > I would need an extra commit with only that. Done. http://git.ipfire.org/?p=3Dpeople/stevee/ddns.git;a=3Dcommit;h=3Da204b1072c8e= 45c1ccdbbae4ed7179988b2afadf Best, -Stefan >=20 > > You can find all changes here: > >=20 > > http://git.ipfire.org/?p=3Dpeople/stevee/ddns.git;a=3Dcommit;h=3D21d0fcb8= 335d979344a97e33cc36aa88d0fd67cb > >=20 > > Please have a look on them and merge them to upstream. >=20 > Done that. See my remarks above. >=20 > -Michael >=20 > > A big thanks in advance, > >=20 > > -Stefan > > > Hello, > > > > > > this is a post to update you all about the recent developments regarding > > > the support for the various upcoming dynamic DNS providers. > > > > > > > > > Rationale > > > > > > Some of the major dynamic DNS providers stopped their free services or > > > made them unusable so that people started searching for alternatives. In > > > IPFire 2, a script called setddns.pl [1] is responsible for updating the > > > dynamic DNS records. This script has grown over the last couple of > > > months and if you have looked into it you will have noticed that it has > > > become from ugly to almost un-maintainable. The decision that we don't > > > want to take this mess with us into the next generation of IPFire was > > > already made many years ago. > > > > > > > > > DDNS > > > > > > A project called ddns was started which is a pure Python client that is > > > much more flexible, cleanly rewritten and easily extensible. It is > > > cross-platform, cross-distribution and does not need any third-party > > > python modules. > > > > > > The basics already written years ago, Stefan Schantl and I worked on > > > making this ready for IPFire 2 and added all the providers that are > > > currently supported by setddns.pl and ez-ipupdate. > > > > > > The source for the new DDNS tool can be found over here: > > > > > > http://git.ipfire.org/?p=3Dddns.git;a=3Dsummary > > > > > > or on GitHub > > > > > > https://github.com/ipfire/ddns > > > > > > were you can send us pull requests for supporting new providers and so > > > on. > > > > > > Bug reports go to the usual place: > > > > > > https://bugzilla.ipfire.org/describecomponents.cgi?product=3DDDNS%20= Updater > > > > > > There is no fixed release schedule for this, but we are pretty sure that > > > this won't take long until DDNS arrives in IPFire 2. That means that we > > > won't take any patches for the setddns.pl script that add support for > > > new providers any more. > > > > > > We appreciate any contribution and as always hope to get some feedback > > > back from the community! > > > > > > Best, > > > -Michael > > > > > > [1] http://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dsrc/scripts/= setddns.pl;h=3D5e77fce5c024a3f17ba4c892a94abfe95845e8c6;hb=3DHEAD > > > > > > _______________________________________________ > > > Development mailing list > > > Development(a)lists.ipfire.org > > > http://lists.ipfire.org/mailman/listinfo/development > >=20 > > _______________________________________________ > > Development mailing list > > Development(a)lists.ipfire.org > > http://lists.ipfire.org/mailman/listinfo/development >=20 >=20 --===============6589645023726546891==--