* MySQL - 5.6.19 @ 2014-07-18 10:13 Sascha Kilian 2014-08-15 9:45 ` Michael Tremer 0 siblings, 1 reply; 2+ messages in thread From: Sascha Kilian @ 2014-07-18 10:13 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 240 bytes --] Hi there, i have committed a fix for my MySQL 5.6.19. The first version dont really worked in a fresh IPFire build https://bitbucket.org/tikira/ipfire-2.x/commits/02c5d5a5ee6d79c275c0edde51a21e2a99400b77 best regards Sascha ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: MySQL - 5.6.19 2014-07-18 10:13 MySQL - 5.6.19 Sascha Kilian @ 2014-08-15 9:45 ` Michael Tremer 0 siblings, 0 replies; 2+ messages in thread From: Michael Tremer @ 2014-08-15 9:45 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1260 bytes --] Hi, please check if your branch still builds before you send patches. That's the first thing to do. The second one is testing. So mysql changed to cmake. Only the devil knows why. You added cmake as a dependency (DEPS =) which is not necessary because cmake is just a build dependency and not needed at runtime. The configuration command worries me a bit more. Are the paths that were passed to the configure command still honored with cmake? All files and especially the databases need to remain in the same place to not break existing installations. Is it necessary to call mysql_install_db at build time? What is the reason to remove the backup include file at the end? How will the system migrate any pre-existing databases? -Michael On Fri, 2014-07-18 at 12:13 +0200, Sascha Kilian wrote: > Hi there, > > i have committed a fix for my MySQL 5.6.19. The first version dont > really worked in a fresh IPFire build > > https://bitbucket.org/tikira/ipfire-2.x/commits/02c5d5a5ee6d79c275c0edde51a21e2a99400b77 > > best regards > > Sascha > > _______________________________________________ > Development mailing list > Development(a)lists.ipfire.org > http://lists.ipfire.org/mailman/listinfo/development ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-15 9:45 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-07-18 10:13 MySQL - 5.6.19 Sascha Kilian 2014-08-15 9:45 ` Michael Tremer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox