Removed code by mistake?

Removed code by mistake?

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

According to a user on the german forum, after he installed Core 90,  
"/etc/ipsec.user-post.conf" is not included anymore:
https://forum.ipfire.org/viewtopic.php?f=16&t=10704&p=86008#p86004

I tracked it down to  
https://github.com/ipfire/ipfire-2.x/commit/dfea4f86c22c83e07d0f4a6f2a02166229ecb120  
where it has been removed. Seems to me that this was by mistake as the  
commit message is "strongswan: Allow using AES-GCM in various  
configurations".

btw: Is it ok to post this on the list or should I create a ticket in  
bugzilla?


Lars

Re: Removed code by mistake?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

Hi,

On Tue, 2015-06-02 at 17:11 +0200, Larsen wrote:
> According to a user on the german forum, after he installed Core 90,  
> "/etc/ipsec.user-post.conf" is not included anymore:
> https://forum.ipfire.org/viewtopic.php?f=16&t=10704&p=86008#p86004

This seems to be not intentional.

> I tracked it down to  
> https://github.com/ipfire/ipfire-2.x/commit/dfea4f86c22c83e07d0f4a6f2a02166229ecb120  
> where it has been removed. Seems to me that this was by mistake as the  
> commit message is "strongswan: Allow using AES-GCM in various  
> configurations".
> 
> btw: Is it ok to post this on the list or should I create a ticket in  
> bugzilla?

A patch to this list is fine. The other ones you sent in where
unfortunately line-wrapped by your mail client. Please try using git
send-email or change some settings on your email client to avoid this.
The file won't apply now.

Best,
-Michael

> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Removed code by mistake?

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

On Tue, 02 Jun 2015 19:36:36 +0200, Michael Tremer <michael.tremer(a)ipfire.org> wrote:

> unfortunately line-wrapped by your mail client. Please try using git
> send-email or change some settings on your email client to avoid this.
> The file won't apply now.

I couldn´t find something like send-email in TortoiseGit (using Windows here), but I disabled line-wrapping in my email-client, so this should be fine now.


Lars

Re: Removed code by mistake?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On Tue, 2015-06-02 at 21:03 +0200, Larsen wrote:
> On Tue, 02 Jun 2015 19:36:36 +0200, Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> 
> > unfortunately line-wrapped by your mail client. Please try using git
> > send-email or change some settings on your email client to avoid this.
> > The file won't apply now.
> 
> I couldn´t find something like send-email in TortoiseGit (using Windows here), but I disabled line-wrapping in my email-client, so this should be fine now.

I do not know about an equivalent on Windows.

This email you just sent does not use line-wrapping as you can see by
the longish sentence above, but it would be fine if it would use that
for written text because that is better readable when it wraps around
after 80 characters or so.

-Michael

> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Removed code by mistake?

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

On Tue, 02 Jun 2015 21:06:58 +0200, Michael Tremer <michael.tremer(a)ipfire.org> wrote:

> This email you just sent does not use line-wrapping as you can see by
> the longish sentence above, but it would be fine if it would use that
> for written text because that is better readable when it wraps around
> after 80 characters or so.


I don´t think there is a setting to only disable line-wrapping
for inline patches ;-)

Will wrap manually then.


Lars