public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ipsec.conf: Include ipsec.user.conf and ipsec.user-post.conf
Date: Thu, 04 Jun 2015 17:53:27 +0200	[thread overview]
Message-ID: <1433433207.25208.6.camel@ipfire.org> (raw)
In-Reply-To: <op.xzofgbpncahio0@honk.fritz.box>

[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]

Hi,

thank you for sending this in. The patch looks good and I merged it
already as it is a pretty simple one.

However I had again trouble applying it right away. I do not really know
why. It must some sort of whitespace error because the patch applies
with patch --ignore-whitespace. So this wasn't a one-time error with the
last patch.

Best,
-Michael

On Thu, 2015-06-04 at 00:58 +0200, Larsen wrote:
> Fix bug 10869 as the code has been removed by mistake by the
> previous commit dfea4f86c22c83e07d0f4a6f2a02166229ecb120.
> It also includes ipsec.user.conf only when it exists.
> 
> Signed-off-by: Lars Schuhmacher <larsen007(a)web.de>
> ---
>   html/cgi-bin/vpnmain.cgi | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/vpnmain.cgi b/html/cgi-bin/vpnmain.cgi
> index 9490076..218dafa 100644
> --- a/html/cgi-bin/vpnmain.cgi
> +++ b/html/cgi-bin/vpnmain.cgi
> @@ -253,8 +253,10 @@ sub writeipsecfiles {
>       print CONF "\n";
> 
>       # Add user includes to config file
> -    print CONF "include /etc/ipsec.user.conf\n";
> -    print CONF "\n";
> +    if (-e "/etc/ipsec.user.conf") {
> +        print CONF "include /etc/ipsec.user.conf\n";
> +        print CONF "\n";
> +    }
> 
>       print SECRETS "include /etc/ipsec.user.secrets\n";
> 
> @@ -407,6 +409,14 @@ sub writeipsecfiles {
> 
>   	print CONF "\n";
>       }#foreach key
> +
> +    # Add post user includes to config file
> +    # After the GUI-connections allows to patch connections.
> +    if (-e "/etc/ipsec.user-post.conf") {
> +        print CONF "include /etc/ipsec.user-post.conf\n";
> +        print CONF "\n";
> +    }
> +
>       print SECRETS $last_secrets if ($last_secrets);
>       close(CONF);
>       close(SECRETS);

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-06-04 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 22:58 Larsen
2015-06-04 15:53 ` Michael Tremer [this message]
2015-06-04 15:59   ` Larsen
2015-06-04 16:02     ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433433207.25208.6.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox