From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Problem with whitespace in patches Date: Fri, 05 Jun 2015 15:25:32 +0200 Message-ID: <1433510732.27049.11.camel@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4165983104974582693==" List-Id: --===============4165983104974582693== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-06-04 at 22:52 +0200, Larsen wrote: > (I changed the subject as this has nothing to do with pppsetup.cgi) >=20 >=20 > On Thu, 04 Jun 2015 18:23:07 +0200, Michael Tremer wrote: >=20 > > If I remove the first space from every line of the diff that does not > > start with a + or - character. Any idea how this comes? >=20 >=20 > TL;DR: Opera 12.17 f*cks up the patch when sent as plain text. >=20 >=20 > 1) I took the file that TortoiseGit saved, saved the text I sent to the lis= t, the text > I received from the list, and the file that Michael sent back. > 2) Edited all of them to start with these lines: > --- a/html/cgi-bin/vpnmain.cgi > +++ b/html/cgi-bin/vpnmain.cgi > 3) Converted the saved mails to UNIX format with LF instead of CRLF (Window= s here) This was one of my first guesses, but it turned out to be false very quickly. > 4) Calculated md5sums: They were all the same except for the one sent to th= e list >=20 > Examining this further, I noticed a bug in my mail program when it displays= the mail > in the "sent" folder: When there is more then one line beginning with a spa= ce char, > the mailer will put a superfluous space character into the beginning of the= last line. > Strange as hell, but this only affects the display here. >=20 > Then, I switched views to have the header displayed, too, and saved it as a= file. > Compared to the file created by TortoiseGit and now I can solve this riddle: > There we have superfluous whitespace in front of every line without a + or - > (as you noticed before). I cannot really understand why this would make the email better readable or anything. > I now also compared the mail I received as it is shown in my mail program a= nd the bug > is present there, too. Display is ok (even without that one extra space cha= r - that is > why the md5sum was ok first), but not when I display it with headers (raw v= iew so to > say). >=20 > Will send the next patches with Thunderbird and hope that it will be ok the= n. > Wasted about an hour examining this - hope you guys at least had fun readin= g ;-) >=20 Let us know about your experience with Thunderbird. -Michael >=20 > Lars --===============4165983104974582693== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC Q2dBR0JRSlZjYU5OQUFvSkVJQjU4UDl2a0FrSHUvd1AvMnQzamQvMEJZekxEdUNFRm1BcStad2UK QVNaNzNNOWJyWUcyK1NhanRGZkJwUGtzQ1V2Zjg4NEt6U1Fuam5yWm1CenREbVc5aFVBTlNmcWIv eDJ1aU1sMQp4dUtFNjBCcFVzOXNRQ05IMkRTVVd0U3pqdjJXSk0ybmYycGNoVkpoUWtiL0Z3Z0M3 Ym9YYmFldkszbUpENGFiCnBjYXVBb013K0tCb3ZOT0hzQlNJaE02L2NXN0o2Z2IyTUVTVGF1b2h5 YVIrN3MvYklFNlBLd0w3L2o2Qy9QalcKMkFLdkhrdnlzdW9CelZnTE1Qb3pkcVlmYmxEckp1MHB5 dW01T283a3NVR1VNckRlUHJTckR4WGNycmFncnVHbQpkSVlwS3R4TUhCbGRqWllWQmFFRnRVbTN4 UkdrVW9jMlJSZDNsVzg3VkQrMWNKVE5pa3VxRlJTYU9IWnBrK2F6CnFad2x2bGRZbXlaQUlxSVcx Rlg4L1laZGhZSkZ1a0JxVzg1K3k0MEZWdjdqVmJlMkd0TlhrektmZ2w3UkloZHoKZWk3LzczeXVn cTRXSHNQL21QanJubkR4SktaT3dXcW9LWjFJUTJNS2kwZThlK3RZWG83eXZEd1Z6bzVYYVVxbgpJ WnFtYnBlVDdoS0VKczdyejRnTXIvdjNMV1dacnU1UmpVcHRmR2J6TnplOUNyQjFDdm1nU3hqcEZO V1NtaXBuCkxiTkJqdEM3Zi9CRW1rdUR5cmI5SXJUV2xGSlJIRXM5REFUbHJ3blhyWGNQK0ppeCtZ ZzI1bVQ2U2ozcXhWcFoKb2pDVG0vSU9WWTlJdlZlUnVrMkRpNzNubHRrbUh6dVJpdDEyVVlRUng5 bzIzNVBqdlp2MEEybGs0REtTZ0JoeAo5QjdQMHpyaEI5N1pQYUVJcG1JeAo9djVDRwotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============4165983104974582693==--