From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Link the IPFire logo to ipfire.org
Date: Tue, 09 Jun 2015 12:53:08 +0200 [thread overview]
Message-ID: <1433847188.25208.149.camel@ipfire.org> (raw)
In-Reply-To: <55760023.9040301@web.de>
[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]
Hi Lars,
Is there a certain reason why this is done by using Javascript? An <a>
tag would have worked fine as well I think. That would require to embed
the image by using the <img> tag, but that is probably the cleaner
solution any way...
Other than that: I like the idea.
Best,
-Michael
On Mon, 2015-06-08 at 22:50 +0200, Larsen wrote:
> Link the IPFire logo and subsequent text to http://www.ipfire.org
>
> Signed-off-by: Lars Schuhmacher <larsen007(a)web.de>
> ---
> html/html/themes/darkdos/include/functions.pl | 2 +-
> html/html/themes/ipfire-legacy/include/functions.pl | 2 +-
> html/html/themes/ipfire/include/functions.pl | 2 +-
> html/html/themes/maniac/include/functions.pl | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/html/html/themes/darkdos/include/functions.pl
> b/html/html/themes/darkdos/include/functions.pl
> index 737e051..4b00b4c 100644
> --- a/html/html/themes/darkdos/include/functions.pl
> +++ b/html/html/themes/darkdos/include/functions.pl
> @@ -221,7 +221,7 @@ print <<END
>
> <div id="header_inner" class="fixed">
>
> - <div id="logo">
> + <div id="logo" style="cursor: pointer;"
> onclick="window.location='http://www.ipfire.org/';">
> END
> ;
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
> diff --git a/html/html/themes/ipfire-legacy/include/functions.pl
> b/html/html/themes/ipfire-legacy/include/functions.pl
> index 1401030..e1b8cb8 100644
> --- a/html/html/themes/ipfire-legacy/include/functions.pl
> +++ b/html/html/themes/ipfire-legacy/include/functions.pl
> @@ -221,7 +221,7 @@ print <<END
>
> <div id="header_inner" class="fixed">
>
> - <div id="logo">
> + <div id="logo" style="cursor: pointer;"
> onclick="window.location='http://www.ipfire.org/';">
> END
> ;
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
> diff --git a/html/html/themes/ipfire/include/functions.pl
> b/html/html/themes/ipfire/include/functions.pl
> index 63740d4..39d972d 100644
> --- a/html/html/themes/ipfire/include/functions.pl
> +++ b/html/html/themes/ipfire/include/functions.pl
> @@ -151,7 +151,7 @@ print <<END
> </head>
> <body>
> <div id="header" class="fixed">
> - <div id="logo">
> + <div id="logo" style="cursor: pointer;"
> onclick="window.location='http://www.ipfire.org/';">
> END
> ;
> if ($settings{'WINDOWWITHHOSTNAME'} ne 'off') {
> diff --git a/html/html/themes/maniac/include/functions.pl
> b/html/html/themes/maniac/include/functions.pl
> index e8514ad..d3d4a73 100644
> --- a/html/html/themes/maniac/include/functions.pl
> +++ b/html/html/themes/maniac/include/functions.pl
> @@ -221,7 +221,7 @@ print <<END
>
> <div id="header_inner" class="fixed">
>
> - <div id="logo">
> + <div id="logo" style="cursor: pointer;"
> onclick="window.location='http://www.ipfire.org/';">
> END
> ;
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-09 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 20:50 Larsen
2015-06-09 10:53 ` Michael Tremer [this message]
2015-06-09 10:59 ` Larsen
2015-06-09 11:02 ` Michael Tremer
2015-06-09 11:13 ` Larsen
2015-06-09 12:13 ` Michael Tremer
2015-06-09 12:35 ` Larsen
2015-06-09 20:00 Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433847188.25208.149.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox