Re: [PATCH] Link the IPFire logo to ipfire.org

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Tue, 2015-06-09 at 12:59 +0200, Larsen wrote:
> On Tue, 09 Jun 2015 12:53:08 +0200, Michael Tremer  
> <michael.tremer(a)ipfire.org> wrote:
> 
> > Is there a certain reason why this is done by using Javascript? An <a>
> > tag would have worked fine as well I think. That would require to embed
> > the image by using the <img> tag, but that is probably the cleaner
> > solution any way...
> 
> I used this as a starting point:
> http://stackoverflow.com/questions/4465923/a-href-link-for-entire-div-in-html-css
> 
> The <a>-tag didn´t work when I wrapped it around the <div>-tag (and it  
> would only be allowed for HTML5).
> I didn´t think about using an <img>-tag as I thought that it was cleaner  
> as it is by using CSS.
> 
> I do know that some have JS deactivated and don´t like it, but in this  
> case there is nothing lost.

If someone disables JS they will already have issues with other parts of
the web user interface and of course most of the "web 2.0".

> Is there anything else wrong with using JS?

Not in general. I just find it a rather complex solution for a simple
problem. The plain HTML approach would be much better and work for those
who disable JS, too.

-Michael

> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]