From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Mark required input fields with a star
Date: Sat, 27 Jun 2015 12:45:52 +0200
Message-ID: <1435401952.13892.88.camel@ipfire.org>
In-Reply-To: <op.x0votcdrcahio0@honk.fritz.box>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7116462354774740982=="
List-Id: <development.lists.ipfire.org>

--===============7116462354774740982==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Alright. The first two TODOs are easy. There is a variable called $blob
which is defined a couple of lines above. You would need to change the
if statement so that it checks for "net" and that should do the job I
guess.

The other huge blocks need to be cut in two pieces. Usually they use
something that looks like this:

print <<END;
   ABC
   DEF
   123
END

This will simply print everything between the print statement and END.
It will stop when ever there is a line with just "END" in it.

So you could cut that in two parts:

print <<END;
   ABC
   DEF
END

if ($something) {
	print "123\n";
}

That is basically it.

I am not entirely sure if that answers all your questions, so feel free
to ask back if there is anything else you would like to know :)

-Michael

On Sat, 2015-06-27 at 09:37 +0200, Larsen wrote:
> On Thu, 25 Jun 2015 12:28:51 +0200, Alexander Marx <alexander.marx(a)oab.de=
> =20
> wrote:
>=20
> >>>>> On Thu, 2015-06-04 at 23:46 +0200, Larsen wrote:
> >>>>>> PS: Need help with the TODOs in that patch as I am now web developer
> >>>>>> and where I don=C2=B4t know how to use an if-clause.
> >>>>> As these are in the ovpnmain.cgi (as far as I have seen) you should  =

> >>>>> get
> >>>>> in touch with Alex when he is back from holiday. That will be towards
> >>>>> the end of next week.
> >>>> Should not be related to ovpnmain.cgi. I just don=C2=B4t have the =20
> >>>> experience
> >>>> how to combine html-code and if-clauses here. Any dev might be able to
> >>>> give a hint here.
> > Hi
> > All "HTML" Files are the cgi files within /srv/web/ipfire/cgi-bin.
> > These Files are CGI's which means it can be any programming language.
> > The IPFire CGI's are usually written in perl. So one can easily use perl =
=20
> > if-clauses.
> > When it comes to the output part you also use Perl code to "print" the =20
> > htmlcode.
>=20
> Yes, I know where to change it, but I don=C2=B4t know how exactly to combin=
e =20
> perl code and HTML.
> Please have a look at the parts marked with TODO here:
> http://patchwork.ipfire.org/patch/15/
>=20
> In other places, there is a huge "print" part where perl gives out HTML in =
=20
> one block. Here however, I need to use perl inside one of those blocks.
>=20
>=20
> Lars

--===============7116462354774740982==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlZqbjdqQUFvSkVJQjU4UDl2a0FrSHVjY1AvM0tGa3BWVmJRN1ZsNUJLZUxGWmJLU3AK
bytDT3liLzc4YlQ3eFR1cmtBRzlGY2RnbUJ0Q2dvQ0RRUldsc1o2R2Z3bFJzbHVPMHZpTHp0TTAr
K2k4ZWlwQQpDeDNwTjZmMnRFRGlEbnlyS3BwdERtaCtkOEc2UXZhSnAzQ0lLWnRpSEhSTlF2WG5G
NEVNMDRDaDF2R1NLdWd4CitkcWd0d1p1L2FQQWNsTHdqeGlOSXhxaUVlU0lldFJ3ZEVPcVhndHlL
MUU3YUJReDZYVXJVMlhlVVRFZmR6disKbWkrZWRLbUVFd0k0N1J5QlpCbmRreFo2Z0tkOTlIQWgr
bE9pRzdsWnJOT1FMa2NaSmg0aG5jb1cvcC9Dd0lwQQo5RUM2dUttR0dGbGlXb2xNUkxqbTlrV3ho
NnM5ZTNQUUJyVGtPTGswM2VxTXRZRGFCU0dOTlhuclBMWlF3cThlClF1QzNQVTNzUzM1c3FGTk5I
andJUFNXekRCOE1vRTdJY3k2cm0rV29PSFAwTXV4SGZBTTdVUmVuWVdkYWcvZWsKSDVYaVdrN0F4
RmYxbElZR1hrOGdwQ0ZKdFpIcENoYXJXRzdMamd4STFKVnBaeXRqeVRjUGNMRTFLellNRkFaTwp3
N1BhVXNIdkZ6Y0M0Q1BCL0M2NDRFSy9Rc3k3ckRWWS8reE5HSVc5S09Vb0lhdVRBV25ockUxSXRH
dW45dnVMCkl4QmFPa1dkRHAyZldzZ0FYS2NwN1c0alc5QWg5UUZtL3dxNjg2ZDZRSTQ4OGJNSzFu
aTdhMU50eUplUzVzdWoKbmUwQWkyL1kybElQYitWeDFTM3J2Q1NMOTR5ZzI5aytDaVJuN2dDOGov
d21ObEFMcEhZZnNlZ1NMaFFRMEJDWQpuUjRac1VlVkpkTEd3c29kVDE3Swo9aUpVdQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============7116462354774740982==--