From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Update to 008. Date: Sun, 09 Aug 2015 19:24:32 +0100 Message-ID: <1439144672.2264.5.camel@ipfire.org> In-Reply-To: <1439143778-2506-1-git-send-email-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1655200836416911161==" List-Id: --===============1655200836416911161== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hello Stefan, this looks good except one small thing below. On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote: > Update to the latest version of ddns - including a lot of upstream > patches, > with various improvements and new providers, systemd support and > generate the manpages. > > Signed-off-by: Stefan Schantl > --- > ddns/ddns.nm | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/ddns/ddns.nm b/ddns/ddns.nm > index cf5f94f..2fc4612 100644 > --- a/ddns/ddns.nm > +++ b/ddns/ddns.nm > @@ -4,7 +4,7 @@ > #################################################################### > ########### > > name = ddns > -version = 005 > +version = 008 > release = 1 > arch = noarch > > @@ -25,14 +25,18 @@ build > requires > autoconf > automake > + docbook-xsl > gettext-devel > intltool > m4 > + systemd-devel > end > > configure_options += \ > --prefix=%{prefix} \ > - --sysconfdir=%{sysconfdir} > + --sysconfdir=%{sysconfdir} \ > + --enable-manpages \ > + --with-systemd > > prepare_cmds > ./autogen.sh > @@ -53,5 +57,28 @@ packages > configfiles > %{sysconfdir}/%{name}/ddns.conf > end > + > + datafiles > + %{localestatedir}/%{name}.db > + end > + > + script postin > + systemctl daemon-reload >/dev/null 2>&1 || : > + systemctl enable ddns.timer >/dev/null 2>&1 > || : > + end > + > + script preun > + systemctl disable ddns.timer >/dev/null 2>&1 > || : > + systemctl stop ddns.service >/dev/null 2>&1 > || : > + end > + > + script postun > + systemctl daemon-reload >/dev/null 2>&1 || : > + end > + > + script postup > + systemctl daemon-reload >/dev/null 2>&1 || : > + systemctl enable ddns.timer >/dev/null 2>&1 I do not think that the timer should be enabled after an update. When a user chooses to disable ddns for some reason, the update should not re -enable this. > || : > + end > end > end Best, -Michael --===============1655200836416911161== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC Q2dBR0JRSlZ4NXJnQUFvSkVJQjU4UDl2a0FrSHk0c1Ard2NyL1VCL2t4N2lLc0JYM2pPb3gvcjEK MjNWYmNHRno2OHh3ZDFMb3dwWXhpZ3g5Q3ZuakZYYVZRVEFLekZHTDlYanZIU3J1U2RKR2Vqa0N3 d0Z5NG9TVgptRzNYVWRFWHN4b25JYkZIOXNBb0wyZWRWdXg5cUk0cG83dkovSncwaUZEK0gzeU5k ajU1bzJ3cldvdlE0ZTdGCm9lN0RXWUszQ0FLcjZ5MDRqanN5dVdaVVZQdDdtb2xwU09kR3NYNWlF SXFVQmt5WDdKbHI0d21yeFR3ZFpmN3gKc2lUWnFuODh3NnZ5NjhweHdSNGcrNjhRZWlWaWtnamto WXlSN2RIb3ArTXpQakE3WVREcG9XVExkSG5tWEJBTgpZTmN2YVI2L3VzcnJKM0lOVTBOU0lOek1L dFN6ZTliWjVYeUE0TmtZaFNPWmo4dzlPT21yem8yOUJabW5jSG1hCmRybXI0NFNmbXB4MFdCLzk4 WHVxZXJmVDNxVG9uNGlPQ0dxZnJTa1JsREt3dHpiTGk1eGp6Zk1Lcnc2MVdEdGoKV25wRTNvbUNH anNnYTIwbldpc1ZjSjN6NVRZOUpJNXkyRzhEdm5VOGpMR2c4ZTMrajRhNXkvVWhmais3QitqZgox TTVPaVp0UjBMY09uU01pU3MvMGR5UncwT2dqNGxqSGJ1eFNlOFNNRXlQVzdFN2RNbnZMMFE5eXNy WVZadVVRCnpUNGllRVVocmExUGVkRmhIdzU2emZyeE8vSlo0cE4rNUtVR0Nybkx4VDd2QzZuNk53 bXBkUStLeFYrRjZDUEQKVjd5SUFVZXF3ZC9PbVVqSnJOeHV4d0RveVdnSUJENStEbUphbHYreUhB bmtGdGI5WVJNZ1VLL3h4azVSMUwzTQpvUEdHN1lJVVp5UDMrSDBObWVhWgo9dWdNSQotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============1655200836416911161==--