From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns: Update to 008.
Date: Sun, 09 Aug 2015 20:33:58 +0200
Message-ID: <1439145238.2302.4.camel@ipfire.org>
In-Reply-To: <1439144672.2264.5.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7321788484941221947=="
List-Id: <development.lists.ipfire.org>

--===============7321788484941221947==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hello Michael,

thanks for your feedback. My basic thought was to enable the timer for
those who already had installed an older version of ddns.

But your argument with a possible re-enable of the service after a user
has disabled it, is a very important one.

I will update the patch and drop those line from the postup scriptlet.

-Stefan
> Hello Stefan,
> 
> this looks good except one small thing below.
> 
> On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote:
> > Update to the latest version of ddns - including a lot of upstream 
> > patches,
> > with various improvements and new providers, systemd support and 
> > generate the manpages.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> >  ddns/ddns.nm | 31 +++++++++++++++++++++++++++++--
> >  1 file changed, 29 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ddns/ddns.nm b/ddns/ddns.nm
> > index cf5f94f..2fc4612 100644
> > --- a/ddns/ddns.nm
> > +++ b/ddns/ddns.nm
> > @@ -4,7 +4,7 @@
> >  ####################################################################
> > ###########
> >  
> >  name       = ddns
> > -version    = 005
> > +version    = 008
> >  release    = 1
> >  arch       = noarch
> >  
> > @@ -25,14 +25,18 @@ build
> >  	requires
> >  		autoconf
> >  		automake
> > +		docbook-xsl
> >  		gettext-devel
> >  		intltool
> >  		m4
> > +		systemd-devel
> >  	end
> >  
> >  	configure_options += \
> >  		--prefix=%{prefix} \
> > -		--sysconfdir=%{sysconfdir}
> > +		--sysconfdir=%{sysconfdir} \
> > +		--enable-manpages \
> > +		--with-systemd
> >  
> >  	prepare_cmds
> >  		./autogen.sh
> > @@ -53,5 +57,28 @@ packages
> >  		configfiles
> >  			%{sysconfdir}/%{name}/ddns.conf
> >  		end
> > +
> > +		datafiles
> > +			%{localestatedir}/%{name}.db
> > +		end
> > +
> > +		script postin
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +			systemctl enable ddns.timer >/dev/null 2>&1 
> > || :
> > +		end
> > +
> > +		script preun
> > +			systemctl disable ddns.timer >/dev/null 2>&1 
> > || :
> > +			systemctl stop ddns.service >/dev/null 2>&1 
> > || :
> > +		end
> > +
> > +		script postun
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +		end
> > +
> > +		script postup
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +			systemctl enable ddns.timer >/dev/null 2>&1 
> 
> 
> I do not think that the timer should be enabled after an update. When a
> user chooses to disable ddns for some reason, the update should not re
> -enable this.
> 
> > || :
> > +		end
> >  	end
> >  end
> 
> Best,
> -Michael


--===============7321788484941221947==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlZ4NTBXQUFvSkVFN1hUaFdQazdMZUVaNFAvMmUzbWViT2I5c3hTMHZhVXFKaWRSUFkK
ZHBCdExtQnhsM1VQbWFHNWNpbWthRlFTTGRsRVQ4V3BWSjN1RXhHRURaWFpndXh1VGc4blNORnc5
N0JtRWF3WApPYm9WRGxIbGtCaERtZ3pKaVJUQW03MjlSOHRwNUxVU29MU1NJVjhBQmo3Q0RKVEFy
b2RXL1FHUVIvVDZFZVQ5CnNvQjJVRURhYlM3Z05VQ1psMFJKOTBGOHBYUG51b2E1QXpINUFRWk1G
U1V4cVdnL0tqby9naitYTkptUG9sVG0KMHZVbGEwcG1BMjJqOHY0NEVLaEN5a2xYbkJBMnZBSW0w
T2tOdkh3eFgyYk1HR2VKN3EzUkpHVG9xcUs1YTFZNgp3YnlsZDI1UWpEb2tHS0RDd1RDaGJSWm1i
djdtQ1ZxSTZrVVRoSlJJUnp1WWxtaDhBeFlwbmMvWDBwekEzMnpyCjh4azRHTnppTWZJUEszK0FC
U3MyYzdGQ3lmNVJFZmo5MW5wSUNwMnVCZ2xVbmtXWlRoM3NZMjcvbzM0NmtySmUKZEl3eVpsUm8z
S0VBZ21kNEpGZGpDYnR3MHBnblovTGdNTThOV2UvZjh0ZUNGQ1JsMzEwUFhVSnRxVm0vZzFITgpR
UnlaMHVyQUxEdlFaakJCNnhxZkJsRHV0YmFpb3lLN2I4MCtRanN4Qk1aUlVDQ2VvRGQ5S1VVWmJm
Z0dQQVNtCkRaTTMyTXZiSHhzeTgycE4rbUE1aHkyVkc0QkhGWW40Uk9aRlZKRWRqREY4RldQR1A0
RllaSVhURFdTNzZlUHYKeG1iNDJ2cGpiYWl1VDh3RlA2dU8wSkYzbXRmUm8yekVYb1VRVnBZOWIy
NlRNNDdiM2hjM3Z3bzgxNTB2TWZPdgo2NG1BdHJja0k2MEFsT3ZJbXJ3Ngo9QVpGdQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============7321788484941221947==--