From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Update to 008. Date: Sun, 09 Aug 2015 19:35:17 +0100 Message-ID: <1439145317.2264.6.camel@ipfire.org> In-Reply-To: <1439145238.2302.4.camel@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1671016251204996455==" List-Id: --===============1671016251204996455== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Sun, 2015-08-09 at 20:33 +0200, Stefan Schantl wrote: > Hello Michael, > > thanks for your feedback. My basic thought was to enable the timer > for > those who already had installed an older version of ddns. These are lost then :) They could still run "pakfire reinstall ddns" and that will reset that at any time. > But your argument with a possible re-enable of the service after a > user > has disabled it, is a very important one. > > I will update the patch and drop those line from the postup > scriptlet. Okay. > > -Stefan > > Hello Stefan, > > > > this looks good except one small thing below. > > > > On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote: > > > Update to the latest version of ddns - including a lot of > > > upstream > > > patches, > > > with various improvements and new providers, systemd support and > > > generate the manpages. > > > > > > Signed-off-by: Stefan Schantl > > > --- > > > ddns/ddns.nm | 31 +++++++++++++++++++++++++++++-- > > > 1 file changed, 29 insertions(+), 2 deletions(-) > > > > > > diff --git a/ddns/ddns.nm b/ddns/ddns.nm > > > index cf5f94f..2fc4612 100644 > > > --- a/ddns/ddns.nm > > > +++ b/ddns/ddns.nm > > > @@ -4,7 +4,7 @@ > > > ################################################################ > > > #### > > > ########### > > > > > > name = ddns > > > -version = 005 > > > +version = 008 > > > release = 1 > > > arch = noarch > > > > > > @@ -25,14 +25,18 @@ build > > > requires > > > autoconf > > > automake > > > + docbook-xsl > > > gettext-devel > > > intltool > > > m4 > > > + systemd-devel > > > end > > > > > > configure_options += \ > > > --prefix=%{prefix} \ > > > - --sysconfdir=%{sysconfdir} > > > + --sysconfdir=%{sysconfdir} \ > > > + --enable-manpages \ > > > + --with-systemd > > > > > > prepare_cmds > > > ./autogen.sh > > > @@ -53,5 +57,28 @@ packages > > > configfiles > > > %{sysconfdir}/%{name}/ddns.conf > > > end > > > + > > > + datafiles > > > + %{localestatedir}/%{name}.db > > > + end > > > + > > > + script postin > > > + systemctl daemon-reload >/dev/null 2>&1 > > > || : > > > + systemctl enable ddns.timer >/dev/null > > > 2>&1 > > > > > : > > > + end > > > + > > > + script preun > > > + systemctl disable ddns.timer >/dev/null > > > 2>&1 > > > > > : > > > + systemctl stop ddns.service >/dev/null > > > 2>&1 > > > > > : > > > + end > > > + > > > + script postun > > > + systemctl daemon-reload >/dev/null 2>&1 > > > || : > > > + end > > > + > > > + script postup > > > + systemctl daemon-reload >/dev/null 2>&1 > > > || : > > > + systemctl enable ddns.timer >/dev/null > > > 2>&1 > > > > > > I do not think that the timer should be enabled after an update. > > When a > > user chooses to disable ddns for some reason, the update should not > > re > > -enable this. > > > > > > > : > > > + end > > > end > > > end > > > > Best, > > -Michael > --===============1671016251204996455== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC Q2dBR0JRSlZ4NTFsQUFvSkVJQjU4UDl2a0FrSHlSRVFBS1QraDc5TVVObThhakR2R0g3RVlvYWYK d2ZLd284T0RDQ21lUmtCOWgrZFZQemExdnE2dUp5Tm5vcXUrTzBIOXpvR3ZSMmZtNG10bmpDM0po UnNNc1RaRgpsQUsrbi9FTDd1OE5vSnFNUk10QndsNytvRnBmS25DMFo0TUs5SHBSSEtRZW52Y3RB UmpEQmNKUzMxTGR5a1RLCm53dWQzZ25vZjhYVVhJdmZmOHRkUzQyNTg4bmpHUktHTG44a0piVG9y ald4Sm1UaGdxZWxuTktEQzVCM01kNHEKc1lIa2QzT1IvZFhiSUJhSytTdmdiWGpYSXR0OGtvMGNB M1Vxc0pKUjhERGoycjByN2UweUxBZmhuYWM0OHdaKwpmZzRNaUtlRFowdjRPMDY5Ykg2VUh0WVBq QWFCODhlbk1sZUI5ck11dHE1Y2NJOGVOemRwMnh1UVZBOEtWaTVHCkl6R0lQa3ZJNHVBS1FSTXg3 Z0VmaFBhRkVLYTdiNjY0dzNVblEzT0MrOVRGWGxmdU9vWE5UVGF1QlNsQXh4RXQKa1o2ZGhSVC8z aGdsZ2JaZ3JDWW9tSFJ1MTNyVm1pV2hhUHRyRzJldE5PYWhGaWtJZU4zTkR4Z20rNTFxTU91aQpE ZEp0VnQ4aWJuVE9rRGI5Vm1sS2JBdHRCKzhWKzRJRzgzdS9COEtCeVg4V0xndGt2TTVPTTBrR0xn S25lUUNVCldHYUpQR2kxMXBiemZuSWZ0NWpNSmsrMlJ5QU1VZFNzOHlBenJpTnA0OHZ6TFh5ejUy REdTUHhRUGRSVUZpRkkKNWFDblNzZkE3OHlSbUxkY1l1K3FRMWc3bng5OTliRDRpdmlPeWlrSWlE ZEpmRi9tYnpqZUZ3ME9GSjhrY3pTRwpZaVpMZ0QvbkJ0aXYvS3pUdUR3Lwo9amVvaAotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============1671016251204996455==--