[PATCH] ddns: Update to 008.

[PATCH] ddns: Update to 008.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Update to the latest version of ddns - including a lot of upstream patches,
with various improvements and new providers, systemd support and generate the manpages.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 ddns/ddns.nm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ddns/ddns.nm b/ddns/ddns.nm
index cf5f94f..b7a00d4 100644
--- a/ddns/ddns.nm
+++ b/ddns/ddns.nm
@@ -4,7 +4,7 @@
 ###############################################################################
 
 name       = ddns
-version    = 005
+version    = 008
 release    = 1
 arch       = noarch
 
@@ -25,14 +25,18 @@ build
 	requires
 		autoconf
 		automake
+		docbook-xsl
 		gettext-devel
 		intltool
 		m4
+		systemd-devel
 	end
 
 	configure_options += \
 		--prefix=%{prefix} \
-		--sysconfdir=%{sysconfdir}
+		--sysconfdir=%{sysconfdir} \
+		--enable-manpages \
+		--with-systemd
 
 	prepare_cmds
 		./autogen.sh
-- 
2.1.0

Re: [PATCH] ddns: Update to 008.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Hello,

if you add support for systemd, shouldn't there be some scriptlets be
called and enable/disable the service?

-Michael

On Thu, 2015-07-09 at 22:10 +0200, Stefan Schantl wrote:
> Update to the latest version of ddns - including a lot of upstream 
> patches,
> with various improvements and new providers, systemd support and 
> generate the manpages.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  ddns/ddns.nm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/ddns/ddns.nm b/ddns/ddns.nm
> index cf5f94f..b7a00d4 100644
> --- a/ddns/ddns.nm
> +++ b/ddns/ddns.nm
> @@ -4,7 +4,7 @@
>  ####################################################################
> ###########
>  
>  name       = ddns
> -version    = 005
> +version    = 008
>  release    = 1
>  arch       = noarch
>  
> @@ -25,14 +25,18 @@ build
>  	requires
>  		autoconf
>  		automake
> +		docbook-xsl
>  		gettext-devel
>  		intltool
>  		m4
> +		systemd-devel
>  	end
>  
>  	configure_options += \
>  		--prefix=%{prefix} \
> -		--sysconfdir=%{sysconfdir}
> +		--sysconfdir=%{sysconfdir} \
> +		--enable-manpages \
> +		--with-systemd
>  
>  	prepare_cmds
>  		./autogen.sh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] ddns: Update to 008.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

Update to the latest version of ddns - including a lot of upstream patches,
with various improvements and new providers, systemd support and generate the manpages.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 ddns/ddns.nm | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/ddns/ddns.nm b/ddns/ddns.nm
index cf5f94f..2fc4612 100644
--- a/ddns/ddns.nm
+++ b/ddns/ddns.nm
@@ -4,7 +4,7 @@
 ###############################################################################
 
 name       = ddns
-version    = 005
+version    = 008
 release    = 1
 arch       = noarch
 
@@ -25,14 +25,18 @@ build
 	requires
 		autoconf
 		automake
+		docbook-xsl
 		gettext-devel
 		intltool
 		m4
+		systemd-devel
 	end
 
 	configure_options += \
 		--prefix=%{prefix} \
-		--sysconfdir=%{sysconfdir}
+		--sysconfdir=%{sysconfdir} \
+		--enable-manpages \
+		--with-systemd
 
 	prepare_cmds
 		./autogen.sh
@@ -53,5 +57,28 @@ packages
 		configfiles
 			%{sysconfdir}/%{name}/ddns.conf
 		end
+
+		datafiles
+			%{localestatedir}/%{name}.db
+		end
+
+		script postin
+			systemctl daemon-reload >/dev/null 2>&1 || :
+			systemctl enable ddns.timer >/dev/null 2>&1 || :
+		end
+
+		script preun
+			systemctl disable ddns.timer >/dev/null 2>&1 || :
+			systemctl stop ddns.service >/dev/null 2>&1 || :
+		end
+
+		script postun
+			systemctl daemon-reload >/dev/null 2>&1 || :
+		end
+
+		script postup
+			systemctl daemon-reload >/dev/null 2>&1 || :
+			systemctl enable ddns.timer >/dev/null 2>&1 || :
+		end
 	end
 end
-- 
2.1.0

Re: [PATCH] ddns: Update to 008.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

Hello Stefan,

this looks good except one small thing below.

On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote:
> Update to the latest version of ddns - including a lot of upstream 
> patches,
> with various improvements and new providers, systemd support and 
> generate the manpages.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  ddns/ddns.nm | 31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 
> diff --git a/ddns/ddns.nm b/ddns/ddns.nm
> index cf5f94f..2fc4612 100644
> --- a/ddns/ddns.nm
> +++ b/ddns/ddns.nm
> @@ -4,7 +4,7 @@
>  ####################################################################
> ###########
>  
>  name       = ddns
> -version    = 005
> +version    = 008
>  release    = 1
>  arch       = noarch
>  
> @@ -25,14 +25,18 @@ build
>  	requires
>  		autoconf
>  		automake
> +		docbook-xsl
>  		gettext-devel
>  		intltool
>  		m4
> +		systemd-devel
>  	end
>  
>  	configure_options += \
>  		--prefix=%{prefix} \
> -		--sysconfdir=%{sysconfdir}
> +		--sysconfdir=%{sysconfdir} \
> +		--enable-manpages \
> +		--with-systemd
>  
>  	prepare_cmds
>  		./autogen.sh
> @@ -53,5 +57,28 @@ packages
>  		configfiles
>  			%{sysconfdir}/%{name}/ddns.conf
>  		end
> +
> +		datafiles
> +			%{localestatedir}/%{name}.db
> +		end
> +
> +		script postin
> +			systemctl daemon-reload >/dev/null 2>&1 || :
> +			systemctl enable ddns.timer >/dev/null 2>&1 
> || :
> +		end
> +
> +		script preun
> +			systemctl disable ddns.timer >/dev/null 2>&1 
> || :
> +			systemctl stop ddns.service >/dev/null 2>&1 
> || :
> +		end
> +
> +		script postun
> +			systemctl daemon-reload >/dev/null 2>&1 || :
> +		end
> +
> +		script postup
> +			systemctl daemon-reload >/dev/null 2>&1 || :
> +			systemctl enable ddns.timer >/dev/null 2>&1 


I do not think that the timer should be enabled after an update. When a
user chooses to disable ddns for some reason, the update should not re
-enable this.

> || :
> +		end
>  	end
>  end

Best,
-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ddns: Update to 008.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 2549 bytes --]

Hello Michael,

thanks for your feedback. My basic thought was to enable the timer for
those who already had installed an older version of ddns.

But your argument with a possible re-enable of the service after a user
has disabled it, is a very important one.

I will update the patch and drop those line from the postup scriptlet.

-Stefan
> Hello Stefan,
> 
> this looks good except one small thing below.
> 
> On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote:
> > Update to the latest version of ddns - including a lot of upstream 
> > patches,
> > with various improvements and new providers, systemd support and 
> > generate the manpages.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> >  ddns/ddns.nm | 31 +++++++++++++++++++++++++++++--
> >  1 file changed, 29 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ddns/ddns.nm b/ddns/ddns.nm
> > index cf5f94f..2fc4612 100644
> > --- a/ddns/ddns.nm
> > +++ b/ddns/ddns.nm
> > @@ -4,7 +4,7 @@
> >  ####################################################################
> > ###########
> >  
> >  name       = ddns
> > -version    = 005
> > +version    = 008
> >  release    = 1
> >  arch       = noarch
> >  
> > @@ -25,14 +25,18 @@ build
> >  	requires
> >  		autoconf
> >  		automake
> > +		docbook-xsl
> >  		gettext-devel
> >  		intltool
> >  		m4
> > +		systemd-devel
> >  	end
> >  
> >  	configure_options += \
> >  		--prefix=%{prefix} \
> > -		--sysconfdir=%{sysconfdir}
> > +		--sysconfdir=%{sysconfdir} \
> > +		--enable-manpages \
> > +		--with-systemd
> >  
> >  	prepare_cmds
> >  		./autogen.sh
> > @@ -53,5 +57,28 @@ packages
> >  		configfiles
> >  			%{sysconfdir}/%{name}/ddns.conf
> >  		end
> > +
> > +		datafiles
> > +			%{localestatedir}/%{name}.db
> > +		end
> > +
> > +		script postin
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +			systemctl enable ddns.timer >/dev/null 2>&1 
> > || :
> > +		end
> > +
> > +		script preun
> > +			systemctl disable ddns.timer >/dev/null 2>&1 
> > || :
> > +			systemctl stop ddns.service >/dev/null 2>&1 
> > || :
> > +		end
> > +
> > +		script postun
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +		end
> > +
> > +		script postup
> > +			systemctl daemon-reload >/dev/null 2>&1 || :
> > +			systemctl enable ddns.timer >/dev/null 2>&1 
> 
> 
> I do not think that the timer should be enabled after an update. When a
> user chooses to disable ddns for some reason, the update should not re
> -enable this.
> 
> > || :
> > +		end
> >  	end
> >  end
> 
> Best,
> -Michael


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ddns: Update to 008.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]

On Sun, 2015-08-09 at 20:33 +0200, Stefan Schantl wrote:
> Hello Michael,
> 
> thanks for your feedback. My basic thought was to enable the timer 
> for
> those who already had installed an older version of ddns.

These are lost then :)

They could still run "pakfire reinstall ddns" and that will reset that
at any time.

> But your argument with a possible re-enable of the service after a 
> user
> has disabled it, is a very important one.
> 
> I will update the patch and drop those line from the postup 
> scriptlet.

Okay.

> 
> -Stefan
> > Hello Stefan,
> > 
> > this looks good except one small thing below.
> > 
> > On Sun, 2015-08-09 at 20:09 +0200, Stefan Schantl wrote:
> > > Update to the latest version of ddns - including a lot of 
> > > upstream 
> > > patches,
> > > with various improvements and new providers, systemd support and 
> > > generate the manpages.
> > > 
> > > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > > ---
> > >  ddns/ddns.nm | 31 +++++++++++++++++++++++++++++--
> > >  1 file changed, 29 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/ddns/ddns.nm b/ddns/ddns.nm
> > > index cf5f94f..2fc4612 100644
> > > --- a/ddns/ddns.nm
> > > +++ b/ddns/ddns.nm
> > > @@ -4,7 +4,7 @@
> > >  ################################################################
> > > ####
> > > ###########
> > >  
> > >  name       = ddns
> > > -version    = 005
> > > +version    = 008
> > >  release    = 1
> > >  arch       = noarch
> > >  
> > > @@ -25,14 +25,18 @@ build
> > >  	requires
> > >  		autoconf
> > >  		automake
> > > +		docbook-xsl
> > >  		gettext-devel
> > >  		intltool
> > >  		m4
> > > +		systemd-devel
> > >  	end
> > >  
> > >  	configure_options += \
> > >  		--prefix=%{prefix} \
> > > -		--sysconfdir=%{sysconfdir}
> > > +		--sysconfdir=%{sysconfdir} \
> > > +		--enable-manpages \
> > > +		--with-systemd
> > >  
> > >  	prepare_cmds
> > >  		./autogen.sh
> > > @@ -53,5 +57,28 @@ packages
> > >  		configfiles
> > >  			%{sysconfdir}/%{name}/ddns.conf
> > >  		end
> > > +
> > > +		datafiles
> > > +			%{localestatedir}/%{name}.db
> > > +		end
> > > +
> > > +		script postin
> > > +			systemctl daemon-reload >/dev/null 2>&1 
> > > || :
> > > +			systemctl enable ddns.timer >/dev/null 
> > > 2>&1 
> > > > > :
> > > +		end
> > > +
> > > +		script preun
> > > +			systemctl disable ddns.timer >/dev/null 
> > > 2>&1 
> > > > > :
> > > +			systemctl stop ddns.service >/dev/null 
> > > 2>&1 
> > > > > :
> > > +		end
> > > +
> > > +		script postun
> > > +			systemctl daemon-reload >/dev/null 2>&1 
> > > || :
> > > +		end
> > > +
> > > +		script postup
> > > +			systemctl daemon-reload >/dev/null 2>&1 
> > > || :
> > > +			systemctl enable ddns.timer >/dev/null 
> > > 2>&1 
> > 
> > 
> > I do not think that the timer should be enabled after an update. 
> > When a
> > user chooses to disable ddns for some reason, the update should not 
> > re
> > -enable this.
> > 
> > > > > :
> > > +		end
> > >  	end
> > >  end
> > 
> > Best,
> > -Michael
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] ddns: Update to 008.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Update to the latest version of ddns - including a lot of upstream patches,
with various improvements and new providers, systemd support and generate the manpages.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 ddns/ddns.nm | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/ddns/ddns.nm b/ddns/ddns.nm
index cf5f94f..5386ce7 100644
--- a/ddns/ddns.nm
+++ b/ddns/ddns.nm
@@ -4,7 +4,7 @@
 ###############################################################################
 
 name       = ddns
-version    = 005
+version    = 008
 release    = 1
 arch       = noarch
 
@@ -25,14 +25,18 @@ build
 	requires
 		autoconf
 		automake
+		docbook-xsl
 		gettext-devel
 		intltool
 		m4
+		systemd-devel
 	end
 
 	configure_options += \
 		--prefix=%{prefix} \
-		--sysconfdir=%{sysconfdir}
+		--sysconfdir=%{sysconfdir} \
+		--enable-manpages \
+		--with-systemd
 
 	prepare_cmds
 		./autogen.sh
@@ -53,5 +57,27 @@ packages
 		configfiles
 			%{sysconfdir}/%{name}/ddns.conf
 		end
+
+		datafiles
+			%{localestatedir}/%{name}.db
+		end
+
+		script postin
+			systemctl daemon-reload >/dev/null 2>&1 || :
+			systemctl enable ddns.timer >/dev/null 2>&1 || :
+		end
+
+		script preun
+			systemctl disable ddns.timer >/dev/null 2>&1 || :
+			systemctl stop ddns.service >/dev/null 2>&1 || :
+		end
+
+		script postun
+			systemctl daemon-reload >/dev/null 2>&1 || :
+		end
+
+		script postup
+			systemctl daemon-reload >/dev/null 2>&1 || :
+		end
 	end
 end
-- 
2.1.0