From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] actual system time and timezone info-bar to ipfire theme Date: Thu, 13 Aug 2015 17:33:16 +0100 Message-ID: <1439483596.2264.60.camel@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4308551941638477965==" List-Id: --===============4308551941638477965== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hello, On Thu, 2015-08-13 at 15:00 +0200, Larsen wrote: > Hi Kim, > > I have been using this for not so long either, but I can tell you > that > patches should be sent inline (no attachment) and you have to disable Indeed, we can comment on an inline patch much easier. Patchwork however parsed the attachment correctly, so it is okay for this time. > line-wrap in your mail client. > Some examples: http://patchwork.ipfire.org/project/ipfire/list/ On the thing itself: I saw the conversation on the IPFire forum and must say that I do not really get why all this information is needed on the web user interface. So I would like to discuss this first before looking closely at the patch. Time: I get that this is a good information to know just to check if the clock of the system is running correctly. If the timezone needs to be included if it is local time is debatable. Load: I do not really understand why this is an important information that should be on every single page of the web user interface. Most users do not even really understand the meaning of these values and often worry about numbers above a certain value they are used to. I think this could be as well below the load graph. Logged in users and uptime: There is no point in this. I wonder why you find this is important. So this information is automatically updated by Javascript every other second. This will always return a wrong time because there is obviously lots of latency on the network. What is wrong with just embedding the time when the page was generated? I just would like to hear your objective or opinion on this. Best, -Michael > > hth, > Lars > > > On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all > wrote: > > > Hi all, > > > > this is my first time using this mailing-list thing, > > so hopefully I do everything according to your CoC. > > > > [PATCH] > > add actual system time and timezone info-bar to ipfire theme. > > position can be configured in GUI user-settings, default is off. > > > > future reference, German discussion in forum: > > http://forum.ipfire.org/viewtopic.php?f=17&t=12177 > > > > attached is a patch against the actual next branch > > > > br, > > Kim --===============4308551941638477965== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC Q2dBR0JRSlZ6TWJNQUFvSkVJQjU4UDl2a0FrSFB1WVFBS2EreUxuNStVeFd0V05XcmJnQlo5MFkK eTlObWx6aE1VNTJlVVdpeXJObkJQcUEzTEVXdlBKQWZwSjhUakNyU2FhSlZoYWczMGM3YmVXaHlE N2RqdnVyaQpNU2tIZUFDOWZESHVERG9LR3hSa05HZmRFR09hdVRua29zTStrT3FlaHQyM0sycEZ1 MmJtTkdZbHFMdmlicXV1Cmk3cXowRWFlOU40d09zZTdiTGdOUC8zRTFabWRyb3pSVDRRdGMrY1VT RFBlN3A2N1gxNThwblB0dWJYQ01Fd24KZkNMclFqbWZid2g4SmorWVRJZUpRSkR6ZUR2MkhiMkc5 cDY3Q0pNVzhCYjRUcmszV0h6QVRwT0p3VXdETjJJVgp3S1dwVGJGSi93TFRDZUJpdGZqbkJETm56 cmFXektqSXI1VlhFQXNZSWIrbThhNlB0S1g2eHdIZjhiTTZUZ0lGCm0yZ3BwYVhqMWJMVE1FYWw3 WE9rUWIrV1IwNjJBSnRDQ1d2UzkzZVRYcXloZEJmdEdGRVRpMjM1eU5ONjBsSWcKTXNabkxMY3VR Smw2ODNwK1I4VVpaT1JPQW15di83Y1RCalNQTllJR3pXUkxVS0cxOU1XQnFsSXVuUXcrcnNvWQpI bXNDbWpiVUxsM0pNTXNodHhwTjMwNFNycDE0U3dLUGptR3hzMmszSHRQeGsxREhKa3VEbHBrNmt0 M3RFV3pjCk9pcGJWcVp3bDZsSFlZRWk3MDA0MFk3NWtnYzY5NFdkcldOQjVxVkZNRWJEbVMxOTRj anNHRXJwMzFHTS9Pb1cKN0ZKTEFjWkFOaDc2aHRUcGdNOW1mU1B0MEN6SnRxcnYzZXNWN1NEcjFZ L01iM3N1QmZMOTkxMUQzejczSDZJVQpUbXh0ZDdNbTZOZUVuZnA2TDRmcAo9SmFIVwotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============4308551941638477965==--