public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Fixed some typos in network-functions.pl
Date: Sun, 20 Sep 2015 12:58:10 +0100	[thread overview]
Message-ID: <1442750290.4141.107.camel@ipfire.org> (raw)
In-Reply-To: <1442749777-19839-1-git-send-email-matthias.fischer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]

Hi,

this is perfect British English:
  https://en.wiktionary.org/wiki/recognise

I do not see any need to change this to American English, since I am
using BE most of the time and it is mixed everywhere any way.

Best,
-Michael

On Sun, 2015-09-20 at 13:49 +0200, Matthias Fischer wrote:
> "recognised" => "recognized"
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  config/cfgroot/network-functions.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/config/cfgroot/network-functions.pl
> b/config/cfgroot/network-functions.pl
> index cb4ca3d..c39b6d9 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -311,10 +311,10 @@ sub testsuite() {
>  	my $address2 = &bin2ip($address1);
>  	assert($address2 eq "8.8.8.8");
>  
> -	# Check if valid IP addresses are correctly recognised.
> +	# Check if valid IP addresses are correctly recognized.
>  	foreach my $address ("1.2.3.4", "192.168.180.1",
> "127.0.0.1") {
>  		if (!&check_ip_address($address)) {
> -			print "$address is not correctly recognised
> as a valid IP address!\n";
> +			print "$address is not correctly recognized
> as a valid IP address!\n";
>  			exit 1;
>  		};
>  	}
> @@ -322,7 +322,7 @@ sub testsuite() {
>  	# Check if invalid IP addresses are correctly found.
>  	foreach my $address ("456.2.3.4", "192.768.180.1", "127.1",
> "1", "a.b.c.d", "1.2.3.4.5", "1.2.3.4/12") {
>  		if (&check_ip_address($address)) {
> -			print "$address is recognised as a valid IP
> address!\n";
> +			print "$address is recognized as a valid IP
> address!\n";
>  			exit 1;
>  		};
>  	}

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-20 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 11:49 Matthias Fischer
2015-09-20 11:58 ` Michael Tremer [this message]
2015-09-20 12:44   ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442750290.4141.107.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox