From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG10806: fix wrong customhostgroupcheck
Date: Fri, 16 Oct 2015 22:14:54 +0100
Message-ID: <1445030094.18375.108.camel@ipfire.org>
In-Reply-To: <562139D4.5070903@oab.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1568942828974875759=="
List-Id: <development.lists.ipfire.org>

--===============1568942828974875759==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Okay, could you please include descriptions like these in the commit
messages? Please resend this patch, too.

-Michael

On Fri, 2015-10-16 at 19:54 +0200, Alexander Marx wrote:
> 
> 
> Am 16.10.2015 um 17:51 schrieb Michael Tremer:
> > What does this patch do?
> I think it should fix a design error. As you can see, the function is
> only executed, if a hostgroup is used as target.
> within the function, we read the hasharray of all defined hostgroups.
> unfortunately it checks not only the TARGET hostgroup but the source
> hostgroup as well if it contains a mac address. This leads to an
> error, if a hostgroup is used as source and contains a mac address.
> so with this patch i adapted the if construct only to raise the
> error, if a mac address is present in the TARGET hostgroup.
> 
> > http://wiki.ipfire.org/devel/git/commit-messages
> > 
> > On Fri, 2015-10-16 at 09:13 +0200, Alexander Marx wrote:
> > >  Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> > > ---
> > >  html/cgi-bin/firewall.cgi | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/html/cgi-bin/firewall.cgi b/html/cgi
> > > -bin/firewall.cgi
> > > index c207ec7..682c285 100644
> > > --- a/html/cgi-bin/firewall.cgi
> > > +++ b/html/cgi-bin/firewall.cgi
> > > @@ -597,7 +597,7 @@ sub checktarget
> > >  		&General::readhasharray("$confighost",
> > > \%customhost);
> > >  		foreach my $grpkey (sort keys %customgrp){
> > >  			foreach my $hostkey (sort keys
> > > %customhost){
> > > -				if ($customgrp{$grpkey}[2] eq
> > > $customhost{$hostkey}[0] && $customhost{$hostkey}[1] eq 'mac'){
> > > +				if ($customgrp{$grpkey}[2] eq
> > > $customhost{$hostkey}[0] && $customgrp{$grpkey}[2] eq
> > > $fwdfwsettings{$fwdfwsettings{'grp2'}} &&
> > > $customhost{$hostkey}[1] eq
> > > 'mac'){
> > >  					$hint=$Lang::tr{'fwdfw
> > > hint
> > > mac'};
> > >  					return $hint;
> > >  				}

--===============1568942828974875759==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC
Q2dBR0JRSldJV2pPQUFvSkVJQjU4UDl2a0FrSGQ2Z1AvMkE5dmIxQ1FaQkRDdmR0RDlrNTl6ZW8K
Mm5ITlJGUGF6Q2YvM1dKczRmYkpXQ051aUhIclJXd0Fqbm80WmdKcTJXOHUyUHo3czNrT1REL0pu
Q2dHOFdZUApRRXFjRmFMYUViWGd4ZFJVTmZORmVYTjhtbnl2c3FPcXhuTGNoRUxmZTZvRDRmVkNi
ZEtzR2VzdURVcFJLQUJ6CjV4WmNlSDNsbkp1TEFIY0pRUmNEK3hsTEt5R25yR3ZJbytoSUlXalpr
ZmlqNGEzbXN5Szdna2kwZGNUQktUTnkKSmF3ZnUrSnFKSllDdEI5WUZHbThLQnpyQjNkS1daeEp4
Q3QxdVJaeXVUcmxlbHZjd2xsQnd4VThDd1F1N0VSQgpTeU5QbEpKdnlUMElqOXlHc3daRncxT1Bx
YVJGNW9rdlI5N1RROXdtc0lxdzlhaTlGR0RjV1JxRnRicFVTMkJzClNmaXZwMUMxNWJwZHd1cksw
bmZZTk5CYWpvT1BMdDZRV3FOeC9xOWl1YnJKMmh4RUI1TUpZbEs2V2h0dDlMaWoKUkxMSEIwK212
aVk5VSt3TmRZYTI1VjFmNHpkVGxPQlFwREowdnJrVGIySlNDZjRHVkRpRFNQMVh2RWhrdVllagpF
bmpJZXBmQnpyMFZaK3doQjBUVFZ4V0IxTE13a2NCQXJiQjVsY3VFWElRajFJblFkUWxpUTBEbmJa
eERKa2N1Ck4zYkt2RWM2cEJUZmo5MlUxaXZpZTB4cjdlZDNyOXl2bHNkK2g2TVM3ZU9kVTlxTUpp
emE4cDhta0JaR21DRloKbjJvaThwbnpPa1VIVWdmR0xtTkYxT0xTK1Q4dUFzZ29mWEtwSk9Nc0k0
UUhOVGc1elVjb29NckY1d2ExRXhlcQo3aStrZkVXb0hxbW9pK0pTYys0Vwo9NzVJQQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1568942828974875759==--