From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] firewalllogcountry.dat: Do not show 'Details' button for
 unkonw location.
Date: Sun, 18 Oct 2015 13:23:32 +0200
Message-ID: <1445167412-3298-1-git-send-email-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8817049515268582089=="
List-Id: <development.lists.ipfire.org>

--===============8817049515268582089==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

The CGI offers the posibility to get more details for a certain locations
by clicking on a button.

This feature cannot be used for the category "unknown". To prevent users
from beeing confused about non show-able details, I added some code to hide
this button for this category.

Fixes #10726.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 html/cgi-bin/logs.cgi/firewalllogcountry.dat | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/html/cgi-bin/logs.cgi/firewalllogcountry.dat b/html/cgi-bin/logs=
.cgi/firewalllogcountry.dat
index 29c0842..f998a62 100644
--- a/html/cgi-bin/logs.cgi/firewalllogcountry.dat
+++ b/html/cgi-bin/logs.cgi/firewalllogcountry.dat
@@ -456,7 +456,17 @@ for($s=3D0;$s<$lines;$s++)
   $color++;
   print "<tr>";
=20
-  print "<td align=3D'center' $col><form method=3D'post' action=3D'showreque=
stfromcountry.dat'><input type=3D'hidden' name=3D'MONTH' value=3D'$cgiparams{=
'MONTH'}'> <input type=3D'hidden' name=3D'DAY' value=3D'$cgiparams{'DAY'}'> <=
input type=3D'hidden' name=3D'country' value=3D'$key[$s]'> <input type=3D'sub=
mit' value=3D'details'></form></td>";
+  print "<td align=3D'center' $col>";
+
+  # Dont show details button for "unknown" location.
+  if ($key[$s] ne 'unknown') {
+	print"<form method=3D'post' action=3D'showrequestfromcountry.dat'>";
+	print"<input type=3D'hidden' name=3D'MONTH' value=3D'$cgiparams{'MONTH'}'>";
+	print"<input type=3D'hidden' name=3D'DAY' value=3D'$cgiparams{'DAY'}'>";
+	print"<input type=3D'hidden' name=3D'country' value=3D'$key[$s]'>";
+	print"<input type=3D'submit' value=3D'details'></form>";
+  }
+
   if($key[$s] eq 'blue0' || $key[$s] eq 'green0' || $key[$s] eq 'orange0') {
       print "<td align=3D'center' $col>$key[$s]</td>";
   }
--=20
2.4.3


--===============8817049515268582089==--