From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] pppsetup.cgi: Fix site layout when no TYPE is specified
Date: Sun, 18 Oct 2015 14:25:50 +0200
Message-ID: <1445171150-4433-1-git-send-email-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7391887211367830192=="
List-Id: <development.lists.ipfire.org>

--===============7391887211367830192==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

There was an issue with false generated HTML code, in case
of an empty or unset $pppsettings{'TYPE'} variable which results
in a missplaced website footer.

This patch moves the code for closeing the table and the call of the
closebox() function to the correct place to prevent this display issue.

Fixes #10565.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 html/cgi-bin/pppsetup.cgi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index b3e8e6c..36d0ced 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -980,12 +980,14 @@ print <<END
         <td colspan=3D'2' width=3D'50%'>$Lang::tr{'legend'}:</td>
         <td colspan=3D'2' width=3D'50%'><img src=3D'/blob.gif' alt=3D'*' />&=
nbsp;$Lang::tr{'required field'}</td>
 </tr>
-</table>
 END
 ;
-&Header::closebox();
 }
=20
+print "</table>";
+
+&Header::closebox();
+
 print "</form>\n";
=20
 &Header::closebigbox();
--=20
2.4.3


--===============7391887211367830192==--