From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Bug in /srv/web/ipfire/cgi-bin/routing.cgi in Core 95
Date: Tue, 01 Dec 2015 22:31:48 +0000 [thread overview]
Message-ID: <1449009108.31655.32.camel@ipfire.org> (raw)
In-Reply-To: <565BE9D5.4050409@dailydata.net>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Hi Rod,
thanks for reporting this. This has actually already been found and
fixed here:
http://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=1574f25557d0f1bf9729d61dde9f44f1806d8ede
Please keep on sending patches like this. The best way would be to use
git to create these. More about that can be found here:
http://wiki.ipfire.org/devel/submit-patches
Best,
-Michael
On Mon, 2015-11-30 at 00:16 -0600, R. W. Rodolico wrote:
> Line 123 has one too many closing parenths. It currently reads:
> if (!&General::validipandmask($settings{'IP'}))){
> and it should read
> if (!&General::validipandmask($settings{'IP'})){
>
> (one less closing parentheses).
>
> Rod
>
> Attached is a diff. I did not know which parameters to give it, so
> gave
> it diff -Naur. If you tell me the correct ones, I'll use it in the
> future.
>
> Rod
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
parent reply other threads:[~2015-12-01 22:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <565BE9D5.4050409@dailydata.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449009108.31655.32.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox