From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Bug in /srv/web/ipfire/cgi-bin/routing.cgi in Core 95
Date: Tue, 01 Dec 2015 22:31:48 +0000
Message-ID: <1449009108.31655.32.camel@ipfire.org>
In-Reply-To: <565BE9D5.4050409@dailydata.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8401807780642973664=="
List-Id: <development.lists.ipfire.org>

--===============8401807780642973664==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Rod,

thanks for reporting this. This has actually already been found and
fixed here:

  http://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D1574f25557d0f1=
bf9729d61dde9f44f1806d8ede

Please keep on sending patches like this. The best way would be to use
git to create these. More about that can be found here:

  http://wiki.ipfire.org/devel/submit-patches

Best,
-Michael

On Mon, 2015-11-30 at 00:16 -0600, R. W. Rodolico wrote:
> Line 123 has one too many closing parenths. It currently reads:
> 	if (!&General::validipandmask($settings{'IP'}))){
> and it should read
> 	if (!&General::validipandmask($settings{'IP'})){
>=20
> (one less closing parentheses).
>=20
> Rod
>=20
> Attached is a diff. I did not know which parameters to give it, so
> gave
> it diff -Naur. If you tell me the correct ones, I'll use it in the
> future.
>=20
> Rod
>=20
>=20
>=20

--===============8401807780642973664==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC
Q2dBR0JRSldYaC9VQUFvSkVJQjU4UDl2a0FrSE0rVVAvUjRhQm11RVRmME55OHdXVW8xOWcvQisK
UWt0dVIrLzVxY2V5aGIvTWFyNEMwL2NRWFlJZFNvSkFsRXhUMFdrYjlsU2Z1N1RCOUdSbjFpa0Zq
Si9wTkRnLwpUV0NUdXJ4dGFlUklPdDlSQ3F5T3k5aXVGTVJVdXlxMXBmdnI0RHZSU1Nxc0kzSGUr
dDFiNithMy8yZm9tZmFuCm9LZ2lqVFpXd085WU0yeHlRSE9ZT1F6ZGU1S0tMSXNPcDNVbHNKZlox
K3p6NGpQdS9QSGVodWhPSGQvd25sS2wKK2ovZllsdjl1QnF5SVF1RGsySHVRL1A3YVRFR2g4Y3JK
clZLeDJveUVZV2p6VWxTeFR4V2lkN0t5MnU4VXBUNQpQMWRFdTM4T1c1SnUvQWQrQ0xVa1FnalJx
NlYya3hheTl0SnE3QVRTclpDbG54cnpHOEs4Y0hIVmVvdnY1Z21KCnd2eHE1RXI2SkVBTmcwaUhP
Tk84S3p3Q1N1VENlTVREUnFNbUU5OFJ5NktQSWRXSUhDeVhYV0t5K0w4M3J4VGIKMnRNZ1VYRWpJ
TzVtd1k4SkpZYkdkOVB3VW44UmRuTDYxYURQR2JxZDNFbkw2OUxMQ25sa0N2eW5RYndjS2J6YQpy
a1paQ0k0aEFBOXpNcm96dnZNbWJCYVZhRlRGK241UnpaMVNxc0NnSEVVQ2VwbGdKK1FWRGVycE0x
NkFBUkpQCnFBZGhwZXZlZ0dLVnI0b25GQlZDclJUSUFjZVdhZy94ZjFBaDQzQTVsQlZraEoxb3Yw
d3ZTOTZKc3pRdTUwaEwKdWxzOTJQUmdITFBua0dlcDNTU29JUVFwSnpScDZNd2NiNkpMOFUybkFR
RG5LVVNmSWcvRTF4aDhmOHhrZnh4VQpzS3F5eW5CSS9PUFB0NkVkVjZBSAo9WitZaAotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============8401807780642973664==--