* Re: [PATCH] arping: Update to 2.15
[not found] <566C1886.1060406@ipfire.org>
@ 2015-12-12 12:59 ` Michael Tremer
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tremer @ 2015-12-12 12:59 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
Yes, you can manually edit them and add what ever is needed.
I hope that my talk from the last developer summit will soon be
available where I explain why these are all there. You can find the
slides here, but these are probably not enough:
http://people.ipfire.org/~ms/talks/2015_-_Submitting_Patches.pdf
Otherwise this can be found here in a longer text:
http://wiki.ipfire.org/devel/git/tags
Best,
-Michael
On Sat, 2015-12-12 at 13:52 +0100, Matthias Fischer wrote:
> Hi Michael,
>
> On 12.12.2015 13:40, Michael Tremer wrote:
> > You could express this by adding an other Signed-off-by line with
> > Erik's details...
> >
> > Do you want to resend the patch?
>
> Yes. I never did this before, but I can try... ;-)
>
> As I understand:
>
> I add another line, saying:
>
> ...
> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> ...
>
> Would that be sufficient?
>
> Best,
> Matthias
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arping: Update to 2.15
2015-12-12 13:12 ` Michael Tremer
@ 2015-12-12 13:42 ` Matthias Fischer
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Fischer @ 2015-12-12 13:42 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
Hi,
On 12.12.2015 14:12, Michael Tremer wrote:
> the source is again not uploaded. Where did you put it?
Source was copied to
'ssh://mfischer:@git.ipfire.org:22/pub/source/source-2.x/arping-2.05.tar.gz'.
You're right, it wasn't there... Hm.
> It is also the case that the first line of your commit message is
> repeated. Why?
I hope, I get what you mean...which "first line" exactly?
What I did:
I edited the temporary 'git-sendmail'-file after committing with 'git
add commit -m "arping...." -s' as follows:
***SNIP***
From 93da5e37b6df425872c7d5f31ad81a7604bc3112 Mon Sep 17 00:00:00 2001
From: Matthias Fischer <matthias.fischer(a)ipfire.org>
Date: Sat, 12 Dec 2015 14:07:06 +0100
Subject: [PATCH] arping: Update to 2.15
arping: Update to 2.15 <-------------------------------------- Added
Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org> <- Added
Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org> <-------------- Added
---
lfs/arping | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lfs/arping b/lfs/arping
index 13eb05e..86f7279 100644
***SNAP***
If this it not needed or wanted, I can leave it as it is for the next time.
Best,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arping: Update to 2.15
2015-12-12 13:10 Matthias Fischer
@ 2015-12-12 13:12 ` Michael Tremer
2015-12-12 13:42 ` Matthias Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tremer @ 2015-12-12 13:12 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]
Hi,
the source is again not uploaded. Where did you put it?
It is also the case that the first line of your commit message is
repeated. Why?
-Michael
On Sat, 2015-12-12 at 14:10 +0100, Matthias Fischer wrote:
> arping: Update to 2.15
>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> ---
> lfs/arping | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/lfs/arping b/lfs/arping
> index 13eb05e..86f7279 100644
> --- a/lfs/arping
> +++ b/lfs/arping
> @@ -1,7 +1,7 @@
> ####################################################################
> ###########
> #
> #
> # IPFire.org - A linux based firewall
> #
> -# Copyright (C) 2007 Michael Tremer & Christian Schmidt
> #
> +# Copyright (C) 2015 Michael Tremer & Christian Schmidt
> #
> #
> #
> # This program is free software: you can redistribute it and/or
> modify #
> # it under the terms of the GNU General Public License as published
> by #
> @@ -24,7 +24,7 @@
>
> include Config
>
> -VER = 2.05
> +VER = 2.15
>
> THISAPP = arping-$(VER)
> DL_FILE = $(THISAPP).tar.gz
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>
> -$(DL_FILE)_MD5 = 96e7c2ce8ae09046e264a314eeaac4dd
> +$(DL_FILE)_MD5 = 676584f6eb4ccc8c70fc6b2c702df75d
>
> install : $(TARGET)
>
> @@ -70,7 +70,11 @@ $(subst %,%_MD5,$(objects)) :
> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> @$(PREBUILD)
> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf
> $(DIR_DL)/$(DL_FILE)
> + cd $(DIR_APP) && ./bootstrap.sh
> + cd $(DIR_APP) && ./configure --prefix=/usr
> +
> cd $(DIR_APP) && make $(MAKETUNING)
> - cd $(DIR_APP) && install -m 0755 arping /usr/sbin
> + cd $(DIR_APP) && make install
> +
> @rm -rf $(DIR_APP)
> @$(POSTBUILD)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arping: Update to 2.15
@ 2015-12-12 13:10 Matthias Fischer
2015-12-12 13:12 ` Michael Tremer
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2015-12-12 13:10 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
arping: Update to 2.15
Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
---
lfs/arping | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lfs/arping b/lfs/arping
index 13eb05e..86f7279 100644
--- a/lfs/arping
+++ b/lfs/arping
@@ -1,7 +1,7 @@
###############################################################################
# #
# IPFire.org - A linux based firewall #
-# Copyright (C) 2007 Michael Tremer & Christian Schmidt #
+# Copyright (C) 2015 Michael Tremer & Christian Schmidt #
# #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
@@ -24,7 +24,7 @@
include Config
-VER = 2.05
+VER = 2.15
THISAPP = arping-$(VER)
DL_FILE = $(THISAPP).tar.gz
@@ -40,7 +40,7 @@ objects = $(DL_FILE)
$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-$(DL_FILE)_MD5 = 96e7c2ce8ae09046e264a314eeaac4dd
+$(DL_FILE)_MD5 = 676584f6eb4ccc8c70fc6b2c702df75d
install : $(TARGET)
@@ -70,7 +70,11 @@ $(subst %,%_MD5,$(objects)) :
$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
@$(PREBUILD)
@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
+ cd $(DIR_APP) && ./bootstrap.sh
+ cd $(DIR_APP) && ./configure --prefix=/usr
+
cd $(DIR_APP) && make $(MAKETUNING)
- cd $(DIR_APP) && install -m 0755 arping /usr/sbin
+ cd $(DIR_APP) && make install
+
@rm -rf $(DIR_APP)
@$(POSTBUILD)
--
2.6.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arping: Update to 2.15
2015-12-12 12:32 Matthias Fischer
@ 2015-12-12 12:40 ` Michael Tremer
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tremer @ 2015-12-12 12:40 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]
Hi,
On Sat, 2015-12-12 at 13:32 +0100, Matthias Fischer wrote:
> arping: Update to 2.15
> (lfs by ummeegge)
You could express this by adding an other Signed-off-by line with
Erik's details...
Do you want to resend the patch?
-Michael
>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> lfs/arping | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/lfs/arping b/lfs/arping
> index 13eb05e..86f7279 100644
> --- a/lfs/arping
> +++ b/lfs/arping
> @@ -1,7 +1,7 @@
> ####################################################################
> ###########
> #
> #
> # IPFire.org - A linux based firewall
> #
> -# Copyright (C) 2007 Michael Tremer & Christian Schmidt
> #
> +# Copyright (C) 2015 Michael Tremer & Christian Schmidt
> #
> #
> #
> # This program is free software: you can redistribute it and/or
> modify #
> # it under the terms of the GNU General Public License as published
> by #
> @@ -24,7 +24,7 @@
>
> include Config
>
> -VER = 2.05
> +VER = 2.15
>
> THISAPP = arping-$(VER)
> DL_FILE = $(THISAPP).tar.gz
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>
> -$(DL_FILE)_MD5 = 96e7c2ce8ae09046e264a314eeaac4dd
> +$(DL_FILE)_MD5 = 676584f6eb4ccc8c70fc6b2c702df75d
>
> install : $(TARGET)
>
> @@ -70,7 +70,11 @@ $(subst %,%_MD5,$(objects)) :
> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> @$(PREBUILD)
> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf
> $(DIR_DL)/$(DL_FILE)
> + cd $(DIR_APP) && ./bootstrap.sh
> + cd $(DIR_APP) && ./configure --prefix=/usr
> +
> cd $(DIR_APP) && make $(MAKETUNING)
> - cd $(DIR_APP) && install -m 0755 arping /usr/sbin
> + cd $(DIR_APP) && make install
> +
> @rm -rf $(DIR_APP)
> @$(POSTBUILD)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arping: Update to 2.15
@ 2015-12-12 12:32 Matthias Fischer
2015-12-12 12:40 ` Michael Tremer
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2015-12-12 12:32 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]
arping: Update to 2.15
(lfs by ummeegge)
Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
lfs/arping | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lfs/arping b/lfs/arping
index 13eb05e..86f7279 100644
--- a/lfs/arping
+++ b/lfs/arping
@@ -1,7 +1,7 @@
###############################################################################
# #
# IPFire.org - A linux based firewall #
-# Copyright (C) 2007 Michael Tremer & Christian Schmidt #
+# Copyright (C) 2015 Michael Tremer & Christian Schmidt #
# #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
@@ -24,7 +24,7 @@
include Config
-VER = 2.05
+VER = 2.15
THISAPP = arping-$(VER)
DL_FILE = $(THISAPP).tar.gz
@@ -40,7 +40,7 @@ objects = $(DL_FILE)
$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-$(DL_FILE)_MD5 = 96e7c2ce8ae09046e264a314eeaac4dd
+$(DL_FILE)_MD5 = 676584f6eb4ccc8c70fc6b2c702df75d
install : $(TARGET)
@@ -70,7 +70,11 @@ $(subst %,%_MD5,$(objects)) :
$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
@$(PREBUILD)
@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
+ cd $(DIR_APP) && ./bootstrap.sh
+ cd $(DIR_APP) && ./configure --prefix=/usr
+
cd $(DIR_APP) && make $(MAKETUNING)
- cd $(DIR_APP) && install -m 0755 arping /usr/sbin
+ cd $(DIR_APP) && make install
+
@rm -rf $(DIR_APP)
@$(POSTBUILD)
--
2.6.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-12 13:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <566C1886.1060406@ipfire.org>
2015-12-12 12:59 ` [PATCH] arping: Update to 2.15 Michael Tremer
2015-12-12 13:10 Matthias Fischer
2015-12-12 13:12 ` Michael Tremer
2015-12-12 13:42 ` Matthias Fischer
-- strict thread matches above, loose matches on Subject: below --
2015-12-12 12:32 Matthias Fischer
2015-12-12 12:40 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox