From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Sending in patches
Date: Sat, 16 Jan 2016 14:48:40 +0000
Message-ID: <1452955720.5665.103.camel@ipfire.org>
In-Reply-To: <5698A8CF.8090901@web.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4345080256544168933=="
List-Id: <development.lists.ipfire.org>

--===============4345080256544168933==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-01-15 at 09:07 +0100, IT Superhack wrote:
> Hello Michael,
>=20
> Michael Tremer:
> > Hi,
> >=20
> > so about half a week has passed since my initial email. I suppose
> > this
> > is all that is coming and that the others are perfectly satisfied
> > with
> > this process.
> >=20
> > So let's conclude:
> >=20
> > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer =20
> > > <michael.tremer(a)ipfire.org> wrote:
> > >=20
> > > > I find this process with "git send-email" very easy and I am
> > > > not sure where the problems could be.
> > >=20
> > > I am using TortoiseGit with Windows 7. I don't know if this tool
> > > supports =20
> > > "git send-email" and I wouldn't want to use command line git (it
> > > is =20
> > > annoying to use more than one tool for the same job, IMHO).
> >=20
> >=20
> > I didn't know that this many people use Windows. The problem with
> > that
> > is you cannot build the distribution. You can copy some files back
> > and
> > forth, but never build.
> >=20
> > I consider this to be a huge disadvantage.
> >=20
> > Is this just by choice or did you not want to go through the
> > trouble
> > setting up a Linux system?
> >=20
> > > Therefore, I =20
> > > create a patch file using TortoiseGit (I need a workflow reminder
> > > for
> > > this =20
> > > to get it right), then send the contents with Thunderbird where I
> > > have to =20
> > > remember to disable line wrap (also using a workflow reminder
> > > text).
> >=20
> > When ever you make personal notes, why not use the wiki for that
> > and
> > share? Many other people might have the same questions.
> I recently wrote a page about sending in patches via a Mail User
> Agent.
> It can be found here: https://wiki.ipfire.org/devel/send-tb-patches
> (Thanks to Matthias Fischer here who sent me a good hint about
> disabling
> line-wrapping in TB.)
> >=20
> > > In other projects (using Github), IMHO it is much easier to push
> > > to
> > > one's =20
> > > own repository and create a merge request to the upstream
> > > repository.
> >=20
> >=20
> > We can't use GitHub. I have explained that at various occasions and
> > this thread wasn't started to discuss other tools. Other things
> > have
> > been proposed, too, and the same goes for them.
> >=20
> > At the end the only problem I understand you are experiencing here
> > is
> > actually emailing the patch files without your mail agents not
> > making
> > garbage out of that. This can't be too hard to get right.
> >=20
> > > Discussion can take place with that merge request.
> >=20
> > No, not at all. This process is actually well thought through and
> > designed to maximise participation of the users and make everything
> > easy for developers. And I actually think it does that well.
> For me, sending in patches is not a very big issue since you only
> need
> to "set up" a system for sending in patches once.
>=20
> The problem is more the workflow after a patch has been sent in. Some
> of them seem to be dropped silently, while others are commented and
> then
> somehow forgotten. Perhaps I need to polish my english skills in
> order
> to add better descriptions to my patches... ;-)

That is a completely different matter though. You should find the
emails then and ask why certain things are happening.

I tried to cover this a bit over here:

http://wiki.ipfire.org/devel/submit-patches#respond_to_review_comments

and here:

http://wiki.ipfire.org/devel/submit-patches#don_t_get_discouraged_-_or_impati=
ent


> >=20
> > > In case you are open to using other tools in place of Patchwork,
> > > what
> > >  =20
> > > about Gitlab?
> >=20
> > Patchwork is just a view to the patches. My actual repository for
> > that
> > is my inbox.
> >=20
> > >=20
> > >=20
> > > Lars
> >=20
> > -Michael
> >=20
> Best regards,
> Timmothy Wilson
>=20

-Michael

>=20

--===============4345080256544168933==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC
Q2dBR0JRSldtbGhJQUFvSkVJQjU4UDl2a0FrSDRVWVAvQWk2WDN0YThiOTQ0MDJoTTZ1MWtWUnIK
WWVqNllGeUR6b2NxUnR1dTZHQjQ0VG5uZU1VR1hFdWl0NUtzUldaVExGcFNlUmQzbEY3SFgreG9k
bk0zclo5dAo0UXVPNlZ0RHhrN3BsVm1QWW1LSjZQVnBTUXgyQy9GcmdWQXJJUTg5RjZhVmxJdUZi
emNreW5sZWNDU3VQVUJwCkhaYWgvejJOcStMejF1UnRoYkx1T0oyd2FjSlFINzF1bWRjUDJsd25R
N2Q4VGNyMkVuQnlYd1IvOGwyeFZ3eGEKSjZ0VlQ5Q3hiMkdoVnVPS25oUnBMb3c1ZzZObWN6UWp6
YkRWQnBVV2dmQmxtMFUxSUVFQXUwcGsvbEFaN1RzNApEek5LcnFWMk5VeVdwY1dqamVITUJGNEZn
eGRsWjJZSGE3bkFGRWthaG96SmZyWEZ2ODRtUHZjVE1nMjVYQS9XCmtVaG8zaGQ3U3RRVm90WTFo
MWFvdnN6QjVhWnRHcDBzT2hjcXg0aUdZQlBPU3JjOHVxdzduZmViZFZVODNVVG4KY0F5V2Fjdnor
ZzVCdzdPWXpKN2JQSStJdmlSYlFRVGNEaWhwMjUxVkg1ZlB0WW14T2dpMVNQNVNlSlprcFNJQQpp
MlBTYmhEZFhwNU52STZma0dwL0RJQlFiaVUyTlBYVVlXWDFEalA2YXAwVm44cEc0alBqVXJtbjQx
cHBSTHpzCjBiZGdTSnpIQ0RRRXFYUk5VK25jV2hkWnZ4TmpEYkF4ZDlDOE41VGdwYzYzOUlaUFlr
U2szZEQrSmVsUXlibHkKbFlRWjIzK3FmL3V1bStJNXkwRTA0aUk5bEZ2MUt5ZnA4T2IrSnRjNzB4
VHU2R01OVk9UZis1QlJveW52R2NwcgpxNXNTNkg1SXV3VVhUY01mZXN0SAo9cnBUWQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============4345080256544168933==--