Re: Sending in patches

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 6180 bytes --]

Hello,

I held a talk at the last IPFire Developer Summit about why we are
doing it this way. This is currently being edited. I will CC Aaron in
this conversation to remind him to get the editing of this done.

It will not explain how to send in a patch (we had a short demo of this
at the event, but that is probably not good enough to keep in the
video), but the objective behind many things so I hope that everyone
will understand what to take care of.

Maybe Alex can make a HOWTO video like the firewall screencast he has
been publishing in the last few weeks. I CC'ed him, too.

Best,
-Michael

On Sat, 2016-01-16 at 15:48 +0100, Blago Culjak wrote:
> Well, I do have cluster with free space, I can setup a machine
> myself.
> 
> But recording proccess of submiting a patch would be of great value.
> 
> Poslano s mog Windows Phonea
> Šalje: Michael Tremer
> Poslano: ‎16.‎1.‎2016. 15:45
> Prima: R. W. Rodolico; development(a)lists.ipfire.org
> Predmet: Re: Sending in patches
> 
> Hey Rod,
> 
> this is a great offer. Thank you very much. I hope that someone will
> find this useful.
> 
> On Fri, 2016-01-15 at 13:24 -0600, R. W. Rodolico wrote:
> > I understand that some people may need or want Windows as their
> base
> > machine and have little reason for having a separate Unix (Linux)
> > machine. Yet, in some cases, having access to such a machine for
> > development purposes could be useful.
> > 
> > I run a series of servers at a NOC here in the US. If anyone is
> > interested, I'd be happy to build out a Linux or FreeBSD virtual
> for
> > this purpose. I could be a pure Command Line machine (what I
> normally
> > run) or I could put a very basic GUI (XFCE4) on it. You could
> choose
> > to access it via OpenVPN (much more secure) or direct public IP.
> 
> Just wanted to say quickly that it will have to be a Linux. I am not
> sure if is possible in any way to build IPFire on a BSD. Our build
> system doesn't support this right now and I doubt that this is
> possible
> at all. So use Linux please.
> 
> > 
> > If anyone wants to try it, let me know. This is totally no
> pressure,
> > you can try the system, and if the environment is too alien for you
> > to
> > really get work done, then just bail out. But I'd be happy to set
> it
> > up for one or more developers to use.
> > 
> > Feel free to respond on list, or write me directly.
> > 
> > Rod
> 
> -Michael
> 
> > 
> > On 01/15/2016 02:07 AM, IT Superhack wrote:
> > > Hello Michael,
> > > 
> > > Michael Tremer:
> > > > Hi,
> > > > 
> > > > so about half a week has passed since my initial email. I
> suppose
> > > > this is all that is coming and that the others are perfectly
> > > > satisfied with this process.
> > > > 
> > > > So let's conclude:
> > > > 
> > > > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> > > > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer 
> > > > > <michael.tremer(a)ipfire.org> wrote:
> > > > > 
> > > > > > I find this process with "git send-email" very easy and I
> am 
> > > > > > not sure where the problems could be.
> > > > > 
> > > > > I am using TortoiseGit with Windows 7. I don't know if this
> > > > > tool supports "git send-email" and I wouldn't want to use
> > > > > command line git (it is annoying to use more than one tool
> for
> > > > > the same job, IMHO).
> > > > 
> > > > 
> > > > I didn't know that this many people use Windows. The problem
> with
> > > > that is you cannot build the distribution. You can copy some
> > > > files back and forth, but never build.
> > > > 
> > > > I consider this to be a huge disadvantage.
> > > > 
> > > > Is this just by choice or did you not want to go through the
> > > > trouble setting up a Linux system?
> > > > 
> > > > > Therefore, I create a patch file using TortoiseGit (I need a
> > > > > workflow reminder for this to get it right), then send the
> > > > > contents with Thunderbird where I have to remember to disable
> > > > > line wrap (also using a workflow reminder text).
> > > > 
> > > > When ever you make personal notes, why not use the wiki for
> that
> > > > and share? Many other people might have the same questions.
> > > I recently wrote a page about sending in patches via a Mail User
> > > Agent. It can be found here:
> > > https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias
> > > Fischer here who sent me a good hint about disabling line
> -wrapping
> > > in TB.)
> > > > 
> > > > > In other projects (using Github), IMHO it is much easier to
> > > > > push to one's own repository and create a merge request to
> the
> > > > > upstream repository.
> > > > 
> > > > 
> > > > We can't use GitHub. I have explained that at various occasions
> > > > and this thread wasn't started to discuss other tools. Other
> > > > things have been proposed, too, and the same goes for them.
> > > > 
> > > > At the end the only problem I understand you are experiencing
> > > > here is actually emailing the patch files without your mail
> > > > agents not making garbage out of that. This can't be too hard
> to
> > > > get right.
> > > > 
> > > > > Discussion can take place with that merge request.
> > > > 
> > > > No, not at all. This process is actually well thought through
> > > > and designed to maximise participation of the users and make
> > > > everything easy for developers. And I actually think it does
> that
> > > > well.
> > > For me, sending in patches is not a very big issue since you only
> > > need to "set up" a system for sending in patches once.
> > > 
> > > The problem is more the workflow after a patch has been sent in.
> > > Some of them seem to be dropped silently, while others are
> > > commented and then somehow forgotten. Perhaps I need to polish my
> > > english skills in order to add better descriptions to my
> patches...
> > > ;-)
> > > > 
> > > > > In case you are open to using other tools in place of
> > > > > Patchwork, what
> > > > > 
> > > > > about Gitlab?
> > > > 
> > > > Patchwork is just a view to the patches. My actual repository
> for
> > > > that is my inbox.
> > > > 
> > > > > 
> > > > > 
> > > > > Lars
> > > > 
> > > > -Michael
> > > > 
> > > Best regards, Timmothy Wilson
> > > 
> > > 
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]