Re: Sending in patches

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 6180 bytes --]

Hello,

I held a talk at the last IPFire Developer Summit about why we are
doing it this way. This is currently being edited. I will CC Aaron in
this conversation to remind him to get the editing of this done.

It will not explain how to send in a patch (we had a short demo of this
at the event, but that is probably not good enough to keep in the
video), but the objective behind many things so I hope that everyone
will understand what to take care of.

Maybe Alex can make a HOWTO video like the firewall screencast he has
been publishing in the last few weeks. I CC'ed him, too.

Best,
-Michael

On Sat, 2016-01-16 at 15:48 +0100, Blago Culjak wrote:
> Well, I do have cluster with free space, I can setup a machine
> myself.
> 
> But recording proccess of submiting a patch would be of great value.
> 
> Poslano s mog Windows Phonea
> Šalje: Michael Tremer
> Poslano: ‎16.‎1.‎2016. 15:45
> Prima: R. W. Rodolico; development(a)lists.ipfire.org
> Predmet: Re: Sending in patches
> 
> Hey Rod,
> 
> this is a great offer. Thank you very much. I hope that someone will
> find this useful.
> 
> On Fri, 2016-01-15 at 13:24 -0600, R. W. Rodolico wrote:
> > I understand that some people may need or want Windows as their
> base
> > machine and have little reason for having a separate Unix (Linux)
> > machine. Yet, in some cases, having access to such a machine for
> > development purposes could be useful.
> > 
> > I run a series of servers at a NOC here in the US. If anyone is
> > interested, I'd be happy to build out a Linux or FreeBSD virtual
> for
> > this purpose. I could be a pure Command Line machine (what I
> normally
> > run) or I could put a very basic GUI (XFCE4) on it. You could
> choose
> > to access it via OpenVPN (much more secure) or direct public IP.
> 
> Just wanted to say quickly that it will have to be a Linux. I am not
> sure if is possible in any way to build IPFire on a BSD. Our build
> system doesn't support this right now and I doubt that this is
> possible
> at all. So use Linux please.
> 
> > 
> > If anyone wants to try it, let me know. This is totally no
> pressure,
> > you can try the system, and if the environment is too alien for you
> > to
> > really get work done, then just bail out. But I'd be happy to set
> it
> > up for one or more developers to use.
> > 
> > Feel free to respond on list, or write me directly.
> > 
> > Rod
> 
> -Michael
> 
> > 
> > On 01/15/2016 02:07 AM, IT Superhack wrote:
> > > Hello Michael,
> > > 
> > > Michael Tremer:
> > > > Hi,
> > > > 
> > > > so about half a week has passed since my initial email. I
> suppose
> > > > this is all that is coming and that the others are perfectly
> > > > satisfied with this process.
> > > > 
> > > > So let's conclude:
> > > > 
> > > > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> > > > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer 
> > > > > <michael.tremer(a)ipfire.org> wrote:
> > > > > 
> > > > > > I find this process with "git send-email" very easy and I
> am 
> > > > > > not sure where the problems could be.
> > > > > 
> > > > > I am using TortoiseGit with Windows 7. I don't know if this
> > > > > tool supports "git send-email" and I wouldn't want to use
> > > > > command line git (it is annoying to use more than one tool
> for
> > > > > the same job, IMHO).
> > > > 
> > > > 
> > > > I didn't know that this many people use Windows. The problem
> with
> > > > that is you cannot build the distribution. You can copy some
> > > > files back and forth, but never build.
> > > > 
> > > > I consider this to be a huge disadvantage.
> > > > 
> > > > Is this just by choice or did you not want to go through the
> > > > trouble setting up a Linux system?
> > > > 
> > > > > Therefore, I create a patch file using TortoiseGit (I need a
> > > > > workflow reminder for this to get it right), then send the
> > > > > contents with Thunderbird where I have to remember to disable
> > > > > line wrap (also using a workflow reminder text).
> > > > 
> > > > When ever you make personal notes, why not use the wiki for
> that
> > > > and share? Many other people might have the same questions.
> > > I recently wrote a page about sending in patches via a Mail User
> > > Agent. It can be found here:
> > > https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias
> > > Fischer here who sent me a good hint about disabling line
> -wrapping
> > > in TB.)
> > > > 
> > > > > In other projects (using Github), IMHO it is much easier to
> > > > > push to one's own repository and create a merge request to
> the
> > > > > upstream repository.
> > > > 
> > > > 
> > > > We can't use GitHub. I have explained that at various occasions
> > > > and this thread wasn't started to discuss other tools. Other
> > > > things have been proposed, too, and the same goes for them.
> > > > 
> > > > At the end the only problem I understand you are experiencing
> > > > here is actually emailing the patch files without your mail
> > > > agents not making garbage out of that. This can't be too hard
> to
> > > > get right.
> > > > 
> > > > > Discussion can take place with that merge request.
> > > > 
> > > > No, not at all. This process is actually well thought through
> > > > and designed to maximise participation of the users and make
> > > > everything easy for developers. And I actually think it does
> that
> > > > well.
> > > For me, sending in patches is not a very big issue since you only
> > > need to "set up" a system for sending in patches once.
> > > 
> > > The problem is more the workflow after a patch has been sent in.
> > > Some of them seem to be dropped silently, while others are
> > > commented and then somehow forgotten. Perhaps I need to polish my
> > > english skills in order to add better descriptions to my
> patches...
> > > ;-)
> > > > 
> > > > > In case you are open to using other tools in place of
> > > > > Patchwork, what
> > > > > 
> > > > > about Gitlab?
> > > > 
> > > > Patchwork is just a view to the patches. My actual repository
> for
> > > > that is my inbox.
> > > > 
> > > > > 
> > > > > 
> > > > > Lars
> > > > 
> > > > -Michael
> > > > 
> > > Best regards, Timmothy Wilson
> > > 
> > > 
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]

Hi,

thanks for your input.

How to use Git on Windows? I suppose there is no (good) command line.
Are there graphical tools that support sending emails?

-Michael

On Mon, 2016-01-11 at 21:55 +0100, Blago Culjak wrote:
> Hello, I have also tried to do couple "first bugs" and failed to send
> them in using Larsen cheat sheet. He tried to help me twice, but no
> luck.
> 
> It just takes longer to send in patches then it is to deal with a
> bug. Unleast for us on Windows. I do it in my own time, as do you, so
> I dont have too much time to waste.
> 
> I would recomend a youtube tutorial to get started, I think its
> easiest to select an easy bug and record sending proccess. Windows
> setup would be great, but I can manage in Linux as virtual machine.
> 
> Poslano s mog Windows Phonea
> Šalje: Larsen
> Poslano: ‎11.‎1.‎2016. 21:40
> Prima: development(a)lists.ipfire.org
> Predmet: Re: Sending in patches
> 
> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
> <michael.tremer(a)ipfire.org> wrote:
> 
> > I find this process with "git send-email" very easy and I am
> > not sure where the problems could be.
> 
> I am using TortoiseGit with Windows 7. I don't know if this tool
> supports  
> "git send-email" and I wouldn't want to use command line git (it is  
> annoying to use more than one tool for the same job, IMHO).
> Therefore, I  
> create a patch file using TortoiseGit (I need a workflow reminder for
> this  
> to get it right), then send the contents with Thunderbird where I
> have to  
> remember to disable line wrap (also using a workflow reminder text).
> 
> In other projects (using Github), IMHO it is much easier to push to
> one's  
> own repository and create a merge request to the upstream repository.
>   
> Discussion can take place with that merge request.
> 
> In case you are open to using other tools in place of Patchwork, what
>   
> about Gitlab?
> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Xaver4all]

[-- Attachment #1: Type: text/plain, Size: 2591 bytes --]

Hi,

I'm using TortoiseGiton win7 as well, this Tool has a send email function,

https://tortoisegit.org/docs/tortoisegit/tgit-dug-settings.html#tgit-dug-settings-network-email

but I can't use it because I can't setup the sender from email address which is mandatory for GMX.
So I use Thunderbird as well and even with line-warp disabled it still wrap it sometimes.



Aside form GitHub and GitLab, there is also Gogs which is more light-wight than GitLab, Open Source and under MIT License.

-Kim



Am 13.01.2016 um 00:51 schrieb Michael Tremer:
> Hi,
>
> thanks for your input.
>
> How to use Git on Windows? I suppose there is no (good) command line.
> Are there graphical tools that support sending emails?
>
> -Michael
>
> On Mon, 2016-01-11 at 21:55 +0100, Blago Culjak wrote:
>> Hello, I have also tried to do couple "first bugs" and failed to send
>> them in using Larsen cheat sheet. He tried to help me twice, but no
>> luck.
>>
>> It just takes longer to send in patches then it is to deal with a
>> bug. Unleast for us on Windows. I do it in my own time, as do you, so
>> I dont have too much time to waste.
>>
>> I would recomend a youtube tutorial to get started, I think its
>> easiest to select an easy bug and record sending proccess. Windows
>> setup would be great, but I can manage in Linux as virtual machine.
>>
>> Poslano s mog Windows Phonea
>> Šalje: Larsen
>> Poslano: ‎11.‎1.‎2016. 21:40
>> Prima: development(a)lists.ipfire.org
>> Predmet: Re: Sending in patches
>>
>> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
>> <michael.tremer(a)ipfire.org> wrote:
>>
>>> I find this process with "git send-email" very easy and I am
>>> not sure where the problems could be.
>> I am using TortoiseGit with Windows 7. I don't know if this tool
>> supports  
>> "git send-email" and I wouldn't want to use command line git (it is  
>> annoying to use more than one tool for the same job, IMHO).
>> Therefore, I  
>> create a patch file using TortoiseGit (I need a workflow reminder for
>> this  
>> to get it right), then send the contents with Thunderbird where I
>> have to  
>> remember to disable line wrap (also using a workflow reminder text).
>>
>> In other projects (using Github), IMHO it is much easier to push to
>> one's  
>> own repository and create a merge request to the upstream repository.
>>   
>> Discussion can take place with that merge request.
>>
>> In case you are open to using other tools in place of Patchwork, what
>>   
>> about Gitlab?
>>
>>
>> Lars

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2960 bytes --]

Hi,

On Wed, 2016-01-13 at 05:39 +0100, Xaver4all wrote:
> Hi,
> 
> I'm using TortoiseGiton win7 as well, this Tool has a send email
> function,
> 
> https://tortoisegit.org/docs/tortoisegit/tgit-dug-settings.html#tgit-
> dug-settings-network-email
> 
> but I can't use it because I can't setup the sender from email
> address which is mandatory for GMX.

Have you ever tried to use something else than GMX?

> So I use Thunderbird as well and even with line-warp disabled it
> still wrap it sometimes.

Or file a bug report at Thunderbird?

> 
> 
> 
> Aside form GitHub and GitLab, there is also Gogs which is more light
> -wight than GitLab, Open Source and under MIT License.
> 
> -Kim
> 
> 
> 
> Am 13.01.2016 um 00:51 schrieb Michael Tremer:
> > Hi,
> > 
> > thanks for your input.
> > 
> > How to use Git on Windows? I suppose there is no (good) command
> > line.
> > Are there graphical tools that support sending emails?
> > 
> > -Michael
> > 
> > On Mon, 2016-01-11 at 21:55 +0100, Blago Culjak wrote:
> > > Hello, I have also tried to do couple "first bugs" and failed to
> > > send
> > > them in using Larsen cheat sheet. He tried to help me twice, but
> > > no
> > > luck.
> > > 
> > > It just takes longer to send in patches then it is to deal with a
> > > bug. Unleast for us on Windows. I do it in my own time, as do
> > > you, so
> > > I dont have too much time to waste.
> > > 
> > > I would recomend a youtube tutorial to get started, I think its
> > > easiest to select an easy bug and record sending proccess.
> > > Windows
> > > setup would be great, but I can manage in Linux as virtual
> > > machine.
> > > 
> > > Poslano s mog Windows Phonea
> > > Šalje: Larsen
> > > Poslano: ‎11.‎1.‎2016. 21:40
> > > Prima: development(a)lists.ipfire.org
> > > Predmet: Re: Sending in patches
> > > 
> > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
> > > <michael.tremer(a)ipfire.org> wrote:
> > > 
> > > > I find this process with "git send-email" very easy and I am
> > > > not sure where the problems could be.
> > > I am using TortoiseGit with Windows 7. I don't know if this tool
> > > supports  
> > > "git send-email" and I wouldn't want to use command line git (it
> > > is  
> > > annoying to use more than one tool for the same job, IMHO).
> > > Therefore, I  
> > > create a patch file using TortoiseGit (I need a workflow reminder
> > > for
> > > this  
> > > to get it right), then send the contents with Thunderbird where I
> > > have to  
> > > remember to disable line wrap (also using a workflow reminder
> > > text).
> > > 
> > > In other projects (using Github), IMHO it is much easier to push
> > > to
> > > one's  
> > > own repository and create a merge request to the upstream
> > > repository.
> > >   
> > > Discussion can take place with that merge request.
> > > 
> > > In case you are open to using other tools in place of Patchwork,
> > > what
> > >   
> > > about Gitlab?
> > > 
> > > 
> > > Lars
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Hi,

so in recent times we had many people who have struggled with sending
in patches. The topic comes up every few weeks and I am not aware why
that is. I find this process with "git send-email" very easy and I am
not sure where the problems could be.

So I would like to start a discussion about where the problems are and
maybe that some of you can share their experiences and solutions. What
tools are you using? Do they need special settings?

The goal of that should be that we can add all the required information
to the documentation. Sending in patches should not be this frustration
experience it is at the moment.

  http://wiki.ipfire.org/devel/submit-patches

Best,
-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
<michael.tremer(a)ipfire.org> wrote:

> I find this process with "git send-email" very easy and I am
> not sure where the problems could be.

I am using TortoiseGit with Windows 7. I don't know if this tool supports  
"git send-email" and I wouldn't want to use command line git (it is  
annoying to use more than one tool for the same job, IMHO). Therefore, I  
create a patch file using TortoiseGit (I need a workflow reminder for this  
to get it right), then send the contents with Thunderbird where I have to  
remember to disable line wrap (also using a workflow reminder text).

In other projects (using Github), IMHO it is much easier to push to one's  
own repository and create a merge request to the upstream repository.  
Discussion can take place with that merge request.

In case you are open to using other tools in place of Patchwork, what  
about Gitlab?


Lars

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2329 bytes --]

Hi,

so about half a week has passed since my initial email. I suppose this
is all that is coming and that the others are perfectly satisfied with
this process.

So let's conclude:

On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
> <michael.tremer(a)ipfire.org> wrote:
> 
> > I find this process with "git send-email" very easy and I am
> > not sure where the problems could be.
> 
> I am using TortoiseGit with Windows 7. I don't know if this tool
> supports  
> "git send-email" and I wouldn't want to use command line git (it is  
> annoying to use more than one tool for the same job, IMHO).


I didn't know that this many people use Windows. The problem with that
is you cannot build the distribution. You can copy some files back and
forth, but never build.

I consider this to be a huge disadvantage.

Is this just by choice or did you not want to go through the trouble
setting up a Linux system?

> Therefore, I  
> create a patch file using TortoiseGit (I need a workflow reminder for
> this  
> to get it right), then send the contents with Thunderbird where I
> have to  
> remember to disable line wrap (also using a workflow reminder text).

When ever you make personal notes, why not use the wiki for that and
share? Many other people might have the same questions.

> In other projects (using Github), IMHO it is much easier to push to
> one's  
> own repository and create a merge request to the upstream repository.


We can't use GitHub. I have explained that at various occasions and
this thread wasn't started to discuss other tools. Other things have
been proposed, too, and the same goes for them.

At the end the only problem I understand you are experiencing here is
actually emailing the patch files without your mail agents not making
garbage out of that. This can't be too hard to get right.

> Discussion can take place with that merge request.

No, not at all. This process is actually well thought through and
designed to maximise participation of the users and make everything
easy for developers. And I actually think it does that well.

> In case you are open to using other tools in place of Patchwork, what
>   
> about Gitlab?

Patchwork is just a view to the patches. My actual repository for that
is my inbox.

> 
> 
> Lars

-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[IT Superhack]

[-- Attachment #1: Type: text/plain, Size: 3125 bytes --]

Hello Michael,

Michael Tremer:
> Hi,
> 
> so about half a week has passed since my initial email. I suppose this
> is all that is coming and that the others are perfectly satisfied with
> this process.
> 
> So let's conclude:
> 
> On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
>> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
>> <michael.tremer(a)ipfire.org> wrote:
>>
>>> I find this process with "git send-email" very easy and I am
>>> not sure where the problems could be.
>>
>> I am using TortoiseGit with Windows 7. I don't know if this tool
>> supports  
>> "git send-email" and I wouldn't want to use command line git (it is  
>> annoying to use more than one tool for the same job, IMHO).
> 
> 
> I didn't know that this many people use Windows. The problem with that
> is you cannot build the distribution. You can copy some files back and
> forth, but never build.
> 
> I consider this to be a huge disadvantage.
> 
> Is this just by choice or did you not want to go through the trouble
> setting up a Linux system?
> 
>> Therefore, I  
>> create a patch file using TortoiseGit (I need a workflow reminder for
>> this  
>> to get it right), then send the contents with Thunderbird where I
>> have to  
>> remember to disable line wrap (also using a workflow reminder text).
> 
> When ever you make personal notes, why not use the wiki for that and
> share? Many other people might have the same questions.
I recently wrote a page about sending in patches via a Mail User Agent.
It can be found here: https://wiki.ipfire.org/devel/send-tb-patches
(Thanks to Matthias Fischer here who sent me a good hint about disabling
line-wrapping in TB.)
> 
>> In other projects (using Github), IMHO it is much easier to push to
>> one's  
>> own repository and create a merge request to the upstream repository.
> 
> 
> We can't use GitHub. I have explained that at various occasions and
> this thread wasn't started to discuss other tools. Other things have
> been proposed, too, and the same goes for them.
> 
> At the end the only problem I understand you are experiencing here is
> actually emailing the patch files without your mail agents not making
> garbage out of that. This can't be too hard to get right.
> 
>> Discussion can take place with that merge request.
> 
> No, not at all. This process is actually well thought through and
> designed to maximise participation of the users and make everything
> easy for developers. And I actually think it does that well.
For me, sending in patches is not a very big issue since you only need
to "set up" a system for sending in patches once.

The problem is more the workflow after a patch has been sent in. Some
of them seem to be dropped silently, while others are commented and then
somehow forgotten. Perhaps I need to polish my english skills in order
to add better descriptions to my patches... ;-)
> 
>> In case you are open to using other tools in place of Patchwork, what
>>   
>> about Gitlab?
> 
> Patchwork is just a view to the patches. My actual repository for that
> is my inbox.
> 
>>
>>
>> Lars
> 
> -Michael
> 
Best regards,
Timmothy Wilson



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: Sending in patches

[R. W. Rodolico]

[-- Attachment #1: Type: text/plain, Size: 4506 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I understand that some people may need or want Windows as their base
machine and have little reason for having a separate Unix (Linux)
machine. Yet, in some cases, having access to such a machine for
development purposes could be useful.

I run a series of servers at a NOC here in the US. If anyone is
interested, I'd be happy to build out a Linux or FreeBSD virtual for
this purpose. I could be a pure Command Line machine (what I normally
run) or I could put a very basic GUI (XFCE4) on it. You could choose
to access it via OpenVPN (much more secure) or direct public IP.

If anyone wants to try it, let me know. This is totally no pressure,
you can try the system, and if the environment is too alien for you to
really get work done, then just bail out. But I'd be happy to set it
up for one or more developers to use.

Feel free to respond on list, or write me directly.

Rod

On 01/15/2016 02:07 AM, IT Superhack wrote:
> Hello Michael,
> 
> Michael Tremer:
>> Hi,
>> 
>> so about half a week has passed since my initial email. I suppose
>> this is all that is coming and that the others are perfectly
>> satisfied with this process.
>> 
>> So let's conclude:
>> 
>> On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
>>> On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer 
>>> <michael.tremer(a)ipfire.org> wrote:
>>> 
>>>> I find this process with "git send-email" very easy and I am 
>>>> not sure where the problems could be.
>>> 
>>> I am using TortoiseGit with Windows 7. I don't know if this
>>> tool supports "git send-email" and I wouldn't want to use
>>> command line git (it is annoying to use more than one tool for
>>> the same job, IMHO).
>> 
>> 
>> I didn't know that this many people use Windows. The problem with
>> that is you cannot build the distribution. You can copy some
>> files back and forth, but never build.
>> 
>> I consider this to be a huge disadvantage.
>> 
>> Is this just by choice or did you not want to go through the
>> trouble setting up a Linux system?
>> 
>>> Therefore, I create a patch file using TortoiseGit (I need a
>>> workflow reminder for this to get it right), then send the
>>> contents with Thunderbird where I have to remember to disable
>>> line wrap (also using a workflow reminder text).
>> 
>> When ever you make personal notes, why not use the wiki for that
>> and share? Many other people might have the same questions.
> I recently wrote a page about sending in patches via a Mail User
> Agent. It can be found here:
> https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias
> Fischer here who sent me a good hint about disabling line-wrapping
> in TB.)
>> 
>>> In other projects (using Github), IMHO it is much easier to
>>> push to one's own repository and create a merge request to the
>>> upstream repository.
>> 
>> 
>> We can't use GitHub. I have explained that at various occasions
>> and this thread wasn't started to discuss other tools. Other
>> things have been proposed, too, and the same goes for them.
>> 
>> At the end the only problem I understand you are experiencing
>> here is actually emailing the patch files without your mail
>> agents not making garbage out of that. This can't be too hard to
>> get right.
>> 
>>> Discussion can take place with that merge request.
>> 
>> No, not at all. This process is actually well thought through
>> and designed to maximise participation of the users and make
>> everything easy for developers. And I actually think it does that
>> well.
> For me, sending in patches is not a very big issue since you only
> need to "set up" a system for sending in patches once.
> 
> The problem is more the workflow after a patch has been sent in.
> Some of them seem to be dropped silently, while others are
> commented and then somehow forgotten. Perhaps I need to polish my
> english skills in order to add better descriptions to my patches...
> ;-)
>> 
>>> In case you are open to using other tools in place of
>>> Patchwork, what
>>> 
>>> about Gitlab?
>> 
>> Patchwork is just a view to the patches. My actual repository for
>> that is my inbox.
>> 
>>> 
>>> 
>>> Lars
>> 
>> -Michael
>> 
> Best regards, Timmothy Wilson
> 
> 

- -- 
Rod Rodolico
Daily Data, Inc.
POB 140465
Dallas TX 75214-0465
214.827.2170
http://www.dailydata.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlaZR1UACgkQuVY3UpYMlTRfDQCfW3itzn1ibwoVOYiK3rLohWaf
nAMAn3yqQN7M1ee0MCu0DT9Z/Qoe+Yts
=IIz7
-----END PGP SIGNATURE-----

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 4890 bytes --]

Hey Rod,

this is a great offer. Thank you very much. I hope that someone will
find this useful.

On Fri, 2016-01-15 at 13:24 -0600, R. W. Rodolico wrote:
> I understand that some people may need or want Windows as their base
> machine and have little reason for having a separate Unix (Linux)
> machine. Yet, in some cases, having access to such a machine for
> development purposes could be useful.
> 
> I run a series of servers at a NOC here in the US. If anyone is
> interested, I'd be happy to build out a Linux or FreeBSD virtual for
> this purpose. I could be a pure Command Line machine (what I normally
> run) or I could put a very basic GUI (XFCE4) on it. You could choose
> to access it via OpenVPN (much more secure) or direct public IP.

Just wanted to say quickly that it will have to be a Linux. I am not
sure if is possible in any way to build IPFire on a BSD. Our build
system doesn't support this right now and I doubt that this is possible
at all. So use Linux please.

> 
> If anyone wants to try it, let me know. This is totally no pressure,
> you can try the system, and if the environment is too alien for you
> to
> really get work done, then just bail out. But I'd be happy to set it
> up for one or more developers to use.
> 
> Feel free to respond on list, or write me directly.
> 
> Rod

-Michael

> 
> On 01/15/2016 02:07 AM, IT Superhack wrote:
> > Hello Michael,
> > 
> > Michael Tremer:
> > > Hi,
> > > 
> > > so about half a week has passed since my initial email. I suppose
> > > this is all that is coming and that the others are perfectly
> > > satisfied with this process.
> > > 
> > > So let's conclude:
> > > 
> > > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> > > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer 
> > > > <michael.tremer(a)ipfire.org> wrote:
> > > > 
> > > > > I find this process with "git send-email" very easy and I am 
> > > > > not sure where the problems could be.
> > > > 
> > > > I am using TortoiseGit with Windows 7. I don't know if this
> > > > tool supports "git send-email" and I wouldn't want to use
> > > > command line git (it is annoying to use more than one tool for
> > > > the same job, IMHO).
> > > 
> > > 
> > > I didn't know that this many people use Windows. The problem with
> > > that is you cannot build the distribution. You can copy some
> > > files back and forth, but never build.
> > > 
> > > I consider this to be a huge disadvantage.
> > > 
> > > Is this just by choice or did you not want to go through the
> > > trouble setting up a Linux system?
> > > 
> > > > Therefore, I create a patch file using TortoiseGit (I need a
> > > > workflow reminder for this to get it right), then send the
> > > > contents with Thunderbird where I have to remember to disable
> > > > line wrap (also using a workflow reminder text).
> > > 
> > > When ever you make personal notes, why not use the wiki for that
> > > and share? Many other people might have the same questions.
> > I recently wrote a page about sending in patches via a Mail User
> > Agent. It can be found here:
> > https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias
> > Fischer here who sent me a good hint about disabling line-wrapping
> > in TB.)
> > > 
> > > > In other projects (using Github), IMHO it is much easier to
> > > > push to one's own repository and create a merge request to the
> > > > upstream repository.
> > > 
> > > 
> > > We can't use GitHub. I have explained that at various occasions
> > > and this thread wasn't started to discuss other tools. Other
> > > things have been proposed, too, and the same goes for them.
> > > 
> > > At the end the only problem I understand you are experiencing
> > > here is actually emailing the patch files without your mail
> > > agents not making garbage out of that. This can't be too hard to
> > > get right.
> > > 
> > > > Discussion can take place with that merge request.
> > > 
> > > No, not at all. This process is actually well thought through
> > > and designed to maximise participation of the users and make
> > > everything easy for developers. And I actually think it does that
> > > well.
> > For me, sending in patches is not a very big issue since you only
> > need to "set up" a system for sending in patches once.
> > 
> > The problem is more the workflow after a patch has been sent in.
> > Some of them seem to be dropped silently, while others are
> > commented and then somehow forgotten. Perhaps I need to polish my
> > english skills in order to add better descriptions to my patches...
> > ;-)
> > > 
> > > > In case you are open to using other tools in place of
> > > > Patchwork, what
> > > > 
> > > > about Gitlab?
> > > 
> > > Patchwork is just a view to the patches. My actual repository for
> > > that is my inbox.
> > > 
> > > > 
> > > > 
> > > > Lars
> > > 
> > > -Michael
> > > 
> > Best regards, Timmothy Wilson
> > 
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Hi,

On 15.01.2016 20:24, R. W. Rodolico wrote:
> I understand that some people may need or want Windows as their base
> machine and have little reason for having a separate Unix (Linux)
> machine. Yet, in some cases, having access to such a machine for
> development purposes could be useful.

Indeed...!

> I run a series of servers at a NOC here in the US. If anyone is
> interested, I'd be happy to build out a Linux or FreeBSD virtual for
> this purpose. I could be a pure Command Line machine (what I normally
> run)...

As Michael already wrote: great idea, great offer: +1!

I'd recommend Linux too. I'm working here on an Ubuntu LTS system 
(command line). Pretty handy...

Best,
Matthias

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3945 bytes --]

On Fri, 2016-01-15 at 09:07 +0100, IT Superhack wrote:
> Hello Michael,
> 
> Michael Tremer:
> > Hi,
> > 
> > so about half a week has passed since my initial email. I suppose
> > this
> > is all that is coming and that the others are perfectly satisfied
> > with
> > this process.
> > 
> > So let's conclude:
> > 
> > On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
> > > On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer  
> > > <michael.tremer(a)ipfire.org> wrote:
> > > 
> > > > I find this process with "git send-email" very easy and I am
> > > > not sure where the problems could be.
> > > 
> > > I am using TortoiseGit with Windows 7. I don't know if this tool
> > > supports  
> > > "git send-email" and I wouldn't want to use command line git (it
> > > is  
> > > annoying to use more than one tool for the same job, IMHO).
> > 
> > 
> > I didn't know that this many people use Windows. The problem with
> > that
> > is you cannot build the distribution. You can copy some files back
> > and
> > forth, but never build.
> > 
> > I consider this to be a huge disadvantage.
> > 
> > Is this just by choice or did you not want to go through the
> > trouble
> > setting up a Linux system?
> > 
> > > Therefore, I  
> > > create a patch file using TortoiseGit (I need a workflow reminder
> > > for
> > > this  
> > > to get it right), then send the contents with Thunderbird where I
> > > have to  
> > > remember to disable line wrap (also using a workflow reminder
> > > text).
> > 
> > When ever you make personal notes, why not use the wiki for that
> > and
> > share? Many other people might have the same questions.
> I recently wrote a page about sending in patches via a Mail User
> Agent.
> It can be found here: https://wiki.ipfire.org/devel/send-tb-patches
> (Thanks to Matthias Fischer here who sent me a good hint about
> disabling
> line-wrapping in TB.)
> > 
> > > In other projects (using Github), IMHO it is much easier to push
> > > to
> > > one's  
> > > own repository and create a merge request to the upstream
> > > repository.
> > 
> > 
> > We can't use GitHub. I have explained that at various occasions and
> > this thread wasn't started to discuss other tools. Other things
> > have
> > been proposed, too, and the same goes for them.
> > 
> > At the end the only problem I understand you are experiencing here
> > is
> > actually emailing the patch files without your mail agents not
> > making
> > garbage out of that. This can't be too hard to get right.
> > 
> > > Discussion can take place with that merge request.
> > 
> > No, not at all. This process is actually well thought through and
> > designed to maximise participation of the users and make everything
> > easy for developers. And I actually think it does that well.
> For me, sending in patches is not a very big issue since you only
> need
> to "set up" a system for sending in patches once.
> 
> The problem is more the workflow after a patch has been sent in. Some
> of them seem to be dropped silently, while others are commented and
> then
> somehow forgotten. Perhaps I need to polish my english skills in
> order
> to add better descriptions to my patches... ;-)

That is a completely different matter though. You should find the
emails then and ask why certain things are happening.

I tried to cover this a bit over here:

http://wiki.ipfire.org/devel/submit-patches#respond_to_review_comments

and here:

http://wiki.ipfire.org/devel/submit-patches#don_t_get_discouraged_-_or_impatient


> > 
> > > In case you are open to using other tools in place of Patchwork,
> > > what
> > >   
> > > about Gitlab?
> > 
> > Patchwork is just a view to the patches. My actual repository for
> > that
> > is my inbox.
> > 
> > > 
> > > 
> > > Lars
> > 
> > -Michael
> > 
> Best regards,
> Timmothy Wilson
> 

-Michael

> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer  
<michael.tremer(a)ipfire.org> wrote:

> I didn't know that this many people use Windows. The problem with that
> is you cannot build the distribution. You can copy some files back and
> forth, but never build.
>
> I consider this to be a huge disadvantage.
>
> Is this just by choice or did you not want to go through the trouble
> setting up a Linux system?

Till now, I only wanted to improve things where I didn't need to build the  
distribution. Otherwise, I would probably have setup a Linux VM.


> When ever you make personal notes, why not use the wiki for that and
> share? Many other people might have the same questions.

Ok, will see to get the stuff into the wiki. Into which article should I  
put it?


Lars

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
> On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer  
> <michael.tremer(a)ipfire.org> wrote:
> 
> > I didn't know that this many people use Windows. The problem with
> > that
> > is you cannot build the distribution. You can copy some files back
> > and
> > forth, but never build.
> > 
> > I consider this to be a huge disadvantage.
> > 
> > Is this just by choice or did you not want to go through the
> > trouble
> > setting up a Linux system?
> 
> Till now, I only wanted to improve things where I didn't need to
> build the  
> distribution. Otherwise, I would probably have setup a Linux VM.
> 
> 
> > When ever you make personal notes, why not use the wiki for that
> > and
> > share? Many other people might have the same questions.
> 
> Ok, will see to get the stuff into the wiki. Into which article
> should I  
> put it?

Split the content in small and topical pages in the namespace where the
other ones are already.

Best,
-Michael

> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Sun, 17 Jan 2016 20:17:22 +0100, Michael Tremer  
<michael.tremer(a)ipfire.org> wrote:

> On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
>> On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer
>> <michael.tremer(a)ipfire.org> wrote:
>>
>> > I didn't know that this many people use Windows. The problem with
>> > that
>> > is you cannot build the distribution. You can copy some files back
>> > and
>> > forth, but never build.
>> >
>> > I consider this to be a huge disadvantage.
>> >
>> > Is this just by choice or did you not want to go through the
>> > trouble
>> > setting up a Linux system?
>>
>> Till now, I only wanted to improve things where I didn't need to
>> build the
>> distribution. Otherwise, I would probably have setup a Linux VM.
>>
>>
>> > When ever you make personal notes, why not use the wiki for that
>> > and
>> > share? Many other people might have the same questions.
>>
>> Ok, will see to get the stuff into the wiki. Into which article
>> should I
>> put it?
>
> Split the content in small and topical pages in the namespace where the
> other ones are already.

here it is:
http://wiki.ipfire.org/devel/tortoisegit


Lars

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

Hi,

On Thu, 2016-01-28 at 18:36 +0100, Larsen wrote:
> On Sun, 17 Jan 2016 20:17:22 +0100, Michael Tremer  
> <michael.tremer(a)ipfire.org> wrote:
> 
> > On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
> > > On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer
> > > <michael.tremer(a)ipfire.org> wrote:
> > > 
> > > > I didn't know that this many people use Windows. The problem
> > > > with
> > > > that
> > > > is you cannot build the distribution. You can copy some files
> > > > back
> > > > and
> > > > forth, but never build.
> > > > 
> > > > I consider this to be a huge disadvantage.
> > > > 
> > > > Is this just by choice or did you not want to go through the
> > > > trouble
> > > > setting up a Linux system?
> > > 
> > > Till now, I only wanted to improve things where I didn't need to
> > > build the
> > > distribution. Otherwise, I would probably have setup a Linux VM.
> > > 
> > > 
> > > > When ever you make personal notes, why not use the wiki for
> > > > that
> > > > and
> > > > share? Many other people might have the same questions.
> > > 
> > > Ok, will see to get the stuff into the wiki. Into which article
> > > should I
> > > put it?
> > 
> > Split the content in small and topical pages in the namespace where
> > the
> > other ones are already.
> 
> here it is:
> http://wiki.ipfire.org/devel/tortoisegit

Great. I moved this into the Git sub-section:

  http://wiki.ipfire.org/devel/git/windows

I didn't test if this actually works because I do not use Windows.

Best,
-Michael

> 
> 
> Lars

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Sending in patches

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hi,

On 10.01.2016 22:54, Michael Tremer wrote:
> I find this process with "git send-email" very easy...

Just a few "cents" from me... ;-)

I don't know how you would call it:

I'm doing it the "old-fashioned way": strictly by command-line, directly 
from GIT on my Ubuntu 'Devel'-PC. No GUI, no mouse, just console and 
keyboard. Nothing but blinking cursors and GIT commands.
git pull ..., git status ..., nano or mc-editor, make ..., git push ..., 
git sendmail ...: thats nearly all I use and need.

And after struggling through some - sometimes rather weird - problems, 
I'm getting used to it and wouldn't want to do it any other way.
Its logical and fast. Not comfortable, but 'at the roots'.

And while creating a patch for a new 'nano 2.5.1'-version 
(http://patchwork.ipfire.org/patch/208/) I got the thought that perhaps 
it would help others if I would ~record the process of creating this - 
rather easy - patch with some "how I did it" explanations and/or 
screenshots so they could get a grip on the procedure? Thinking of 
"Building Addons", perhaps we could put something like that in Wiki? Not 
too complicated, just showing how to build an rather easy patch and push 
it/send it through GIT.

Sorry, I got Windows 7 running, but none of the mentioned tools here, so 
my prerequisits may differ.

It would take some time, but I think, this could be a way to make things 
easier.

Jm2C

Best,
Matthias

Re: Sending in patches

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Tue, 2016-01-12 at 19:08 +0100, Matthias Fischer wrote:
> Hi,
> 
> On 10.01.2016 22:54, Michael Tremer wrote:
> > I find this process with "git send-email" very easy...
> 
> Just a few "cents" from me... ;-)
> 
> I don't know how you would call it:
> 
> I'm doing it the "old-fashioned way": strictly by command-line,
> directly 
> from GIT on my Ubuntu 'Devel'-PC. No GUI, no mouse, just console and 
> keyboard. Nothing but blinking cursors and GIT commands.
> git pull ..., git status ..., nano or mc-editor, make ..., git push
> ..., 
> git sendmail ...: thats nearly all I use and need.

I never considered that anyone would use something else than the
command line.

> And after struggling through some - sometimes rather weird -
> problems, 
> I'm getting used to it and wouldn't want to do it any other way.
> Its logical and fast. Not comfortable, but 'at the roots'.

Git is - of course like anything else - something that everyone needs
to learn at the start. After that is indeed logical and fast.

> And while creating a patch for a new 'nano 2.5.1'-version 
> (http://patchwork.ipfire.org/patch/208/) I got the thought that
> perhaps 
> it would help others if I would ~record the process of creating this 
> - 
> rather easy - patch with some "how I did it" explanations and/or 
> screenshots so they could get a grip on the procedure? Thinking of 
> "Building Addons", perhaps we could put something like that in Wiki?
> Not 
> too complicated, just showing how to build an rather easy patch and
> push 
> it/send it through GIT.

Maybe we should setup a page on the wiki to explain using git send
-email. I thought people read man pages from time to time which makes
this obsolete.

> 
> Sorry, I got Windows 7 running, but none of the mentioned tools here,
> so 
> my prerequisits may differ.
> 
> It would take some time, but I think, this could be a way to make
> things 
> easier.
> 
> Jm2C
> 
> Best,
> Matthias
> 

-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]