Re: [PATCH] dnsmasq 2.75: next patch... (No.50)

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2967 bytes --]

Hi,

On Sat, 2016-01-23 at 13:00 +0100, Matthias Fischer wrote:
> Anyway, patch No.056 came out a few minute ago: Coffee was updated,
> I'm
> at it again, Devel is running.

Will any of this be targeted to be included in C98?

> First:
> ***SNIP***
> ...
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c dnsmasq.c	
> dnsmasq.c: In function 'main':
> dnsmasq.c:922:7: warning: implicit declaration of function
> 'do_script_run' [-Wimplicit-function-declaration]
>        while (helper_buf_empty() && do_script_run(now));
>        ^
> dnsmasq.c:55:7: warning: unused variable 'did_bind' [-Wunused-
> variable]
>    int did_bind = 0;
>        ^
> dnsmasq.c:54:9: warning: unused variable 'bound_device' [-Wunused-
> variable]
>    char *bound_device = NULL;
>          ^
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c dhcp.c	
> ...
> ***SNAP***

Get in touch with Simon for this. It is nothing major. But good to
point it out.

> Second:
> ***SNIP***
> ...
> cc -O2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fPIC
> -fstack-protector-all --param=ssp-buffer-size=4 -march=i586
> -mtune=generic -fomit-frame-pointer -DHAVE_ISC_READER -DNO_INOTIFY
> -DVERSION='"2.75"'            -c isc.c	
> isc.c: In function 'dhcp_lease_new':
> isc.c:40:3: warning: ignoring return value of 'asprintf', declared
> with
> attribute warn_unused_result [-Wunused-result]
>    asprintf(&lease->fqdn, "%s.%s", hostname, daemon->domain_suffix);
>    ^
> cc  -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o
> dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o
> tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o
> radv.o slaac.o auth.o ipset.o domain.o dnssec.o blockdata.o tables.o
> loop.o inotify.o poll.o rrfilter.o edns0.o arp.o isc.o -lidn
> -lnettle -lhogweed   -lgmp
> ...
> ***SNAP***

This is in my code. I made a patch for that:

http://git.ipfire.org/?p=people/ms/dnsmasq.git;a=commitdiff;h=bac82b4ff2f971a0227efb1a83f2b2bb1cd28764

You can also pull the entire branch from that repository to generate a
recent patch against the latest development version.

> 
> Despite these warnings, the 'dnsmasq'-binary is usually built and is
> running fine (here). But I'd like to get rid of these warnings and
> don't
> know how (sorry, I'm no programmer). Asking in the 'dnsmasq'-list had
> no
> effect, I got no answers at all.
> 
> Does anyone in here has a clue?
> 
> Best,
> Matthias
> 

-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]