From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 5/7] New package spice
Date: Tue, 22 Mar 2016 19:05:37 +0000
Message-ID: <1458673537.30749.51.camel@ipfire.org>
In-Reply-To: <1458586059-740-6-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7744213364140488651=="
List-Id: <development.lists.ipfire.org>

--===============7744213364140488651==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2016-03-21 at 19:47 +0100, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> =C2=A0config/rootfiles/packages/spice | 23 +++++++++++
> =C2=A0lfs/spice=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0| 84
> +++++++++++++++++++++++++++++++++++++++++
> =C2=A02 files changed, 107 insertions(+)
> =C2=A0create mode 100644 config/rootfiles/packages/spice
> =C2=A0create mode 100644 lfs/spice
>=20
> diff --git a/config/rootfiles/packages/spice b/config/rootfiles/packages/sp=
ice
> new file mode 100644
> index 0000000..f67bfd0
> --- /dev/null
> +++ b/config/rootfiles/packages/spice
> @@ -0,0 +1,23 @@
> +#usr/include/spice-server
> +#usr/include/spice-server/spice-audio.h
> +#usr/include/spice-server/spice-char.h
> +#usr/include/spice-server/spice-core.h
> +#usr/include/spice-server/spice-experimental.h
> +#usr/include/spice-server/spice-input.h
> +#usr/include/spice-server/spice-migration.h
> +#usr/include/spice-server/spice-qxl.h
> +#usr/include/spice-server/spice-server.h
> +#usr/include/spice-server/spice-version.h
> +#usr/include/spice-server/spice.h
> +usr/lib/libspice-server.a
> +usr/lib/libspice-server.la
> +usr/lib/libspice-server.so

No need to ship *.a, *.la and *.so. Those are only needed for linking other
packages and that sort of things.

> +usr/lib/libspice-server.so.1
> +usr/lib/libspice-server.so.1.10.0
> +usr/lib/pkgconfig/spice-server.pc

Don't ship pkg-config files either.

> +usr/lib/spice-protocol/python_modules/__init__.pyc
> +usr/lib/spice-protocol/python_modules/codegen.pyc
> +usr/lib/spice-protocol/python_modules/demarshal.pyc
> +usr/lib/spice-protocol/python_modules/marshal.pyc
> +usr/lib/spice-protocol/python_modules/ptypes.pyc
> +usr/lib/spice-protocol/python_modules/spice_parser.pyc

All these python files actually belong to the spice-protocol package. They are
just compiled and the bytecode files are generated when building this package.

Could you check if you can do that after the install phase of the last packag=
e?

> diff --git a/lfs/spice b/lfs/spice
> new file mode 100644
> index 0000000..80418b7
> --- /dev/null
> +++ b/lfs/spice
> @@ -0,0 +1,84 @@
> +##########################################################################=
###
> ##
> +#=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0
> =C2=A0#
> +# IPFire.org - A linux based
> firewall=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# Copyright (C) 2007-2016=C2=A0=C2=A0IPFire Team=C2=A0=C2=A0<info(a)ipfire=
.org>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0
> =C2=A0#
> +#=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0
> =C2=A0#
> +# This program is free software: you can redistribute it and/or
> modify=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# it under the terms of the GNU General Public License as published
> by=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# the Free Software Foundation, either version 3 of the License,
> or=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# (at your option) any later
> version.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +#=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0
> =C2=A0#
> +# This program is distributed in the hope that it will be
> useful,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0#
> +# but WITHOUT ANY WARRANTY; without even the implied warranty
> of=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0#
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.=C2=A0=C2=A0See
> the=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0#
> +# GNU General Public License for more
> details.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +#=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0
> =C2=A0#
> +# You should have received a copy of the GNU General Public
> License=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# along with this program.=C2=A0=C2=A0If not, see <http://www.gnu.org/lice=
nses/>.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0
> =C2=A0#
> +#=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0
> =C2=A0#
> +##########################################################################=
###
> ##
> +
> +##########################################################################=
###
> ##
> +# Definitions
> +##########################################################################=
###
> ##
> +
> +include Config
> +
> +VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D 0.12.6
> +
> +THISAPP=C2=A0=C2=A0=C2=A0=C2=A0=3D spice-$(VER)
> +DL_FILE=C2=A0=C2=A0=C2=A0=C2=A0=3D $(THISAPP).tar.bz2
> +DL_FROM=C2=A0=C2=A0=C2=A0=C2=A0=3D $(URL_IPFIRE)
> +DIR_APP=C2=A0=C2=A0=C2=A0=C2=A0=3D $(DIR_SRC)/$(THISAPP)
> +TARGET=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D $(DIR_INFO)/$(THISAPP)
> +PROG=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D spice
> +PAK_VER=C2=A0=C2=A0=C2=A0=C2=A0=3D 1
> +
> +DEPS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D "spice-protocol opus pyt=
hon-six python-pyparsing"

I like alphabetical ordering :)

> +
> +##########################################################################=
###
> ##
> +# Top-level Rules
> +##########################################################################=
###
> ##
> +
> +objects =3D $(DL_FILE)
> +
> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_MD5 =3D 605a8c8ea80bc95076c4b3539c6dd026
> +
> +install : $(TARGET)
> +
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +md5 : $(subst %,%_MD5,$(objects))
> +
> +dist:=C2=A0
> +	$(PAK)
> +
> +##########################################################################=
###
> ##
> +# Downloading, checking, md5sum
> +##########################################################################=
###
> ##
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> +	@$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> +	@$(LOAD)
> +
> +$(subst %,%_MD5,$(objects)) :
> +	@$(MD5)
> +
> +##########################################################################=
###
> ##
> +# Installation Details
> +##########################################################################=
###
> ##
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> +	@$(PREBUILD)
> +	cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE)
> +	cd $(DIR_APP) && ./configure --prefix=3D/usr --disable-celt051
> +	cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
> +	cd $(DIR_APP) && make install
> +	@rm -rf $(DIR_APP)
> +	@$(POSTBUILD)

Best,
-Michael

--===============7744213364140488651==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlc4WmVDQUFvSkVJQjU4UDl2a0FrSEp1WVAvUnlkSjMxL2M3TU9DZXFHY2RyQkRFNDEK
emlaS2gyRVNqN2pKVTc4RnFQR2tXblZPUWZRU1ppRUFDMm1qTWZwK2FPaHk1dWczV25ZTVlPRm50
dzdmekI0MApuVFM4T0ZmVk1CSTFsY3hBVVA4Tml1aENSeXZNVElTMllBQzVUc3FEK3gwbFdvMy80
dGdSM1VvQlRveU5JU1NPClYzcWN4NVkzdEM5RG9xOFgrSTNjMTgwUnB3YkVBTjJNNjlSc250OUVU
UjNWR0cwQndKRTZ2REcvc0Y5ZFVxdjkKUmVOZmI0KytNNElKYkZFTjhVKzdiUE0vSkhHRlZGRDRC
NGxjMEVPOWVCS000RmVrdll5aVJzRmhTN1JnMmRhbQozQytUZUhPZEpJKzVicVFrbzdScjRSdGRO
MkJmOHg1OTBpRFRueXhwdFFnSGkwSXlYWUN0bkM5azVHMWt5UEh3Cml0TkE1TXZuSTVET3JoRkNp
dW9JTXA2QkZzSGE3RGRCOTZjMHpJZ3hTZGZIbXhyemR2cmpoUlJrcDRrdHcrRHEKSHZqYXFzVkxS
TFpKcllZZkpGL2N3UDF4ZC8yUWNBWXFIZnlGSE45OGtKZHRvMFhmNWo1Nm56Z0pNem5zQTBkYQoz
Q1dRckNlL21neGlNVER3Qlo5UlJWbmsvWUhWUWV6Vk5DZXlLRW5nbGR4eXFRQWhQWUJYZHRPcnZR
akc3OU5CCnNhczdubEpnMlBXWDkzK01od21zcStsMXN3ZFpGSDZ6NE40bVFlZEV4cXRyZHJ6bnNw
anBjYmdWUzZiQU9pd24KWkwwQTc4QUpoY2pQcWNPSzcrS2twWE51czRIREhPV3ZCVndhNlVhbEQ1
VDNzOGxua1ZKOTVCYXdEYmwyZENqYwpGWUR0V1p0bk1EdUZZaEJ2MjBQYwo9blJkYgotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============7744213364140488651==--